From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=XEJt=E2=gentoo.org=sam@sourceware.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	by sourceware.org (Postfix) with ESMTP id 6FFC23858D33;
	Sun, 10 Sep 2023 15:37:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FFC23858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
References: <bf02c66f-a911-8ce0-9249-45bef80b418c@gmail.com>
User-agent: mu4e 1.10.6; emacs 30.0.50
From: Sam James <sam@gentoo.org>
To: =?utf-8?Q?Fran=C3=A7ois?= Dumont <frs.dumont@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [11/12/13/14 Regression] ABI break in
 _Hash_node_value_base since GCC 11 [PR 111050]
Date: Sun, 10 Sep 2023 16:36:48 +0100
Organization: Gentoo
In-reply-to: <bf02c66f-a911-8ce0-9249-45bef80b418c@gmail.com>
Message-ID: <87fs3mt4ym.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,BODY_8BITS,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>


Fran=C3=A7ois Dumont via Gcc-patches <gcc-patches@gcc.gnu.org> writes:

> Following confirmation of the fix by TC here is the patch where I'm
> simply adding a 'constexpr' on _M_next().
>
> Please let me know this ChangeLog entry is correct. I would prefer
> this patch to be assigned to 'TC' with me as co-author but I don't
> know how to do such a thing. Unless I need to change my user git
> identity to do so ?

git commit --author=3D"TC <email.here>" --amend

>
> =C2=A0=C2=A0=C2=A0 libstdc++: Add constexpr qualification to _Hash_node::=
_M_next()
>
> https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3D1b6f0476837205932613d=
db2b3429a55c26c409d
> =C2=A0=C2=A0=C2=A0 changed _Hash_node_value_base to no longer derive from
> _Hash_node_base, which means
> =C2=A0=C2=A0=C2=A0 that its member functions expect _M_storage to be at a=
 different
> offset. So explosions
> =C2=A0=C2=A0=C2=A0 result if an out-of-line definition is emitted for any=
 of the
> member functions (say,
> =C2=A0=C2=A0=C2=A0 in a non-optimized build) and the resulting object fil=
e is then
> linked with code built
> =C2=A0=C2=A0=C2=A0 using older version of GCC/libstdc++.
>
> =C2=A0=C2=A0=C2=A0 libstdc++-v3/ChangeLog:
>
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * incl=
ude/bits/hashtable_policy.h
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (_Hash=
_node_value_base<>::_M_valptr(),
> _Hash_node_value_base<>::_M_v())
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Add [[=
__gnu__::__always_inline__]].
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (_Hash=
_node<>::_M_next()): Add constexpr.
>
> =C2=A0=C2=A0=C2=A0 Co-authored-by: TC <rs2740@gmail.com>
>
> Ok to commit and backport to GCC 11, 12, 13 branches ?
>
> Fran=C3=A7ois
>
> [2. text/x-patch; pr111050.patch]...