From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id C7BCA3858C52 for ; Thu, 28 Sep 2023 17:37:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7BCA3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-34deefc2016so39762065ab.2 for ; Thu, 28 Sep 2023 10:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695922649; x=1696527449; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uWTTtlaRsWAu5xiPgy0Wwxt3kOBSJbmX37o0D+mBnkA=; b=XAIOGNsR20GI7/WJrIwSWxrNCrKZk79OuzuIJMdCvkZLmj+CDuJ8urewW9qWFiuJyh /9zalOF/xvEJCi3IngcuA/qagVR1LfaB1vMPwHtpXu8FHFuL0639ybkC3o38nxO2iPjx lf9fatg5sVGpcLmUyhrEoehwDtp25tJIJz/yhcmDEwcbYZoM8ttqR0k3ECHNlp9yyEIL YniEfQTc+JJaUNONIkrrvxMyEPk4XUKNydLvGY3SnZ0gQp8E7nzi/JCGI6krgXfnrKgM AF5NtGbkMbD66zvNKaq1wg6NwyVqqARNubbWQZapqhFNyqMh3WEyuFE6oXr0hvj/IbfL P5PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695922649; x=1696527449; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uWTTtlaRsWAu5xiPgy0Wwxt3kOBSJbmX37o0D+mBnkA=; b=cpAeNl3AULRBAlzcjqHs/N32EfJH/gkkx4AxBvX/uB3Grm9zCKvol/wVgBhG5wKdzj TuVfHPqalzX6koPqlpbLsFE8XnSocc0w+44tjYzwJa7/Z0+uieaf7K6BktteKLizAd4L QBr9oUeYzhVdMDrxXfLDrJCprr/kgXe1cPEUbx2N3wh3rBgeshxgbECCKwQDkG2FPwna NLp4dDLJYqvLthfM7FTGmBGpkpzTGye7+ATbFQW0iaS+1Xzk0eLSKdA5Yt3Qd9zW1PuT PniEJMMx+ps/Lso02gOV6T7Uq8pGBgcqanErkBjl0MCdNSOYhoI5ED3fvNchBP9XGYYm CE3Q== X-Gm-Message-State: AOJu0YwuhMAvrHUY/gIZaJhF3gsahq2KNFGNjti6p7UsKxRAgdkKMTwP 8zFxenyfWYSf90QJTeGPQd+Wjw== X-Google-Smtp-Source: AGHT+IG9VFg0DCSidpDRBEKqX2pR7Ufw88biYvGbx8/9pZSFCI3fIWHGtjbCpMTzsbE3G8ok47B3qw== X-Received: by 2002:a05:6e02:c62:b0:351:a18:51be with SMTP id f2-20020a056e020c6200b003510a1851bemr1584957ilj.15.1695922649038; Thu, 28 Sep 2023 10:37:29 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id j10-20020a056e020eea00b00351579b7e4bsm1705005ilk.37.2023.09.28.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 10:37:28 -0700 (PDT) From: Tom Tromey To: Jonathan Wakely Cc: Tom Tromey , Jonathan Wakely , Jonathan Wakely via Gcc-patches , "libstdc++" Subject: Re: [committed] libstdc++: Add GDB printers for types References: <20221222233804.772229-1-jwakely@redhat.com> <878r8r4og4.fsf@tromey.com> <874jjf4jia.fsf@tromey.com> X-Attribution: Tom Date: Thu, 28 Sep 2023 11:37:27 -0600 In-Reply-To: (Jonathan Wakely's message of "Thu, 28 Sep 2023 08:23:16 +0100") Message-ID: <87r0mi2o88.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jonathan> The changes made by black seem reasonable, though I prefer it Jonathan> with -S to disable string-normalization. It also needs an Jonathan> option to use 79 as the maximum line length. I've got some patches I'm about to send. I made a pyproject.toml to auto-configure black (and isort), and this works fine, but it also makes a bunch of edits. So I'd rather send that separately, after the current batch of patches is handled. flake8 still isn't really happy, I guess because there are strings that cause lines over 79, and black doesn't split those. But meh, maybe suppressing some flake8 errors is the way to go. Tom