From: Florian Weimer <fweimer@redhat.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: "Patrick Palka via Libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/5] libstdc++: Import the fast_float library
Date: Tue, 16 Nov 2021 10:46:22 +0100 [thread overview]
Message-ID: <87y25ocu1d.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAH6eHdSJqFS+7zbOjSb4o5a8YF62Chuqf9cQ=oA8niqYKEciVg@mail.gmail.com> (Jonathan Wakely's message of "Tue, 16 Nov 2021 09:32:46 +0000")
* Jonathan Wakely:
> On Tue, 16 Nov 2021 at 08:01, Florian Weimer wrote:
>>
>> * Patrick Palka via Libstdc:
>>
>> > This copies the fast_float library[1] into the compiled-in library
>> > sources. We're going to use this library in our floating-point
>> > std::from_chars implementation for faster and more portable parsing of
>> > binary32/64 decimal strings.
>> >
>> > [1]: https://github.com/fastfloat/fast_float
>> >
>> > Series tested on x86_64, i686, ppc64, ppc64le and aarch64, does it
>> > look OK for trunk?
>>
>> Missing Signed-off-by:?
>
> That's not needed if Patrick is still covered by an FSF assignment.
But the submission is not covered by the FSF assignment.
> I think we could use Apache as well, because this code isn't going to
> appear in public headers so the problematic clause doesn't apply. But
> MIT is simpler.
Okay, so you consider dynamic linking only? I think the historic
libstdc++ license is more permissive than Apache or MIT when used with
GCC. There aren't any notification or other requirements.
Thanks,
Florian
next prev parent reply other threads:[~2021-11-16 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 0:25 Patrick Palka
2021-11-16 0:25 ` [PATCH 2/5] libstdc++: Apply modifications to our local copy of fast_float Patrick Palka
2021-11-19 21:47 ` Patrick Palka
2021-11-16 0:25 ` [PATCH 3/5] libstdc++: Adjust fast_float's over/underflow behavior for conformnace Patrick Palka
2021-11-19 21:49 ` Patrick Palka
2021-11-16 0:25 ` [PATCH 4/5] libstdc++: Use fast_float in std::from_chars for binary32/64 Patrick Palka
2021-11-16 0:25 ` [PATCH 5/5] libstdc++: Import MSVC floating-point std::from_chars testcases Patrick Palka
2021-11-16 7:59 ` [PATCH 1/5] libstdc++: Import the fast_float library Florian Weimer
2021-11-16 9:32 ` Jonathan Wakely
2021-11-16 9:46 ` Florian Weimer [this message]
2021-11-16 11:34 ` Jonathan Wakely
2021-11-16 15:30 ` Patrick Palka
2021-11-16 16:18 ` Daniel Krügler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y25ocu1d.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).