From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9DA6E3857831 for ; Tue, 16 Nov 2021 09:46:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DA6E3857831 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-560-qfwfUUrdNm-CN9TbQ8f0Kg-1; Tue, 16 Nov 2021 04:46:27 -0500 X-MC-Unique: qfwfUUrdNm-CN9TbQ8f0Kg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2439E804140; Tue, 16 Nov 2021 09:46:26 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 121C457CB9; Tue, 16 Nov 2021 09:46:24 +0000 (UTC) From: Florian Weimer To: Jonathan Wakely Cc: "Patrick Palka via Libstdc++" , gcc-patches Subject: Re: [PATCH 1/5] libstdc++: Import the fast_float library References: <20211116002505.2324582-1-ppalka@redhat.com> <87ee7gedjk.fsf@oldenburg.str.redhat.com> Date: Tue, 16 Nov 2021 10:46:22 +0100 In-Reply-To: (Jonathan Wakely's message of "Tue, 16 Nov 2021 09:32:46 +0000") Message-ID: <87y25ocu1d.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 09:46:33 -0000 * Jonathan Wakely: > On Tue, 16 Nov 2021 at 08:01, Florian Weimer wrote: >> >> * Patrick Palka via Libstdc: >> >> > This copies the fast_float library[1] into the compiled-in library >> > sources. We're going to use this library in our floating-point >> > std::from_chars implementation for faster and more portable parsing of >> > binary32/64 decimal strings. >> > >> > [1]: https://github.com/fastfloat/fast_float >> > >> > Series tested on x86_64, i686, ppc64, ppc64le and aarch64, does it >> > look OK for trunk? >> >> Missing Signed-off-by:? > > That's not needed if Patrick is still covered by an FSF assignment. But the submission is not covered by the FSF assignment. > I think we could use Apache as well, because this code isn't going to > appear in public headers so the problematic clause doesn't apply. But > MIT is simpler. Okay, so you consider dynamic linking only? I think the historic libstdc++ license is more permissive than Apache or MIT when used with GCC. There aren't any notification or other requirements. Thanks, Florian