public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Julia DeMille <me@jdemille.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libsupc++: Fix UB terminating on foreign exception
Date: Sun, 14 Jan 2024 18:51:13 -0600	[thread overview]
Message-ID: <8acf8aa2-488d-4321-8555-8bdabfa89b23@jdemille.com> (raw)
In-Reply-To: <CAH6eHdSkaZ3PnXzYTaYAAcoZnRK01tp13ts_9gjoyqf8qctfug@mail.gmail.com>

On 2024-01-14 01:52, Jonathan Wakely wrote:
> The reason for this is that the ChangeLog files are auto-generated from 
> the git commit messages, not edited by hand. Patches to those files 
> rarely apply cleanly anyway, because they change so frequently that 
> patches are stale almost immediately.
Makes sense. I'm new to the GCC mailing lists, so that one was 
unfamiliar to me.

> That would be great thanks. If not obvious, easy instructions for 
> building the test would be helpful for Rust newbs such as myself!

I've actually managed to come up with a much more concise Objective-C 
demonstration. I've uploaded it at:
https://codeberg.org/jdemille/gcc-exception-ub-demo

I'm unsure if my patch actually fixes it with this demo -- I need to 
work out how to use a patched GCC without installing it on my system, 
but without it breaking from not having things it expects to exist on 
the system.

I'm also going to go make sure that the Objective-C unwind personality 
is unique, otherwise we could have trouble.

-- 
Thanks,
Julia DeMille
she/her


  reply	other threads:[~2024-01-15  0:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-14  0:05 Julia DeMille
2024-01-14  1:17 ` Andrew Pinski
2024-01-14  1:34   ` Julia DeMille
2024-01-14  7:52     ` Jonathan Wakely
2024-01-15  0:51       ` Julia DeMille [this message]
2024-01-15  3:39         ` Julia DeMille
2024-01-15 17:31           ` Julia DeMille
2024-04-09 17:24             ` Julia DeMille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8acf8aa2-488d-4321-8555-8bdabfa89b23@jdemille.com \
    --to=me@jdemille.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely.gcc@gmail.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).