From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frs.dumont@gmail.com>
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [IPv6:2a00:1450:4864:20::42c])
 by sourceware.org (Postfix) with ESMTPS id 50ED63858406;
 Tue, 28 Sep 2021 20:20:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 50ED63858406
Received: by mail-wr1-x42c.google.com with SMTP id u18so443808wrg.5;
 Tue, 28 Sep 2021 13:20:40 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding
 :content-language;
 bh=dohIho2iB8hqoyz6i1jVBhwCoj+vgAxzzhq2LfsE7qg=;
 b=3TRdv1Ze20CSJiDQrBL3Dioq6d+YG2qGYvNgsmwWnNkafK6jVwLXwyKA/qjnCBvxui
 WP5ms/aw91TIRPjUb/MRUKlJ8yr73QjBmPDIEHF/oMr4yQZH2FysFb01IS+WN8NVIWzq
 rX1Pdgvfaw5ssPHsgeQNK+XykiAYgX01p9r4vouk+AvaRA3V6efh1NH8B1/Wt9/iXEQ2
 NVWpNKr9j7J/TP7UOTZJVKLWDDbY55m7BHkUKoM7NRleDDqMGzabJnFiclSzjEkzP46t
 JGN47W5sz6CIDD7u8YuS2yxGnyXBtB/+wbLSf6/HQGax9sPn2EKIRRW8obLPv2kFa44j
 jyoQ==
X-Gm-Message-State: AOAM530QK+5dhWynPBuVLxTvvCjP09pxedyUxJBwxFQyJfvLuEdsogry
 m21tMRv8VL2nUhtlARpfIU206pUdqXs=
X-Google-Smtp-Source: ABdhPJw2ZPx3ChUqE03ENAzZfvn14vX58qwRfKCaXXyp4e8KOpN3SoIFK6AmI+0VUzkyibOUBF4bRw==
X-Received: by 2002:adf:f9cb:: with SMTP id w11mr2441560wrr.266.1632860437563; 
 Tue, 28 Sep 2021 13:20:37 -0700 (PDT)
Received: from ?IPv6:2a01:e0a:1dc:b1c0:944:cd3e:d6dd:218?
 ([2a01:e0a:1dc:b1c0:944:cd3e:d6dd:218])
 by smtp.googlemail.com with ESMTPSA id 10sm3539985wmi.1.2021.09.28.13.20.35
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 28 Sep 2021 13:20:35 -0700 (PDT)
Subject: Re: Fix 48631_neg test in _GLIBCXX_VERSION_NAMESPACE mode
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
References: <5e13b454-0722-01ef-8e62-e88654fe9021@gmail.com>
 <CAH6eHdQCk-ehrz5bULq3C=N1VW0LQNXMB8A5fzRWOOOKZ3oEpQ@mail.gmail.com>
From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= <frs.dumont@gmail.com>
Message-ID: <900f1af6-7bed-f78d-0601-e011ccc63d3a@gmail.com>
Date: Tue, 28 Sep 2021 22:20:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAH6eHdQCk-ehrz5bULq3C=N1VW0LQNXMB8A5fzRWOOOKZ3oEpQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Sep 2021 20:20:41 -0000

On 27/09/21 11:06 pm, Jonathan Wakely wrote:
> On Mon, 27 Sept 2021 at 21:26, François Dumont via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
>> Here is a small patch to fix a test which fails in
>> _GLIBCXX_VERSION_NAMESPACE mode.
>>
>> IMHO it would be better to avoid putting <type_traits> content in
>> versioned namespace, no ?

No opinion on this, you prefer to use consistently the versioned namespace ?


>>
>> There is of course more work to do, so for now here is the simpler approach.
>>
>> Ok to commit ?
> Leaving the pattern ending with just "struct" isn't very useful.
> Wouldn't it be better to do:
>
> // { dg-prune-output "no type named 'type' in" }
>
> or just:
>
> // { dg-prune-output "enable_if" }
>
> ?
>
> Either of those is OK to commit.

Done with "enable_if"