From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31474 invoked by alias); 17 Nov 2019 15:49:19 -0000 Mailing-List: contact libstdc++-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libstdc++-owner@gcc.gnu.org Received: (qmail 31392 invoked by uid 89); 17 Nov 2019 15:49:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=unavailable version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Nov 2019 15:49:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574005756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp:autocrypt:autocrypt; bh=9steWQWfdcLHQw9hrpukBg90d8P1yJlBDvxE4OmDT7w=; b=gnE4FkmNIMf5qe4iZUeWVnawhPG3wXp0qci2oLsiFUJjcma7vZVOpNGvIPn/Ad1c5yEKFZ 4p/LFqXnzoZahnYUtlaeYZ13YyXrmzMpink3FOVclFPTZ4u/etYutJMx16aed6fVy6MVu8 KNKYXBOulsSUrBmbYE1Y3I0UO6YHBAg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-151-RiIDEN9pP9eXBenawmExag-1; Sun, 17 Nov 2019 10:49:13 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 343DD477; Sun, 17 Nov 2019 15:49:12 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-33.rdu2.redhat.com [10.10.112.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DB2261070; Sun, 17 Nov 2019 15:49:10 +0000 (UTC) Subject: Re: [C++ coroutines 1/6] Common code and base definitions. To: Iain Sandoe , GCC Patches , libstdc++ References: <285E6AA6-17E6-4E7F-9F37-852707896DA1@sandoe.co.uk> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <9540c3f5-1382-6e21-cb3d-9d6613bdb7fe@redhat.com> Date: Sun, 17 Nov 2019 15:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <285E6AA6-17E6-4E7F-9F37-852707896DA1@sandoe.co.uk> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-11/txt/msg00060.txt.bz2 On 11/17/19 3:24 AM, Iain Sandoe wrote: > This part of the patch series provides the gating flag, the keywords, > cpp defines etc. >=20 > gcc/ChangeLog: >=20 > 2019-11-17 Iain Sandoe >=20 > * doc/invoke.texi: Document the fcoroutines command line > switch. >=20 > gcc/c-family/ChangeLog: >=20 > 2019-11-17 Iain Sandoe >=20 > * c-common.c (co_await, co_yield, co_return): New. > * c-common.h (RID_CO_AWAIT, RID_CO_YIELD, > RID_CO_RETURN): New enumeration values. > (D_CXX_COROUTINES): Bit to identify coroutines are active. > (D_CXX_COROUTINES_FLAGS): Guard for coroutine keywords. > * c-cppbuiltin.c (__cpp_coroutines): New cpp define. > * c.opt (fcoroutines): New command-line switch. >=20 > gcc/cp/ChangeLog: >=20 > 2019-11-17 Iain Sandoe >=20 > * cp-tree.h (lang_decl-fn): coroutine_p, new bit. > * lex.c (init_reswords): Enable keywords when the coroutine flag > is set, > * operators.def (co_await): New operator. Looks quite reasonable to me. If you need minor twiddling due to reviewer feedback elsewhere those are pre-approved as well. jeff