From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fx408.security-mail.net (smtpout140.security-mail.net [85.31.212.148]) by sourceware.org (Postfix) with ESMTPS id B6356383D81C for ; Thu, 22 Jul 2021 09:19:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6356383D81C Received: from localhost (localhost [127.0.0.1]) by fx408.security-mail.net (Postfix) with ESMTP id 37D751B7B37C for ; Thu, 22 Jul 2021 11:19:19 +0200 (CEST) Received: from fx408 (localhost [127.0.0.1]) by fx408.security-mail.net (Postfix) with ESMTP id E0D071B7B204; Thu, 22 Jul 2021 11:19:18 +0200 (CEST) Received: from zimbra2.kalray.eu (unknown [217.181.231.53]) by fx408.security-mail.net (Postfix) with ESMTPS id 5B77B1B7B1AE; Thu, 22 Jul 2021 11:19:18 +0200 (CEST) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTPS id 0100227E0341; Thu, 22 Jul 2021 11:19:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id DE00D27E0351; Thu, 22 Jul 2021 11:19:17 +0200 (CEST) Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C_NBVU48P1pB; Thu, 22 Jul 2021 11:19:17 +0200 (CEST) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id CC7CD27E0341; Thu, 22 Jul 2021 11:19:17 +0200 (CEST) X-Virus-Scanned: E-securemail, by Secumail Secumail-id: <175b1.60f93816.1728f.0> DKIM-Filter: OpenDKIM Filter v2.10.3 zimbra2.kalray.eu DE00D27E0351 Date: Thu, 22 Jul 2021 11:19:17 +0200 (CEST) From: Marc Poulhies To: Jonathan Wakely Cc: libstdc++ , gcc-patches , Luc Michel Message-ID: <96439410.1009244.1626945557332.JavaMail.zimbra@kalray.eu> In-Reply-To: References: <1855720815.793351.1626790336484.JavaMail.zimbra@kalray.eu> <291496446.934555.1626879744068.JavaMail.zimbra@kalray.eu> Subject: Re: [NEWS] libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.40.202] X-Mailer: Zimbra 9.0.0_GA_3990 (ZimbraWebClient - FF89 (Linux)/9.0.0_GA_3990) Thread-Topic: libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target Thread-Index: ADmmvSwlILPItBY5uNUCJPUB3S8Fbw== X-ALTERMIMEV2_out: done X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2021 09:19:22 -0000 ----- Original Message ----- > From: "Jonathan Wakely" > To: "Marc Poulhies" > Cc: "libstdc++" , "gcc-patches" , "Luc Michel" > Sent: Wednesday, July 21, 2021 5:53:52 PM > Subject: Re: [NEWS] libstdc++: Fix testsuite for skipping gdb tests on remote/non-native target > Thanks for the patch. I agree we should skip the version checks, not > only the actual tests. But I wonder whether we want to do that in > xmethods.exp and prettyprinters.exp rather than in the gdb_batch_check > proc. Or maybe like this instead: > > I don't think it really makes much difference, I'm just unsure what is > "cleaner" and more consistent with DG conventions and/or the rest of > the gdb-test.exp file. Here are a bit more information on the issue we are having. While trying to understand why the testsuite is taking a long time to execute, we (Luc in Cc) discovered that the logs contain: Spawning: gdb -nw -nx -quiet -batch -ex "python print(gdb.lookup_global_symbol)" spawn -ignore SIGHUP kvx-mppa --unnamed-log --bootcluster=node0 --no-trap --no-gdb-attach --dcache-no-check -- gdb -nw -nx -quiet -batch -ex python print(gdb.lookup_global_symbol) UNSUPPORTED: prettyprinters.exp testcase /work1/mpoulhies/tools-csw/gcc/libstdc++-v3/testsuite/libstdc++-prettyprinters/prettyprinters.exp completed in 613 seconds kvx-mppa being a simulator and gdb the host (x86) binary. The strangest part being that running the command by hand will fail immediately, but when DG is running the tests, it waits until the timeout is reached: we don't understand this behavior, but we get several processes probably waiting to be joined.. I don't have a strong opinion here as I'm really no DG expert. I find the filtering in gdb-test maybe more robust as it prevents any error like the above. Having the test in prettyprinters/xmethod allows for quicker exit (saves 15s here), but I don't see that as a strong argument. Thanks for the review, Marc