From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.rbg.tum.de (mailout2.rbg.tum.de [IPv6:2a09:80c0::202]) by sourceware.org (Postfix) with ESMTPS id B71553858D3C; Tue, 19 Apr 2022 11:32:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B71553858D3C Received: from mailrelay1.rbg.tum.de (mailrelay1.in.tum.de [131.159.254.14]) by mailout2.rbg.tum.de (Postfix) with ESMTPS id 7051B4C02BA; Tue, 19 Apr 2022 13:32:17 +0200 (CEST) Received: by mailrelay1.rbg.tum.de (Postfix, from userid 112) id 6B7606D7; Tue, 19 Apr 2022 13:32:17 +0200 (CEST) Received: from mailrelay1.rbg.tum.de (localhost [127.0.0.1]) by mailrelay1.rbg.tum.de (Postfix) with ESMTP id 4A09C55F; Tue, 19 Apr 2022 13:32:17 +0200 (CEST) Received: from mail.in.tum.de (mailproxy.in.tum.de [IPv6:2a09:80c0::78]) by mailrelay1.rbg.tum.de (Postfix) with ESMTPS id 4878924E; Tue, 19 Apr 2022 13:32:17 +0200 (CEST) Received: by mail.in.tum.de (Postfix, from userid 112) id 45C2F4A047E; Tue, 19 Apr 2022 13:32:17 +0200 (CEST) Received: (Authenticated sender: fent) by mail.in.tum.de (Postfix) with ESMTPSA id E6B9D4A01CD; Tue, 19 Apr 2022 13:32:16 +0200 (CEST) (Extended-Queue-bit xtech_us@fff.in.tum.de) Content-Type: multipart/mixed; boundary="------------sYJaN8kuSbPKERtbc8G7dj0k" Message-ID: <991c9996-feb3-74e7-0ef6-d03846984624@in.tum.de> Date: Tue, 19 Apr 2022 13:32:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] libstdc++: Add pretty printer for std::span Content-Language: en-US To: Jonathan Wakely Cc: libstdc++ , gcc-patches References: <20220404105257.199452-1-fent@in.tum.de> From: Philipp Fent In-Reply-To: X-Spam-Status: No, score=-16.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 11:32:20 -0000 This is a multi-part message in MIME format. --------------sYJaN8kuSbPKERtbc8G7dj0k Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.04.22 12:28, Jonathan Wakely wrote: > Thanks, but we still need the DCO sign-off as I mailed about last week. Thanks for the clarification, your last mail didn't appear to have content, so I might have missed that part. I've now added my DCO sign-off. Best Philipp --------------sYJaN8kuSbPKERtbc8G7dj0k Content-Type: text/x-patch; charset=UTF-8; name="libstdc-Add-pretty-printer-for-std-span.patch" Content-Disposition: attachment; filename="libstdc-Add-pretty-printer-for-std-span.patch" Content-Transfer-Encoding: base64 RnJvbSA2NGI2Nzc5YzI2OTRmNTc5ODFlMTViOWMxZGZhNTliMTkyZTk5YTE2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIEZlbnQgPGZlbnRAaW4udHVtLmRlPgpE YXRlOiBNb24sIDQgQXByIDIwMjIgMTI6NTI6NTcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBs aWJzdGRjKys6IEFkZCBwcmV0dHkgcHJpbnRlciBmb3Igc3RkOjpzcGFuCgpUaGlzIGltcHJv dmVzIHRoZSBkZWJ1ZyBvdXRwdXQgZm9yIEMrKzIwIHNwYW5zLgpCZWZvcmU6CntzdGF0aWMg ZXh0ZW50ID0gMTg0NDY3NDQwNzM3MDk1NTE2MTUsIF9NX3B0ciA9IDB4N2ZmZmZmZmZiOWE4 LApfTV9leHRlbnQgPSB7X01fZXh0ZW50X3ZhbHVlID0gMn19Ck5vdyB3aXRoIFN0ZFNwYW5Q cmludGVyOgpzdGQ6OnNwYW4gb2YgbGVuZ3RoIDIgPSB7MSwgMn0KClNpZ25lZC1vZmYtYnk6 IFBoaWxpcHAgRmVudCA8ZmVudEBpbi50dW0uZGU+Ci0tLQogbGlic3RkYysrLXYzL3B5dGhv bi9saWJzdGRjeHgvdjYvcHJpbnRlcnMucHkgIHwgMzggKysrKysrKysrKysrKysrKysrKwog Li4uL2xpYnN0ZGMrKy1wcmV0dHlwcmludGVycy9jeHgyMC5jYyAgICAgICAgIHwgMTEgKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9s aWJzdGRjKystdjMvcHl0aG9uL2xpYnN0ZGN4eC92Ni9wcmludGVycy5weSBiL2xpYnN0ZGMr Ky12My9weXRob24vbGlic3RkY3h4L3Y2L3ByaW50ZXJzLnB5CmluZGV4IGY3YTdmOTk2MWE3 Li42ZDhiNzY1ZjJkYSAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL3B5dGhvbi9saWJzdGRj eHgvdjYvcHJpbnRlcnMucHkKKysrIGIvbGlic3RkYysrLXYzL3B5dGhvbi9saWJzdGRjeHgv djYvcHJpbnRlcnMucHkKQEAgLTE2NTQsNiArMTY1NCw0MyBAQCBjbGFzcyBTdGRSZWdleFN0 YXRlUHJpbnRlcjoKICAgICAgICAgICAgIHMgPSAie30sIHt9PXt9Ii5mb3JtYXQocywgdiwg c2VsZi52YWxbJ19NXycgKyB2XSkKICAgICAgICAgcmV0dXJuICJ7JXN9IiAlIChzKQogCitj bGFzcyBTdGRTcGFuUHJpbnRlcjoKKyAgICAiUHJpbnQgYSBzdGQ6OnNwYW4iCisKKyAgICBj bGFzcyBfaXRlcmF0b3IoSXRlcmF0b3IpOgorICAgICAgICBkZWYgX19pbml0X18oc2VsZiwg YmVnaW4sIHNpemUpOgorICAgICAgICAgICAgc2VsZi5jb3VudCA9IDAKKyAgICAgICAgICAg IHNlbGYuYmVnaW4gPSBiZWdpbgorICAgICAgICAgICAgc2VsZi5zaXplID0gc2l6ZQorCisg ICAgICAgIGRlZiBfX2l0ZXJfXyAoc2VsZik6CisgICAgICAgICAgICByZXR1cm4gc2VsZgor CisgICAgICAgIGRlZiBfX25leHRfXyAoc2VsZik6CisgICAgICAgICAgICBpZiBzZWxmLmNv dW50ID09IHNlbGYuc2l6ZToKKyAgICAgICAgICAgICAgICByYWlzZSBTdG9wSXRlcmF0aW9u CisKKyAgICAgICAgICAgIGNvdW50ID0gc2VsZi5jb3VudAorICAgICAgICAgICAgc2VsZi5j b3VudCA9IHNlbGYuY291bnQgKyAxCisgICAgICAgICAgICByZXR1cm4gJ1slZF0nICUgY291 bnQsIChzZWxmLmJlZ2luICsgY291bnQpLmRlcmVmZXJlbmNlKCkKKworICAgIGRlZiBfX2lu aXRfXyhzZWxmLCB0eXBlbmFtZSwgdmFsKToKKyAgICAgICAgc2VsZi50eXBlbmFtZSA9IHR5 cGVuYW1lCisgICAgICAgIHNlbGYudmFsID0gdmFsCisgICAgICAgIGlmIHZhbC50eXBlLnRl bXBsYXRlX2FyZ3VtZW50KDEpID09IGdkYi5wYXJzZV9hbmRfZXZhbCgnc3RhdGljX2Nhc3Q8 c3RkOjpzaXplX3Q+KC0xKScpOgorICAgICAgICAgICAgc2VsZi5zaXplID0gdmFsWydfTV9l eHRlbnQnXVsnX01fZXh0ZW50X3ZhbHVlJ10KKyAgICAgICAgZWxzZToKKyAgICAgICAgICAg IHNlbGYuc2l6ZSA9IHZhbC50eXBlLnRlbXBsYXRlX2FyZ3VtZW50KDEpCisKKyAgICBkZWYg dG9fc3RyaW5nKHNlbGYpOgorICAgICAgICByZXR1cm4gJyVzIG9mIGxlbmd0aCAlZCcgJSAo c2VsZi50eXBlbmFtZSwgc2VsZi5zaXplKQorCisgICAgZGVmIGNoaWxkcmVuKHNlbGYpOgor ICAgICAgICByZXR1cm4gc2VsZi5faXRlcmF0b3Ioc2VsZi52YWxbJ19NX3B0ciddLCBzZWxm LnNpemUpCisKKyAgICBkZWYgZGlzcGxheV9oaW50KHNlbGYpOgorICAgICAgICByZXR1cm4g J2FycmF5JworCiAjIEEgInJlZ3VsYXIgZXhwcmVzc2lvbiIgcHJpbnRlciB3aGljaCBjb25m b3JtcyB0byB0aGUKICMgIlN1YlByZXR0eVByaW50ZXIiIHByb3RvY29sIGZyb20gZ2RiLnBy aW50aW5nLgogY2xhc3MgUnhQcmludGVyKG9iamVjdCk6CkBAIC0yMTcwLDYgKzIyMDcsNyBA QCBkZWYgYnVpbGRfbGlic3RkY3h4X2RpY3Rpb25hcnkgKCk6CiAgICAgbGlic3RkY3h4X3By aW50ZXIuYWRkX3ZlcnNpb24oJ3N0ZDo6JywgJ3BhcnRpYWxfb3JkZXJpbmcnLCBTdGRDbXBD YXRQcmludGVyKQogICAgIGxpYnN0ZGN4eF9wcmludGVyLmFkZF92ZXJzaW9uKCdzdGQ6Oics ICd3ZWFrX29yZGVyaW5nJywgU3RkQ21wQ2F0UHJpbnRlcikKICAgICBsaWJzdGRjeHhfcHJp bnRlci5hZGRfdmVyc2lvbignc3RkOjonLCAnc3Ryb25nX29yZGVyaW5nJywgU3RkQ21wQ2F0 UHJpbnRlcikKKyAgICBsaWJzdGRjeHhfcHJpbnRlci5hZGRfdmVyc2lvbignc3RkOjonLCAn c3BhbicsIFN0ZFNwYW5QcmludGVyKQogCiAgICAgIyBFeHRlbnNpb25zLgogICAgIGxpYnN0 ZGN4eF9wcmludGVyLmFkZF92ZXJzaW9uKCdfX2dudV9jeHg6OicsICdzbGlzdCcsIFN0ZFNs aXN0UHJpbnRlcikKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvbGlic3Rk YysrLXByZXR0eXByaW50ZXJzL2N4eDIwLmNjIGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS9s aWJzdGRjKystcHJldHR5cHJpbnRlcnMvY3h4MjAuY2MKaW5kZXggYjBkZTI1YzI3ZWMuLjc2 MDIzZGY5M2ZhIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvdGVzdHN1aXRlL2xpYnN0ZGMr Ky1wcmV0dHlwcmludGVycy9jeHgyMC5jYworKysgYi9saWJzdGRjKystdjMvdGVzdHN1aXRl L2xpYnN0ZGMrKy1wcmV0dHlwcmludGVycy9jeHgyMC5jYwpAQCAtMTgsOCArMTgsMTAgQEAK IC8vIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORzMuICBJZiBub3Qg c2VlCiAvLyA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCiAKKyNpbmNsdWRlIDxh cnJheT4KICNpbmNsdWRlIDxjb21wYXJlPgogI2luY2x1ZGUgPGlvc3RyZWFtPgorI2luY2x1 ZGUgPHNwYW4+CiAKIHN0cnVjdCBYCiB7CkBAIC01NCw2ICs1NiwxNSBAQCBtYWluKCkKICAg YXV0byBjMTAgPSAwLjAgPD0+IF9fYnVpbHRpbl9uYW4oIiIpOwogLy8geyBkZy1maW5hbCB7 IG5vdGUtdGVzdCBjMTAgInN0ZDo6cGFydGlhbF9vcmRlcmluZzo6dW5vcmRlcmVkIiB9IH0K IAorICBhdXRvIGlsID0gezEsIDJ9OworICBhdXRvIHMxID0gc3RkOjpzcGFuKGlsKTsKKyAg c3RhdGljX2Fzc2VydChzMS5leHRlbnQgPT0gc3RkOjpzaXplX3QoLTEpKTsKKy8vIHsgZGct ZmluYWwgeyBub3RlLXRlc3QgczEge3N0ZDo6c3BhbiBvZiBsZW5ndGggMiA9IHsxLCAyfX0g fSB9CisgIGF1dG8gYSA9IHN0ZDo6YXJyYXl7MywgNH07CisgIGF1dG8gczIgPSBzdGQ6OnNw YW4oYSk7CisgIHN0YXRpY19hc3NlcnQoczIuZXh0ZW50ID09IHN0ZDo6c2l6ZV90KDIpKTsK Ky8vIHsgZGctZmluYWwgeyBub3RlLXRlc3QgczIge3N0ZDo6c3BhbiBvZiBsZW5ndGggMiA9 IHszLCA0fX0gfSB9CisKICAgc3RkOjpjb3V0IDw8ICJcbiI7CiAgIHJldHVybiAwOwkJCS8v IE1hcmsgU1BPVAogfQotLSAKMi4zNS4zCgo= --------------sYJaN8kuSbPKERtbc8G7dj0k--