From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7E0E6385772A for ; Tue, 20 Jun 2023 16:07:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E0E6385772A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687277248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uB3Tu8zzEMtW+c+BBuQOMQg14qPJYr9lFWKNLcHjj7Q=; b=fv29AvmPrEOmfTCMKZP5zmhdwadhGl+IZrTjUZvw/AG7W7S4rcc1vKpYIorygVTg1cCdZ6 qCX0q5lM/FzRI/3LlILXHFYSQgKRYinYj6koRVPkbJ0hfr/YEchhz55mAiGVeJYpMXs4H4 MgbKn+BhIiyPhyJgbz6qpyPj4Qc0e8M= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-_wyyTonHPUanGCTfZY8dvg-1; Tue, 20 Jun 2023 12:07:25 -0400 X-MC-Unique: _wyyTonHPUanGCTfZY8dvg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-62fec3555d0so54424516d6.2 for ; Tue, 20 Jun 2023 09:07:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687277223; x=1689869223; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uB3Tu8zzEMtW+c+BBuQOMQg14qPJYr9lFWKNLcHjj7Q=; b=OCBfsypn6zO6auL6SWp3uPQ1yoRFf7DojUUP5UR1LwUt00S7CfYLhrXEn50TWb6dr6 pvglM9na2kSDhx19jfqDLT4ELXPGNTr1ce9VKUeZKjVZ5ROsGIpwIqWlZzAfaKuYN7A2 +TwtuUIM11xvsoTK9+7n1gUA4l9sqWrrB6csn5iFQ2HSm7bz3ln2+vlW+fV3v6fp24xq dTUVhCtbXX69O8DWdEJYJ9ExDKOWG+iT9d1Ac3MWHDjEgRrdSu32bbLnB5i0bIIXb7cM nofI5MnXcGAiEGrHuibZ6Mp7plOycLouB81TqI+S2Halhm8Upo6exw5UFFJ2E2nUDA2a OCWw== X-Gm-Message-State: AC+VfDycrdc2yM2K5ck/zrGZzsVFQCtnKF0KU6+EIWa93uJBSvnplQ1E tiS9wgDvh0/zoYEIL8AUlsfrMK5CSWo6zVTUIHr1psIoGslD4WSZ5AH5HSsQU5GDuHAizyxbxmB aYE54lBfbr/3qSww= X-Received: by 2002:a05:6214:248d:b0:630:21a6:bb51 with SMTP id gi13-20020a056214248d00b0063021a6bb51mr7352557qvb.46.1687277222963; Tue, 20 Jun 2023 09:07:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5dsOisJKP3omzecyxTAdGcCQhAP//cP9XxXfZRrOupnLcmT6FwE6CxgXElIB4dU20GB93yzQ== X-Received: by 2002:a05:6214:248d:b0:630:21a6:bb51 with SMTP id gi13-20020a056214248d00b0063021a6bb51mr7352529qvb.46.1687277222569; Tue, 20 Jun 2023 09:07:02 -0700 (PDT) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id p6-20020a0cf546000000b00623819de804sm1370142qvm.127.2023.06.20.09.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 09:07:02 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Tue, 20 Jun 2023 12:07:01 -0400 (EDT) To: Ken Matsui cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH v7 2/6] libstdc++: use new built-in trait __is_reference for std::is_reference In-Reply-To: <20230612224909.21188-3-kmatsui@cs.washington.edu> Message-ID: <99f70a7e-9f5f-fbe2-78c2-524012eefab6@idea> References: <20230612224109.20749-1-kmatsui@cs.washington.edu> <20230612224909.21188-1-kmatsui@cs.washington.edu> <20230612224909.21188-3-kmatsui@cs.washington.edu> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 12 Jun 2023, Ken Matsui via Libstdc++ wrote: > This patch gets std::is_reference to dispatch to new built-in trait > __is_reference. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_reference): Use __is_reference built-in > trait. > (is_reference_v): Likewise. LGTM > > Signed-off-by: Ken Matsui > --- > libstdc++-v3/include/std/type_traits | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 0e7a9c9c7f3..2a14df7e5f9 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -639,6 +639,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > // Composite type categories. > > /// is_reference > +#if __has_builtin(__is_reference) > + template > + struct is_reference > + : public __bool_constant<__is_reference(_Tp)> > + { }; > +#else > template > struct is_reference > : public false_type > @@ -653,6 +659,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > struct is_reference<_Tp&&> > : public true_type > { }; > +#endif > > /// is_arithmetic > template > @@ -3192,12 +3199,19 @@ template > inline constexpr bool is_class_v = __is_class(_Tp); > template > inline constexpr bool is_function_v = is_function<_Tp>::value; > + > +#if __has_builtin(__is_reference) > +template > + inline constexpr bool is_reference_v = __is_reference(_Tp); > +#else > template > inline constexpr bool is_reference_v = false; > template > inline constexpr bool is_reference_v<_Tp&> = true; > template > inline constexpr bool is_reference_v<_Tp&&> = true; > +#endif > + > template > inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; > template > -- > 2.41.0 > >