From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 5AAB73858D32; Sun, 8 Oct 2023 14:06:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5AAB73858D32 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-32167a4adaaso3306116f8f.1; Sun, 08 Oct 2023 07:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1696774001; x=1697378801; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wP3L9X5i1VvL2I0Zj0762cCJiqly6NQ0VhUDNFgOEQk=; b=Q2Jcw1eo6ib9VhdWg2l5MGRUCww9nEK/y94NgrXnSvMl0d9IUWbyoH2/z6qpcHm6ql PPWG7c3wNGtlHnr1fJwUCwn2P5gkJfABnBnl38iKfALNNu5uHKK8JGMbyRrM5uTZYCvw 6dy+r29ivAkKkHEO7TGtLhpeGwFj2Z6UBkdGmuLNr47xwQTDwqw8OvvzTgjxlw7yHFK3 y5Om/jpFtv83nfTIAtrGypqq3llpLaeoNcCGe12ewJ+s3MnD4vf+dcm0yvE4t65eKDdF RQd10TsC/NbHOhS50EzU1qmT1MHwnYz2jFhyfPgXC97RCVorokJxXASVNyHJtnKr12Tq ukYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696774001; x=1697378801; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wP3L9X5i1VvL2I0Zj0762cCJiqly6NQ0VhUDNFgOEQk=; b=bzW5A/107y0Y9r7Bn/MbBcToGDsjSyEwv/fuSyiYB7p/6rFpV7VE5uEFUkxdbeOYVA ISVNKKPsd+yM8UGt+bpMBUB+bQfdc1uZZwRI0OrWRSkDlPQBZpg4e7W1fDrJIDiRvCvO pRX1fxiM7UEAV51NMDwyUIgb+jJztlf07XIIaJI/87Cpq2yRRl5VTC6Eks9Z5u/OzhaM PUudc+bbduMoe97SYW0xDBKMyRP6jXPHtoUXJFZL19s+6LJ5TBGZRF3HPNngWRdU/qfF pNOEZYZK4r/pTSRBrFdCPZGjSvuYHyG4c5Do0IX8C9ZQarmY8NvrHrw8Jr4CKmnN/WIi 0gqg== X-Gm-Message-State: AOJu0YyGLLJTlWOh1RD8e2qPdpAn3bMyRtMjkpkd3pafNiH9LpK18JeV zVEiqgsZ4JhEr+big2ewhtI= X-Google-Smtp-Source: AGHT+IEx7pXUbmkcMdaDvPt37FVWPKSUMC/oJ4cTkT29oBWD/AXSMDl9ootY534oXZAOz8Y0X/0W7w== X-Received: by 2002:adf:f34a:0:b0:316:f25c:d0c0 with SMTP id e10-20020adff34a000000b00316f25cd0c0mr12153143wrp.16.1696774000842; Sun, 08 Oct 2023 07:06:40 -0700 (PDT) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id c17-20020a056000105100b003231ca246b6sm6889683wrx.95.2023.10.08.07.06.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 07:06:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix From: Iain Sandoe In-Reply-To: Date: Sun, 8 Oct 2023 15:06:38 +0100 Cc: Jonathan Wakely , libstdc++ , GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: <9C6DC8AF-8F62-41F7-B3A5-A2D1B2E201FC@googlemail.com> References: <55f0212a-f8d3-aa9e-8788-f5165484ac6c@gmail.com> <520bd324-39e8-45e0-a367-3d1195c1807f@gmail.com> To: =?utf-8?Q?Fran=C3=A7ois_Dumont?= X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Fran=C3=A7ois, > On 21 Sep 2023, at 05:41, Fran=C3=A7ois Dumont = wrote: >=20 > Tests were successful, ok to commit ? >=20 > On 20/09/2023 19:51, Fran=C3=A7ois Dumont wrote: >> libstdc++: [_GLIBCXX_INLINE_VERSION] Add handle_contract_violation = symbol alias >>=20 >> libstdc++-v3/ChangeLog: >>=20 >> * src/experimental/contract.cc >> [_GLIBCXX_INLINE_VERSION](handle_contract_violation): Provide = symbol alias >> without version namespace decoration for gcc. This does not work in the source on targets without support for symbol = aliases (Darwin is one) =E2=80=9C../experimental/contract.cc:79:8: warning: alias definitions = not supported in Mach-O; ignored=E2=80=9D - there might be a way to do it at link-time (for one symbol not too = bad); I will have to poke at it a bit. Iain >>=20 >> Here is what I'm testing eventually, ok to commit if successful ? >>=20 >> Fran=C3=A7ois >>=20 >> On 20/09/2023 11:32, Jonathan Wakely wrote: >>> On Wed, 20 Sept 2023 at 05:51, Fran=C3=A7ois Dumont via Libstdc++ >>> wrote: >>>> libstdc++: Remove std::constract_violation from versioned namespace >>> Spelling mistake in contract_violation, and it's not >>> std::contract_violation, it's std::experimental::contract_violation >>>=20 >>>> GCC expects this type to be in std namespace directly. >>> Again, it's in std::experimental not in std directly. >>>=20 >>> Will this change cause problems when including another experimental >>> header, which does put experimental below std::__8? >>>=20 >>> I think std::__8::experimental and std::experimental will become = ambiguous. >>>=20 >>> Maybe we do want to remove the inline __8 namespace from all >>> experimental headers. That needs a bit more thought though. >>>=20 >>>> libstdc++-v3/ChangeLog: >>>>=20 >>>> * include/experimental/contract: >>>> Remove = _GLIBCXX_BEGIN_NAMESPACE_VERSION/_GLIBCXX_END_NAMESPACE_VERSION. >>> This line is too long for the changelog. >>>=20 >>>> It does fix 29 g++.dg/contracts in gcc testsuite. >>>>=20 >>>> Ok to commit ? >>>>=20 >>>> Fran=C3=A7ois