From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 720A33858D3C for ; Mon, 16 May 2022 17:00:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 720A33858D3C Received: by mail-wm1-x32c.google.com with SMTP id 1-20020a05600c248100b00393fbf11a05so11302956wms.3 for ; Mon, 16 May 2022 10:00:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Ie6k2OL/HsGhzwO86cQ5GuNQdg4xOOCOpRpRxUbDvNE=; b=cLWrBQWd81aST0oxGN+bNMVyIt91KGdfElda/Mw3DYhscyxZRyx/ilNHmSfzNmyaJc MKvdKjnc9hzqqesLNbqf+extvFwflzT5tY99XMreCJdoIgqq3WO5rfj/9u4Nm8+0ulJQ Ax5DFw0c+EoKRlJAVPRmuOsio37pZ7xFnY6tAFozlkRqp+X7bbw7LWGXgeSKpK39m25u ZFlywoh+1/UReiBB0pNAJpzNUyHL4iwcFgpM7qhpzprJeLLrH6lNvSjAqYPRqoSsL0NK EMNayHNvZNC8wlPgjulVF0lUVXv44IJDeFJK3kRz9N21NREVA1M7w4KYBgoVv/DmqW/4 pyAg== X-Gm-Message-State: AOAM531QMofUBZ0yYoZj4oyyOq7Z9a3JOJYzatfhG4xPkiwRW6BMmaYy 7o2NFk+JQe6WusJgRiaNQtMjwF0QsWg= X-Google-Smtp-Source: ABdhPJyiLXzBl/OiQ60sXlvZuU7eyvPmhUy5nWSPdhlmDNV06XDv7nQA1qvYmOqDauhzI1/v18Show== X-Received: by 2002:a7b:c3c2:0:b0:394:9229:3b40 with SMTP id t2-20020a7bc3c2000000b0039492293b40mr17730288wmj.195.1652720398070; Mon, 16 May 2022 09:59:58 -0700 (PDT) Received: from [10.13.0.77] ([109.190.253.11]) by smtp.googlemail.com with ESMTPSA id w6-20020adf8bc6000000b0020c5253d8besm10301161wra.10.2022.05.16.09.59.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 09:59:57 -0700 (PDT) Message-ID: <9c215d8d-dc13-ea1e-1f06-dcd401221ee4@gmail.com> Date: Mon, 16 May 2022 18:59:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [committed 03/12] libstdc++: Add macros for the inline namespace std::_V2 Content-Language: en-US To: Jonathan Wakely Cc: libstdc++ References: <20220513124050.4028450-1-jwakely@redhat.com> <20220513124050.4028450-3-jwakely@redhat.com> <65a5eb4c-8c9e-4bc6-846a-a06b1f6d5c1e@gmail.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 17:00:02 -0000 Great, thanks for explaining what compatibility files are for. I can't wait to see the impact of this patch on the abi tests. Especially for my patch to use cxx11 abi std::string for the version namespace mode. François On 16/05/22 18:13, Jonathan Wakely wrote: > On Sat, 14 May 2022 at 16:36, François Dumont via Libstdc++ > wrote: >> Versioned namespace does not compile after this patch. With this patch >> it compiles but does not link because of: >> >> /usr/bin/ld: /usr/bin/ld: DWARF error: can't find .debug_ranges section. >> ../src/c++11/.libs/libc++11convenience.a(chrono.o): in function >> `std::__8::chrono::system_clock::now()': >> chrono.cc:(.text._ZNSt3__86chrono12system_clock3nowEv+0x0): multiple >> definition of `std::__8::chrono::system_clock::now()'; /usr/bin/ld: >> DWARF error: can't find .debug_ranges section. >> .libs/compatibility-chrono.o:compatibility-chrono.cc:(.text._ZNSt3__86chrono12system_clock3nowEv+0x0): >> first defined here > Oops, I knew I'd forgotten to check something! > > I think the attached patch would be better. This stops defining the > C++0x compat symbols for the versioned namespace. Those symbols only > exist for backwards compatibility with ancient versions of > libstdc++.so.6 (from GCC 4.6 and similar vintages). We don't need > those symbols in libstdc++.so.8 at all. > > This fixes the versioned namespace build, I'm running the tests now.