From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR06-AM7-obe.outbound.protection.outlook.com (mail-am7eur06olkn2059.outbound.protection.outlook.com [40.92.16.59]) by sourceware.org (Postfix) with ESMTPS id 4C6F4385E447; Wed, 19 May 2021 13:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4C6F4385E447 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W9uZJd8MY2nRU/hVUx4kVh6K7RLrSf39SSuyqFk1tTheRtjoxWXxn6+RtQC5q4FInJQ6NuSZflHFyujDLd6FH6tEsRyQCRsaoBkp3zt+GajIBpsDgBfb2nGxmeEfiiH6E5nVhcq1FiE+iNJScUt91z76Lx0qpSCycNRmJLAlz6+4M1DYlQTetfntmFnoc9AbSBrSuUgFOgWZTtZdh+kefDsSgvuhT6yFqnKv7yHPj94dbCSXxPC075pxiBrNqZpcXifViJ5LBN2lKaV/0PpZmUf/dSWQyPHXhSCL8iiWFmJACJAAVzfdaRtUpFn5hCK2/zqXLQsVJAI0gUoUYbg1UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9nmGJjFj7qte7wFCV5py+dVP6MC2Vhbjly+OunVOE0=; b=G3ElI79LTtX6EOf49cv4VMGwqpwDIh5J/iZms49teY7sNI3zUoYfPnV7l9rnCEXysDj/ocrBv65HKfYwKG3oJlPRwK8f5sUbrADookk/OrF/3KiQX2rwKzNz4/Cl/8/Lq9aeMLvSbd5rFyfASueCdnroaKCGXDAONdOKpbIPlbcnpcwJVQqoU5tkH/ujhuUdbMbkSrDKg3fqLyhg0fX5Xyov3aJvaLm1svHdo6EiX+Gw6rQrrraZUsy4vmi4bHu+RjoqfFn1xehxKLjOSZhA/XU/FfYLV1ikq06bGYAs6+i2A6Qk0CicDSaJ7L2YeRIarx0dQEhaISefXw1143U6Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AM7EUR06FT007.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::50) by AM7EUR06HT004.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::458) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 13:37:38 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:fc36::4c) by AM7EUR06FT007.mail.protection.outlook.com (2a01:111:e400:fc36::273) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 19 May 2021 13:37:38 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:D3F67DA65478F762B9E03FD2BAE72802E6E4169B90EFE41D7D73349435080E8E; UpperCasedChecksum:4E8D89577EF966AE10AB052F47B824A00779B5FE4853663CC45039855E1834AB; SizeAsReceived:8029; Count:48 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::e41b:107f:af82:150a]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::e41b:107f:af82:150a%7]) with mapi id 15.20.4129.033; Wed, 19 May 2021 13:37:38 +0000 Subject: Re: [committed] libstdc++: Fix std::jthread assertion and re-enable skipped test To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org References: From: Bernd Edlinger Message-ID: Date: Wed, 19 May 2021 15:37:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TMN: [3ms5HxTxKnT6bkY5HwB0vuUQRT07KIK6] X-ClientProxiedBy: PR0P264CA0213.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::33) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.61.94) by PR0P264CA0213.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.32 via Frontend Transport; Wed, 19 May 2021 13:37:37 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c8d1c3dd-4d5b-4528-b1c1-08d91acb4487 X-MS-TrafficTypeDiagnostic: AM7EUR06HT004: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a1UUIBic5DMhtLOEfxwTC7YGt+GEeIWLz5eSznRcRREcMPokDi9bqNe8B2o0FsWJ4SvcCxxLGeyJtLvdLB5i8LKJohY4WP8cnqiwG4zw23PDOVGuc0vDppKwIL4t+EvNdbnfNxOK7E6XfLGOQd0NXMlb6RpCRfh5QOcYoxG/q5bgyjGAt5onnj/bJmF31hfLO7Y1kOZzeysdAwbFDxb3wx6wFbbChAL1aco37ACezTfwwQik7ZHEoHQVPXRTMZQM9smbjzKXeLUZM3d0FXcePyTX0WoArcg9fb+tf/gCxsktTSrU4mho4dS5AG7akfrePAep+GEhKNQI6EBdIdkw2cXHSdEoqw6NYCqv8Pzv9kK1oXiA1HDb/WLZ228VDEFxcM8zOxb8SE0Vl7PoP9skTw== X-MS-Exchange-AntiSpam-MessageData: T8KXkyeDC/J8KxxG1un9ipdiRW5hZic6+8SVEC20T3fC/L7iAoe9yEinVybPClyzuRaX64GwfudPrpjTcWXXwVwpN3CxkuXh6ZIIlaVoSqYFuq/V0RYWH3xjT+2f6t0cDIUiO1ayaNlqzE7LW99Piw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8d1c3dd-4d5b-4528-b1c1-08d91acb4487 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2021 13:37:38.2760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM7EUR06FT007.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7EUR06HT004 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 13:37:42 -0000 On 5/19/21 3:27 PM, Jonathan Wakely wrote: > On 18/05/21 13:58 +0200, Bernd Edlinger wrote: >> On 5/18/21 1:55 PM, Bernd Edlinger wrote: >>> On 5/17/21 7:13 PM, Jonathan Wakely via Gcc-patches wrote: >>>> libstdc++-v3/ChangeLog: >>>> >>>>     * include/std/thread (jthread::_S_create): Fix static assert >>>>     message. >>>>     * testsuite/30_threads/jthread/95989.cc: Re-enable test. >>>>     * testsuite/30_threads/jthread/jthread.cc: Do not require >>>>     pthread effective target. >>>>     * testsuite/30_threads/jthread/2.cc: Moved to... >>>>     * testsuite/30_threads/jthread/version.cc: ...here. >>>> >>>> Tested powerpc64le-linux. Committed to trunk. >>>> >>>> Let's see if this test is actually fixed, or if it still causes >>>> failures on some targets. >>>> >>>> >>> >>> Yes, indeed it is failing on x86_64-pc-linux-gnu. >>> >> >> that means only this one: >> >> FAIL: 30_threads/jthread/95989.cc execution test > > What's your glibc version? > > that is ubuntu 20.04 with latest patches: $ ldd --version ldd (Ubuntu GLIBC 2.31-0ubuntu9.3) 2.31 Copyright (C) 2020 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Written by Roland McGrath and Ulrich Drepper. Bernd.