From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id D37E83844770; Mon, 13 May 2024 06:29:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D37E83844770 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D37E83844770 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715581773; cv=none; b=YbMUxb8c25OuuBFNvbfAlntLnaP23Dy7eXAX42G9q5ITr8S/vvv+17E8czH+/VlUWz+xuYgxAuUge36uuuP1SqwJH3Xz9BOtroVks8Cmq+MUJPA689bcLbsspVB6aQpSKYtP65hUnhNYirOCkQlYWUTTX3PrBf0Lma1LJPzGvEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715581773; c=relaxed/simple; bh=Qt41SPszYhYli7cZS1Ta4SEkk6D64OcpYObk4HayT98=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=ANoERCQKu7mxQyOv6Z1C7NclrZr+ZZvzDCJaPsmdaV0xtiunMFzS3cHbKoZ5AA7Qecv+MtCHgZIHIVzNz2dVKhntP2aayQZveqYIUgOxIfd4TJLlicVbjBFDeGJ1WOkCn4f1bBSbn2O9jeiHttAcAV50wQdqQ/x4C4rh4hMU6X0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-41fd5dc03easo23649885e9.1; Sun, 12 May 2024 23:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1715581770; x=1716186570; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b21+CaS2cLUFpp7vIFjMNrfQrtBEUl7YAb1notE3xs4=; b=F8iOvSuexNVPR+L5Xo7Bi402VxQ48EiWBgVt8xTz6fPcPrPTnrFnAlKVA8XQzLps+/ 1v7zxcX2uH24CMhyvHmfYVeSxUJKJMe3EJ+kQY7hn5UwYFjdT7pKd8qgi2nzfs0YCZrO RNKoebTNg16NyYzikD+QdR6rGJZh3N0+rSUVfLZTkkpP+UuixYAqrnHbR5PNAAJ7iSTl yjtnQpJsT11Q21mqVhlXcw6NTzx959ZwE9qN4ZEeaHcEAbQB1/CJIgzHxtD7+K2xj3/o NF8iVtoJlGlPIGhjXblyYaLdY9nDrwjEwEa5nVE9PKmwLHlsJM0IG6S01ZnxppqxJa52 J8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715581770; x=1716186570; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b21+CaS2cLUFpp7vIFjMNrfQrtBEUl7YAb1notE3xs4=; b=rNvvqzdvCW7cNb9DLGd7pzmZ3nSW9N01uzyMJL25UklHYQ3tYsFfPD/lLLyqUEsLXC iu4JlUoN/TEIOkiLSEPOP6bZ5LPSr0ZxwNw2wAtZlopR2oDrhHeuWQwyJ1/p4e1ue+a9 4PSC5OrZlaPMofRvm5kusn8SJU3/yRrikrYRdhZcG9coXFVQlqkLGuJDFBYG+fqUVuzq pNYV9M6H8gK0/G7kYai6ZcasQe1oRrePfQKloP7z62JJTVhhb+A0CwM0GStoBdwRMdqS 1RwZtYSOUU7qPFhPRSQjJVN1nUrUjYOFn0bZ8fu/cFaBClmMrFsuJ4167tnFVFbMYCO5 146A== X-Forwarded-Encrypted: i=1; AJvYcCWE1ZZA+enlivkT0vAMNpmzUG/skM6uEKJGdwTP9qvKIOEQresQEN7sSX5QLTBvA9LUqfksh4NXBf5L4YO+DqlUqwxI3Fbczg== X-Gm-Message-State: AOJu0YwYt+D22VYc05OpXN17uCEsyeejaX/dzxgjvp+VFEbo7aaOeab8 fL74njd4hw+Hy2cpyBO0EIKboVjJNB2lV3UZRVTk+x5m229omdw1 X-Google-Smtp-Source: AGHT+IHgdisx/eX3qr+hb02nKb1A52vt82GrBhrJxMhEK6RY/wsVpTQFg1m+8W/KUDi1MuCZ6qpCKQ== X-Received: by 2002:a05:600c:138b:b0:419:f9ae:e50 with SMTP id 5b1f17b1804b1-41fead6ac32mr66389065e9.37.1715581770244; Sun, 12 May 2024 23:29:30 -0700 (PDT) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-41facbd295fsm164704965e9.36.2024.05.12.23.29.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 May 2024 23:29:29 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\)) Subject: Re: Fix gnu versioned namespace mode 00/03 From: Iain Sandoe In-Reply-To: Date: Mon, 13 May 2024 07:29:28 +0100 Cc: libstdc++ , GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <08F3F058-B58A-4FC2-B83E-A0B271791C39@googlemail.com> To: =?utf-8?Q?Fran=C3=A7ois_Dumont?= X-Mailer: Apple Mail (2.3696.120.41.1.8) X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 13 May 2024, at 06:06, Fran=C3=A7ois Dumont = wrote: >=20 >=20 > On 07/05/2024 18:15, Iain Sandoe wrote: >> Hi Fran=C3=A7ois >>=20 >>> On 4 May 2024, at 22:11, Fran=C3=A7ois Dumont = wrote: >>>=20 >>> Here is the list of patches to restore gnu versioned namespace mode. >>>=20 >>> 1/3: Bump gnu version namespace >>>=20 >>> This is important to be done first so that once build of gnu = versioned namespace is fixed there is no chance to have another build of = '__8' version with a different abi than last successful '__8' build. >>>=20 >>> 2/3: Fix build using cxx11 abi for versioned namespace >>>=20 >>> 3/3: Proposal to default to "new" abi when dual abi is disabled and = accept any default-libstdcxx-abi either dual abi is enabled or not. >>>=20 >>> All testsuite run for following configs: >>>=20 >>> - dual abi >>>=20 >>> - gcc4-compatible only abi >>>=20 >>> - new only abi >>>=20 >>> - versioned namespace abi >> At the risk of delaying this (a bit) - I think we should also = consider items like once_call that have broken impls. > Do you have any pointer to this once_call problem, sorry I'm not aware = about it (apart from your messages). (although this mentions one specific target, it applies more widely). https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D66146 Also, AFAICT, any nested once_call is a problem (not just exceptions). >> in the current library - and at least get proposed replacements = available behind the versioned namespace; rather than using up a = namespace version with the current broken code. >=20 > I'm not proposing to fix all library bugs on all platforms with this = patch, just fix the versioned namespace mode. Sorry, I was not intending to suggest that (although perhaps my comments = read that way). I was trying to suggest that, in the case where we have proposed fixes = that are blocked because they are ABI breaks, that those could be put = behind the versioned namspace (it was not an intention to suggest that = such additions should be part of this patch series). > As to do so I also need to adopt cxx11 abi in versioned mode it = already justify a bump of version. I see - it=E2=80=99s just a bit strange that we are bumping a version = for a mode that does not currently work; however, i guess someone might = have deployed it even so. >=20 > The reason I'm proposing to integrate this patch this early in gcc 15 = stage is to have time to integrate any other library fix/optimization = that could make use of it. I already have 1 on my side for the hashtable = implementation Ah, then I think we are aiming for the same thing. > . I hope your once_call fix also have time to be ready for gcc 15, no = ? Yes; if we put it behind the versioned namespace - there are (I think) = several proposed solutions to that specific issue. thanks Iain >=20 > Fran=C3=A7ois