From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 88C53384A031 for ; Tue, 9 Feb 2021 10:55:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 88C53384A031 Received: by mail-ej1-x62c.google.com with SMTP id hs11so30593607ejc.1 for ; Tue, 09 Feb 2021 02:55:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ljMVGc4b6ccYnHLXLw/UrS0r3Zlv5sI5erRf3HguqQ4=; b=Jx70mZJOreJo/cGLETOQmKKeqqbwMxXEHo6m5AD9woQ14WIoGtyT3fdd1r4H7fg9Fq tL9okpk35eGb2An8u7hc6UfLVil4GCr7tXmlcuDDJGIt7JmY00j/G9PSxFz33h3v+Ah9 3Ldh/xzdFtZOn27kvV1QPt4+XqBJCMoGQcxcG3aOMWyrh1sLNQTrTLGsmMEeMIbXqpQ3 3q1PvuEsOLUPAq8UNEPe/u7VLCkPvsLlRTgRNxfnN3DQ0iXrK1Cnu0CT/NtKgEC3MUZl Pd2biXTR/mAnEhTQH+nOuZj3lFB1o5JlqqfVVuyP0C9b/L5DYoAkPoXI2xcX6L14qPL3 5Smw== X-Gm-Message-State: AOAM531YgiY1awTxqzL6YvX0udO8XkF7//qMgNK0pqfHGQ/abjtTZhkO OeQOCZKA5e6mNZwIeOelgmIAISgg8fTg5dKUpTw= X-Google-Smtp-Source: ABdhPJw3G/GJUfLbl8jl1tsnExu9Mpgm9eO1Zup1MLYadhbT7e16vzsLns049kvjAjbjGYZ+Dpmw6zETnXeUjhsby3s= X-Received: by 2002:a17:907:7605:: with SMTP id jx5mr21952301ejc.340.1612868100462; Tue, 09 Feb 2021 02:55:00 -0800 (PST) MIME-Version: 1.0 References: <20201207203033.GI2309743@redhat.com> <87sg8h8i2e.fsf@keithp.com> <20201207210659.GK2309743@redhat.com> <20210108182111.GE9471@redhat.com> <20210208174539.GN3008@redhat.com> <20210208174707.GO3008@redhat.com> <20210209104756.GW3008@redhat.com> In-Reply-To: <20210209104756.GW3008@redhat.com> From: Vladimir V Date: Tue, 9 Feb 2021 11:54:49 +0100 Message-ID: Subject: Re: Problem building libstdc++ for the avr target To: Jonathan Wakely Cc: Keith Packard , libstdc++@gcc.gnu.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 10:55:03 -0000 Thank you for the review. > My best guess is that it is there because that file previously used > lstat and the linux lstat(2) man page (IMHO incorrectly) says that > is needed. I got the same feeling as well. =D0=B2=D1=82, 9 =D1=84=D0=B5=D0=B2=D1=80. 2021 =D0=B3. =D0=B2 11:48, Jonath= an Wakely : > On 08/02/21 23:25 +0100, Vladimir V wrote: > >Thank you for the reply. > > > >>> I don't see why this file includes , it doesn't *seem* to > >>> need it. Even if it's needed, the correct way to include it is: > > > >So it was there since the initial commit but during my quick walk throug= h > >the history > >I didn't find what API from was used. > > My best guess is that it is there because that file previously used > lstat and the linux lstat(2) man page (IMHO incorrectly) says that > is needed. > > >So, in the patch I just deleted the include but as Keith suggested it ca= n > >affect the client code. > >If the policy is: > > > >>> We routinely remove such transitive includes. Any code assuming that > >>> defines the contents of is wrong and should be > >>> fixed. > > > >then I would keep it like that. > >Or would it be better to update the patch to move it inside the guard? > > I will commit your patch unchanged. In practice it is unlikely to > affect anybody, because that header is only used when compiling > libstdc++ itself. I don't see any code in the Debian archives using it > except for GCC itself and one testcase in the Clang repo. > > >