From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 7E7EC3858D33; Wed, 16 Aug 2023 16:50:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E7EC3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe85fd3d27so11229102e87.0; Wed, 16 Aug 2023 09:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692204649; x=1692809449; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5c5I9v8awDsOpks3UUnUn2lpvaZYa3N9M7fgRm3YARQ=; b=rAp9Hi/6JbUpT6XBCuO7ZPqEYgBtJR+5x3lTOabbWbT83d3or0krDEgYufBmHISO77 XyBmGe6hZ+ewQeZaBY7rhGUcdeLHSicfTK6OEDLom/L50J0QuuRUpNaLbCjnqk4ICwts YyHH5RXCkikRliHs9FKRIXs7mBwH0AkzAbPEdad+0p/ACMOWvMut7b2QX0NjOM5YXKa6 CQOsMCtAficikQQaAQNTuhMuGBIWYZLGdYglCkpwk8eeBUEQ+tRkXXwIIhLFCIn9toxy pNLG7NDG3067H3LxM+JDvQSUvpHHAQoBZ79+5sAMsDqAQcdfyqoSZDqP7bOGl50m+O1f WhJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692204649; x=1692809449; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5c5I9v8awDsOpks3UUnUn2lpvaZYa3N9M7fgRm3YARQ=; b=bjvNv/6gp6BdtFoqx6T8M8wdKz5cfTW/yyB7cs1g06s84IMe255ckamrd47i9At55f 66uw6N4M/eoKxWbLlJDZS4nvMJ/04McCSOejzJvGC3rps95pthgjKH+ZumeqlWExmvaO kCutKvsA598pq9yxXHk0uNktwe3OXXRZepglCITORnZWuHjA8OLDEXh6xDbhHTGPdQQL /LKPflAz9ABnb7L6meTwrd6zPduQdY1yyHyMo15Fq6Aa/iGX2mx0dZvj4wK57oKjHbBa BJMld2u7uk2vRQ+7J4waUbXiLDmTYNWTSQxYs/o2GUs2ifHgyTv3H8tOSDef7mc71nao 74KQ== X-Gm-Message-State: AOJu0YwdQaT4c/wwQJdQYjYPkXXNxVct/nLbYSqH7vWjDW/jJBcCsPeu lOMBZs9cFpkBqpPqsMM4M58IUlI1HYYR5j+x4Pk= X-Google-Smtp-Source: AGHT+IHUafuUEh0W9aSUzXj5m4Ue1dBxKQiko2FlZTvJAvtnQkaHWHzDxGZ0AzT5/9+/LLbK/dEMHVmPOCWejVHvC/A= X-Received: by 2002:a19:c512:0:b0:4fe:279b:7603 with SMTP id w18-20020a19c512000000b004fe279b7603mr1663171lfe.14.1692204648948; Wed, 16 Aug 2023 09:50:48 -0700 (PDT) MIME-Version: 1.0 References: <86leeb9jtz.fsf@aarsen.me> In-Reply-To: <86leeb9jtz.fsf@aarsen.me> From: "Paul M. Bendixen" Date: Wed, 16 Aug 2023 18:50:33 +0200 Message-ID: Subject: Re: [PATCH] libstdc++ Add cstdarg to freestanding To: =?UTF-8?Q?Arsen_Arsenovi=C4=87?= Cc: Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000fce6f706030d189b" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000fce6f706030d189b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, the other files are in another committee proposal, and I'm working my way through the proposals one by one. Thank you for the feedback, I'll update and resend /Paul Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenovi=C4=87 : > > Jonathan Wakely writes: > > > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > > wrote: > >> > >> P1642 includes the header cstdarg to the freestanding implementation. > >> This was probably left out by accident, this patch puts it in. > >> Since this is one of the headers that go in whole cloth, there should > be no > >> further actions needed. > > > > Thanks for the patch. I agree that should be freestanding, > > but I think and were also missed from the > > change. Arsen? > > Indeed, we should include all three, and according to [compliance], > there's a couple more headers that we should provide (cwchar, cstring, > cerrno, and cmath, but these are probably significantly more involved, > so we can handle them separately). > > As guessed, the omission was not intentional. > > If you could, add those two to the patch as well, edit Makefile.am and > regenerate using automake 1.15.1, and see > https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. > > Thank you! Have a lovely day :-) > > [compliance]: https://eel.is/c++draft/compliance > > > Also, the patch should change include/Makefile.am as well (the .in > > file is autogenerated from that one). > > > > > >> This might be related to PR106953, but since that one touches the > partial > >> headers I'm not sure > > The headers mentioned in this PR are provided in freestanding, > partially, in 13 already, indeed. > > >> /Paul M. Bendixen > >> > >> -- > >> =E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92/=E2=80=A2 = =E2=80=A2 =E2=88=92/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=88=92 =E2= =80=A2 =E2=80=A2 =E2=80=A2/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=88=92 =E2=80= =A2 =E2=80=A2/=E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80=A2 =E2=80=A2 =E2=88=92/= =E2=80=A2/=E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2=E2=88= =92 > >> =E2=80=A2/=E2=88=92 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92/=E2=80=A2 = =E2=88=92/=E2=80=A2 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2= =80=A2 =E2=88=92 =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92/=E2=88=92 =E2=80= =A2 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=88=92/=E2=88=92 =E2=88=92// > > > -- > Arsen Arsenovi=C4=87 > --=20 =E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92/=E2=80=A2 =E2= =80=A2 =E2=88=92/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80= =A2 =E2=80=A2 =E2=80=A2/=E2=80=A2/=E2=88=92 =E2=80=A2/=E2=88=92 =E2=80=A2 = =E2=80=A2/=E2=80=A2 =E2=80=A2/=E2=88=92 =E2=80=A2 =E2=80=A2 =E2=88=92/=E2= =80=A2/=E2=88=92 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=88=92 =E2=80=A2=E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92/=E2=80=A2 =E2= =88=92/=E2=80=A2 =E2=80=A2/=E2=80=A2 =E2=88=92 =E2=80=A2 =E2=80=A2/=E2=80= =A2 =E2=88=92 =E2=80=A2 =E2=88=92 =E2=80=A2 =E2=88=92/=E2=88=92 =E2=80=A2 = =E2=88=92 =E2=80=A2/=E2=88=92 =E2=88=92 =E2=88=92/=E2=88=92 =E2=88=92// --000000000000fce6f706030d189b--