From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C6EF03858C3A for ; Thu, 14 Mar 2024 15:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6EF03858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6EF03858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710429246; cv=none; b=izjxS33S+5p0RRFHJW0jyfqv2I0fLDwwHqKXL9JkBJVg59Le7vOCaFOV4lJNq28n8X1jVxXsW48fMj918Mo9ky5DyWXj+VHrCxTb7/lOssXoZkGUhsqzXP0VEe/FrKaMJvnyd3F1TiAbsAlK2LnO0MmjgzoUivraTAB4GVi3tv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710429246; c=relaxed/simple; bh=/JB5sU/kXVevGQVT9BmrDiFZur5bbLaAY+g9yaFLh5E=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=E2kD16pMRn2nn5OXx8KdmyelMMFRBwsYhglfE/IR8cHMnsT4KtnR5KhB+gORQIrFRglG2rGL8kfJxiZyNFBE+u0XIk04HlG3moIrTioBz0OBrKpKbkJoEpqE/mdJ5gMP3lNgHm5+2Jt5A82UvDG2nwiEJFl4UX5PNGX3foUBg7g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710429244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/JB5sU/kXVevGQVT9BmrDiFZur5bbLaAY+g9yaFLh5E=; b=ZlCynR69e9Aoq/SK/VBht8OeF3YJ0UMb5t5tkt7YXFoQiNsg/+kgBwsruixjuBHxHud++J qPJV0gQQY0Us1FEzjD3u604v/8xyB045d6KB3yMz7m+bbsnEJV2/LIrJj39z1A2JHtY23g vj5ZL2uYaxqzT7SVtibmrbvTtoKf28w= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-c5lmV8cwMAqFEuaPjqsXNA-1; Thu, 14 Mar 2024 11:13:59 -0400 X-MC-Unique: c5lmV8cwMAqFEuaPjqsXNA-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-60ab69a9e6fso22158397b3.0 for ; Thu, 14 Mar 2024 08:13:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710429239; x=1711034039; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/JB5sU/kXVevGQVT9BmrDiFZur5bbLaAY+g9yaFLh5E=; b=Bbxbr7UGhNSR1wi6G+3x2G6QKWKPk27geMLSzyAu7uzqmftTDk8FX9cMtURL3+rdFL 4PQW/+CCxczkZ0I/Z/GFiIl/UwmnTsTm7WFMN3cxK0R7H44K2Z7S53ReEIws2GICdAa2 57k/BuM7hMMIUQfz2tPZR9wYsi9vg8/pO1cx0IzyHrvWLPik7zi05W5YJn4UDdZk0N4K 6pvaRyuUG/4KHi9vczd4O9ELgMVBFTHwu0sA72mLDT6wYwVGYomhzvqehHaNEX4Ajssb w5Q/89gUZ0fhcKNacDum79c6AlgYBvwPO6zoH72tZ3Q4L+fZGN0Z5GHVGhPb31Ac76uy VuVg== X-Forwarded-Encrypted: i=1; AJvYcCUuPQHDMoj27h31T857QRd6ajf2XYyRAWVtFgbpkHMbrUdQpVk+E82TNwuKlCdLwA2FAWF6lYnVncxnUQxCx5Ow/Azyf+o= X-Gm-Message-State: AOJu0YzycqqKE8Vm+48sgCQSd6J+YBS0/WL0Wz/+yp98WxdoQkYnjxZo x4+3KQfzGacFDTUhHv1ypaCvg8eJ1BS3xouakSkO61jhvYe+ndQB8ue9VJ3mN8JDo2a1QoCquVp 7DyHrO6j/tlRw2Mg+aKuy2Vb09zB2nk+l3hs95u63gEf6El0UHDPrfoQQ9fnA7Mzm6E0oWe1TUW gt7T+To/qGsKtFdGP5ud0MdQ1ypXY= X-Received: by 2002:a25:bd3:0:b0:dcf:2697:5ca3 with SMTP id 202-20020a250bd3000000b00dcf26975ca3mr4365685ybl.5.1710429239222; Thu, 14 Mar 2024 08:13:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH4yQSfikdhpqITkpUYrZAG1uY7f//Cib5ht89EqEXlMkjQy0M6cfogzLirROcExuzwHgdgI4zhcncLMbuPCLU= X-Received: by 2002:a25:bd3:0:b0:dcf:2697:5ca3 with SMTP id 202-20020a250bd3000000b00dcf26975ca3mr4365661ybl.5.1710429238874; Thu, 14 Mar 2024 08:13:58 -0700 (PDT) MIME-Version: 1.0 References: <9f2bdd3a973d98199bb5b322baa575ab2fba8a58.camel@xry111.site> In-Reply-To: From: Jonathan Wakely Date: Thu, 14 Mar 2024 15:13:42 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: atomic: Add missing clear_padding in __atomic_float constructor To: Jakub Jelinek Cc: xndcn , Xi Ruoyao , "H.J. Lu" , GCC Patches , libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000032edf10613a057a3" X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000032edf10613a057a3 Content-Type: text/plain; charset="UTF-8" On Fri, 16 Feb 2024 at 15:15, Jonathan Wakely wrote: > > On Fri, 16 Feb 2024 at 14:10, Jakub Jelinek wrote: > > > > On Fri, Feb 16, 2024 at 01:51:54PM +0000, Jonathan Wakely wrote: > > > Ah, although __atomic_compare_exchange only takes pointers, the > > > compiler replaces that with a call to __atomic_compare_exchange_n > > > which takes the newval by value, which presumably uses an 80-bit FP > > > register and so the padding bits become indeterminate again. > > > > __atomic_compare_exchange_n only works with integers, so I guess > > it is doing VIEW_CONVERT_EXPR (aka union-style type punning) on the > > argument. > > > > Do you have preprocessed source for the testcase? > > Sent offlist. Jakub fixed the compiler, so I've pushed the attached patch now. Tested x86_64-linux. --00000000000032edf10613a057a3 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ltrde00r0 Y29tbWl0IDBhZGM4YzVmMTQ2YjEwOGY5OWM0ZGYwOWU0MzI3NmUzYTI0MTkyNjIKQXV0aG9yOiB4 bmRjbiA8eG5kY2huQGdtYWlsLmNvbT4KRGF0ZTogICBGcmkgRmViIDE2IDExOjAwOjEzIDIwMjQK CiAgICBsaWJzdGRjKys6IEFkZCBtaXNzaW5nIGNsZWFyX3BhZGRpbmcgaW4gX19hdG9taWNfZmxv YXQgY29uc3RydWN0b3IKICAgIAogICAgRm9yIDgwLWJpdCBsb25nIGRvdWJsZSB3ZSBuZWVkIHRv IGNsZWFyIHRoZSBwYWRkaW5nIGJpdHMgb24KICAgIGNvbnN0cnVjdGlvbi4KICAgIAogICAgbGli c3RkYysrLXYzL0NoYW5nZUxvZzoKICAgIAogICAgICAgICAgICAqIGluY2x1ZGUvYml0cy9hdG9t aWNfYmFzZS5oIChfX2F0b21pY19mbG9hdDo6X19hdG9taWNfZmxvYXQoRnApKToKICAgICAgICAg ICAgQ2xlYXIgcGFkZGluZy4KICAgICAgICAgICAgKiB0ZXN0c3VpdGUvMjlfYXRvbWljcy9hdG9t aWNfZmxvYXQvY29tcGFyZV9leGNoYW5nZV9wYWRkaW5nLmNjOgogICAgICAgICAgICBOZXcgdGVz dC4KICAgIAogICAgU2lnbmVkLW9mZi1ieTogeG5kY24gPHhuZGNobkBnbWFpbC5jb20+CiAgICAK ICAgIFJldmlld2VkLWJ5OiBKb25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KCmRp ZmYgLS1naXQgYS9saWJzdGRjKystdjMvaW5jbHVkZS9iaXRzL2F0b21pY19iYXNlLmggYi9saWJz dGRjKystdjMvaW5jbHVkZS9iaXRzL2F0b21pY19iYXNlLmgKaW5kZXggYjg1N2I0NDExNjkuLmRk MzYwMzAyZjgwIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvaW5jbHVkZS9iaXRzL2F0b21pY19i YXNlLmgKKysrIGIvbGlic3RkYysrLXYzL2luY2x1ZGUvYml0cy9hdG9taWNfYmFzZS5oCkBAIC0x MjgzLDcgKzEyODMsNyBAQCBfR0xJQkNYWF9CRUdJTl9OQU1FU1BBQ0VfVkVSU0lPTgogCiAgICAg ICBjb25zdGV4cHIKICAgICAgIF9fYXRvbWljX2Zsb2F0KF9GcCBfX3QpIDogX01fZnAoX190KQot ICAgICAgeyB9CisgICAgICB7IF9fYXRvbWljX2ltcGw6Ol9fY2xlYXJfcGFkZGluZyhfTV9mcCk7 IH0KIAogICAgICAgX19hdG9taWNfZmxvYXQoY29uc3QgX19hdG9taWNfZmxvYXQmKSA9IGRlbGV0 ZTsKICAgICAgIF9fYXRvbWljX2Zsb2F0JiBvcGVyYXRvcj0oY29uc3QgX19hdG9taWNfZmxvYXQm KSA9IGRlbGV0ZTsKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjlfYXRvbWlj cy9hdG9taWNfZmxvYXQvY29tcGFyZV9leGNoYW5nZV9wYWRkaW5nLmNjIGIvbGlic3RkYysrLXYz L3Rlc3RzdWl0ZS8yOV9hdG9taWNzL2F0b21pY19mbG9hdC9jb21wYXJlX2V4Y2hhbmdlX3BhZGRp bmcuY2MKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjQ5NjI2YWM2NjUx Ci0tLSAvZGV2L251bGwKKysrIGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yOV9hdG9taWNzL2F0 b21pY19mbG9hdC9jb21wYXJlX2V4Y2hhbmdlX3BhZGRpbmcuY2MKQEAgLTAsMCArMSw1MyBAQAor Ly8geyBkZy1kbyBydW4geyB0YXJnZXQgYysrMjAgfSB9CisvLyB7IGRnLW9wdGlvbnMgIi1PMCIg fQorLy8geyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIlthdG9taWNfbGlua19mbGFncyBbZ2V0X211 bHRpbGlic11dIC1sYXRvbWljIiB9CisKKyNpbmNsdWRlIDxhdG9taWM+CisjaW5jbHVkZSA8Y3N0 cmluZz4KKyNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8dGVzdHN1aXRlX2hvb2tzLmg+CisK K3RlbXBsYXRlPHR5cGVuYW1lIFQ+Cit2b2lkIF9fYXR0cmlidXRlX18oKG5vaW5saW5lLG5vaXBh KSkKK2ZpbGxfcGFkZGluZyhUJiBmKQoreworICBUIG1hc2s7CisgIHN0ZDo6bWVtc2V0KCZtYXNr LCAweGZmLCBzaXplb2YoVCkpOworICBfX2J1aWx0aW5fY2xlYXJfcGFkZGluZygmbWFzayk7Cisg IHVuc2lnbmVkIGNoYXIqIHB0cl9mID0gKHVuc2lnbmVkIGNoYXIqKSZmOworICB1bnNpZ25lZCBj aGFyKiBwdHJfbWFzayA9ICh1bnNpZ25lZCBjaGFyKikmbWFzazsKKyAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IHNpemVvZihUKTsgaSsrKQorICB7CisgICAgaWYgKHB0cl9tYXNrW2ldID09IDB4 MDApCisgICAgeworICAgICAgcHRyX2ZbaV0gPSAweGZmOworICAgIH0KKyAgfQorfQorCit2b2lk Cit0ZXN0MDEoKQoreworICAvLyB0ZXN0IGZvciBsb25nIGRvdWJsZSB3aXRoIHBhZGRpbmcgKGZs b2F0ODApCisgIGlmIGNvbnN0ZXhwciAoc3RkOjpudW1lcmljX2xpbWl0czxsb25nIGRvdWJsZT46 OmRpZ2l0cyA9PSA2NCkKKyAgeworICAgIGxvbmcgZG91YmxlIGYgPSAwLjVmOyAvLyBsb25nIGRv dWJsZSBoYXMgcGFkZGluZyBiaXRzIG9uIHg4NgorICAgIGZpbGxfcGFkZGluZyhmKTsKKyAgICBz dGQ6OmF0b21pYzxsb25nIGRvdWJsZT4gYXN7IGYgfTsgLy8gcGFkZGluZyBjbGVhcmVkIG9uIGNv bnN0cnVjdG9yCisgICAgbG9uZyBkb3VibGUgdCA9IDEuNTsKKworICAgIGFzLmZldGNoX2FkZCh0 KTsKKyAgICBsb25nIGRvdWJsZSBzID0gZiArIHQ7CisgICAgdCA9IGFzLmxvYWQoKTsKKyAgICBW RVJJRlkocyA9PSB0KTsgLy8gcGFkZGluZyBpZ25vcmVkIG9uIGNvbXBhcmlzb24KKyAgICBmaWxs X3BhZGRpbmcocyk7CisgICAgVkVSSUZZKGFzLmNvbXBhcmVfZXhjaGFuZ2Vfd2VhayhzLCBmKSk7 IC8vIHBhZGRpbmcgY2xlYXJlZCBvbiBjbXBleGNoZworICAgIGZpbGxfcGFkZGluZyhmKTsKKyAg ICBWRVJJRlkoYXMuY29tcGFyZV9leGNoYW5nZV9zdHJvbmcoZiwgdCkpOyAvLyBwYWRkaW5nIGNs ZWFyZWQgb24gY21wZXhjaGcKKyAgfQorfQorCitpbnQgbWFpbigpCit7CisgIHRlc3QwMSgpOwor fQo= --00000000000032edf10613a057a3--