From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EB04A3858422 for ; Thu, 22 Sep 2022 23:32:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB04A3858422 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663889555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QLxIXuL8J5MHHbXhkHhYmKlTeQhQGHkqTjKraw3+AlQ=; b=R1+raNSu80PCNCHn+ml8dIFFhCBWptlA8rohX5xmjKrEGVsNOWzRZZ1DVDud1Ch71yL9nB c3gfAgq0sdK2F8K+MxxS59VPTGe4WJgBaqdqKIvlWFeL99C1AVcLRMSvMBiKNcnx1UFsVJ f434mTo46oUVKRjbruMpRaWQ87vi+zA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-20-iDYM9grRP7eW7p7GoYQD7g-1; Thu, 22 Sep 2022 19:32:34 -0400 X-MC-Unique: iDYM9grRP7eW7p7GoYQD7g-1 Received: by mail-qk1-f197.google.com with SMTP id d18-20020a05620a241200b006ce80a4d74aso7687961qkn.6 for ; Thu, 22 Sep 2022 16:32:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=QLxIXuL8J5MHHbXhkHhYmKlTeQhQGHkqTjKraw3+AlQ=; b=gBbmftnFaB42+SA1BWxuorg9zjns/krIIjrcWeJwKZZJ97hehBZ7KtLP3ZMpo9tnz4 Ize0SYAdO0FYVZajGzMMobUb8Ec40lR2MHGdDFzJ7Ebuv678v9kIat0Rp258S9rzJDzc RyJ8kErWvDDhSFiukEkOSmynJgA3oVxzVVPYIYaU6XYv1YBCQcw/U3SREU0NRV4I1Uu5 5vCKdrArxNLP3hOBHZa3LMtNuFR52vHcGbICeWdBFbY4YAlNZfNExnGi2EpuuUAE/Zsg 8zveaAMk0BnVHE0a33RWTBVjchigzTTcvt2KDofUYYsltOug3Ki1yDsS8XucP+eIJZfe hFYQ== X-Gm-Message-State: ACrzQf02azaMFC2JdTe+ejfmzwQsk+55g6SBvevy6I3rDlKIgy+J3n8g 2BdkumFmogPonX/nu8eNmu6iXs1FuArlAo2VjA9CzAZU08o6volLedTL7i46XJnVm6cd221AoDl vlpNdsOSy+u8gFdnVUOvNARFjlOV5HTc= X-Received: by 2002:a37:3c5:0:b0:6ce:3f31:e019 with SMTP id 188-20020a3703c5000000b006ce3f31e019mr4079036qkd.498.1663889554076; Thu, 22 Sep 2022 16:32:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/I/Hszjw+WwYILzIjc1TXwaFbOxXd5B1e9S139UHehuPZSHNMaR/WAiTGjh0VCunTtdn6aXytvOFSwDXjxxc= X-Received: by 2002:a37:3c5:0:b0:6ce:3f31:e019 with SMTP id 188-20020a3703c5000000b006ce3f31e019mr4079026qkd.498.1663889553886; Thu, 22 Sep 2022 16:32:33 -0700 (PDT) MIME-Version: 1.0 References: <20220922142353.1139862-1-jwakely@redhat.com> <20220922142353.1139862-2-jwakely@redhat.com> In-Reply-To: <20220922142353.1139862-2-jwakely@redhat.com> From: Jonathan Wakely Date: Fri, 23 Sep 2022 00:32:23 +0100 Message-ID: Subject: Re: [committed 2/2] libstdc++: Implement constexpr std::bitset for C++23 (P2417R2) To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 22 Sept 2022 at 15:26, Jonathan Wakely via Libstdc++ wrote: > > Tested x86_64-linux. Pushed to trunk. > > -- >8 -- > > Also add _GLIBCXX_HOSTED checks to simplify making > freestanding in the near future. > > libstdc++-v3/ChangeLog: > > * include/std/bitset (bitset): Add constexpr for C++23. Guard > members using std::string with _GLIBCXX_HOSTED. > * include/std/version (__cpp_lib_constexpr_bitset): Define. > * testsuite/20_util/bitset/access/constexpr.cc: New test. > * testsuite/20_util/bitset/cons/constexpr_c++23.cc: New test. > * testsuite/20_util/bitset/count/constexpr.cc: New test. > * testsuite/20_util/bitset/ext/constexpr.cc: New test. > * testsuite/20_util/bitset/operations/constexpr_c++23.cc: New test. > * testsuite/20_util/bitset/version.cc: New test. The new tests fail with -D_GLIBCXX_DEBUG because I didn't update . I'll do that tomorrow.