From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH 3/3] libstdc++: Implement ranges::zip_view from P2321R2
Date: Wed, 24 Aug 2022 13:15:43 +0100 [thread overview]
Message-ID: <CACb0b4=9wq=+7QfXLvzFVoRzgaPMXQDB35fH=h2TSEUdUe_MZQ@mail.gmail.com> (raw)
In-Reply-To: <20220823013500.1756466-3-ppalka@redhat.com>
On Tue, 23 Aug 2022 at 02:38, Patrick Palka via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Tested on 86_64-pc-linux-gnu, does this look OK for trunk?
As discussed privately, please remove the #include <cstdint> (which is
not needed, and adds declarations to the global namespace that we
don't need).
OK with that change, thanks.
N.B. re the TODOs, we already have a constexpr abs in <numeric> but
it's probably not worth including that just for one function, that
you've already managed without.
next prev parent reply other threads:[~2022-08-24 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 1:34 [PATCH 1/3] libstdc++: Separate construct/convertibility tests for std::tuple Patrick Palka
2022-08-23 1:34 ` [PATCH 2/3] libstdc++: Implement std::pair/tuple/misc enhancements from P2321R2 Patrick Palka
2022-08-23 12:03 ` Jonathan Wakely
2022-08-23 15:14 ` Patrick Palka
2022-08-23 1:35 ` [PATCH 3/3] libstdc++: Implement ranges::zip_view " Patrick Palka
2022-08-24 12:15 ` Jonathan Wakely [this message]
2022-08-26 20:05 ` Jonathan Wakely
2022-08-31 10:12 ` Jonathan Wakely
2022-08-23 9:15 ` [PATCH 1/3] libstdc++: Separate construct/convertibility tests for std::tuple Jonathan Wakely
2022-08-23 13:44 ` Patrick Palka
2022-08-23 14:53 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=9wq=+7QfXLvzFVoRzgaPMXQDB35fH=h2TSEUdUe_MZQ@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).