From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AC868382EA02 for ; Wed, 24 Aug 2022 12:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC868382EA02 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661343356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YxP6dMbqCJ9ncpzaF3UKlxUF/3vE6efdZ9BRFO8tTVA=; b=CBWNcOshI3H3HVn9ltPBoMPjWrG3XHcxjklaSKwe/M6LMs2rL44mJodGEuvKuGCCIZFlT6 HyCae/SXG+eNlA1P8535TQoNSl9wFOD6DBB8cZnmhlyvrz0smrpBy1QcCx/jgK7tJAYgQM 2RoSF6LHyqD427vEDZ8DkVAR3SJS72I= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-183-CxtCrfCzPz29r68cpQtBRA-1; Wed, 24 Aug 2022 08:15:55 -0400 X-MC-Unique: CxtCrfCzPz29r68cpQtBRA-1 Received: by mail-qk1-f197.google.com with SMTP id bj2-20020a05620a190200b006bba055ab6eso14531595qkb.12 for ; Wed, 24 Aug 2022 05:15:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YxP6dMbqCJ9ncpzaF3UKlxUF/3vE6efdZ9BRFO8tTVA=; b=q97Ap5gWvQoapAwK9S7ATRoEZ9H/5ggdUuaxarQE3Hp8uTzD+3d7LvPajNonsD9aFA la786ZrpvU+SZSjcuTQ6uKNMPcI4BT26R+20ZiSRLEagHhPZDqtX5+LyL/029KMJtQ6+ h/0MCYiK4iJJW0ZKdV8hglQUcCZOoT/wAQS7gLb4joGTtkb1tUAy3bjJMfbBzq3yTuGd oi2QzwKfsdTNsmhEYnPUvgMm7NQBmDwbmwCvqsz7QLDx4DMlKypLEVviGACDhDBZVVE2 zCn60RHPVGzwB44IOEXMb5nncF/dnFTqJJ7RSyUUAQ7DNCYBQXIHswtp0L2v0VRAh0Ck 8RDw== X-Gm-Message-State: ACgBeo1ObFc9F7QPC+W8Tq3iDZjgfXBVgfJpElQptoMYjEKR+Pqpw5J0 hEwNOcS65e+mJcnxF7zoD9T5QdihHfjHBNAxkYh7cZ2ByDXwby0J6sysfj3V8+JYBK3jPvyjfee pXW6EjX1Yuz1E3r1DkgxbRFhuva7miRE= X-Received: by 2002:ad4:5be2:0:b0:476:7e0d:815f with SMTP id k2-20020ad45be2000000b004767e0d815fmr23273878qvc.57.1661343354823; Wed, 24 Aug 2022 05:15:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR5RjbKiarvs+rn+acgVqA3868/YcI6AFPAN8vfq/in/mGbrwDKG3TaLM3o3Iw5VcqQdGfjOs5Db76RKGZCvxVY= X-Received: by 2002:ad4:5be2:0:b0:476:7e0d:815f with SMTP id k2-20020ad45be2000000b004767e0d815fmr23273853qvc.57.1661343354594; Wed, 24 Aug 2022 05:15:54 -0700 (PDT) MIME-Version: 1.0 References: <20220823013500.1756466-1-ppalka@redhat.com> <20220823013500.1756466-3-ppalka@redhat.com> In-Reply-To: <20220823013500.1756466-3-ppalka@redhat.com> From: Jonathan Wakely Date: Wed, 24 Aug 2022 13:15:43 +0100 Message-ID: Subject: Re: [PATCH 3/3] libstdc++: Implement ranges::zip_view from P2321R2 To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 23 Aug 2022 at 02:38, Patrick Palka via Libstdc++ wrote: > > Tested on 86_64-pc-linux-gnu, does this look OK for trunk? As discussed privately, please remove the #include (which is not needed, and adds declarations to the global namespace that we don't need). OK with that change, thanks. N.B. re the TODOs, we already have a constexpr abs in but it's probably not worth including that just for one function, that you've already managed without.