public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
	"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: eh_globals: gthreads: reset _S_init before deleting key
Date: Tue, 21 Jun 2022 08:40:56 +0100	[thread overview]
Message-ID: <CACb0b4=B0gSQcacVkabvGRi9Abeb2FjVKMLNq=Z3R2g3CRjDGw@mail.gmail.com> (raw)
In-Reply-To: <orh74ed03m.fsf@lxoliva.fsfla.org>

On Tue, 21 Jun 2022 at 07:04, Alexandre Oliva via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
>
> Clear __eh_globals_init's _S_init in the dtor before deleting the
> gthread key.
>
> This ensures that, in case any code involved in deleting the key
> interacts with eh_globals, the key that is being deleted won't be
> used, and the non-thread-specific eh_globals fallback will.
>
> Regstrapped on x86_64-linux-gnu, also tested with a cross to
> aarch64-rtems6.  Ok to install?

OK, thanks.

> PS: This is a fix for a theoretical issue, that came to mind while I
> independently investigated the problem that I later found to be
> PR105880.

It looks like a real problem though, if rare in practice.


      reply	other threads:[~2022-06-21  7:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  6:03 Alexandre Oliva
2022-06-21  7:40 ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4=B0gSQcacVkabvGRi9Abeb2FjVKMLNq=Z3R2g3CRjDGw@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=oliva@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).