From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0077A3858D32 for ; Tue, 19 Sep 2023 08:04:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0077A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695110652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j/P/EqAcKL6SpJLCghR+YC9Ta+An+Ar2H/WRMJa+4zs=; b=eF1ba/pyl86OvFgUN0U6iHvstv+/QiOShNy119R2PEmnh7ctVKSeK3AXftO/mJaF+WU0Xz 6MQy2E25ptnNE3lu7cCcTubOJXr8UzvdRc1cmewLUY3ZZOrTdoIYSaOW1+eVtwEw7HlccP x0z7sMRMfP90M6Xiv0d8Vu1v2euZEjw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-9qbuSDbVMBGqRVKRP8KMFw-1; Tue, 19 Sep 2023 04:04:11 -0400 X-MC-Unique: 9qbuSDbVMBGqRVKRP8KMFw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bbc1d8011dso66414561fa.1 for ; Tue, 19 Sep 2023 01:04:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695110650; x=1695715450; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/P/EqAcKL6SpJLCghR+YC9Ta+An+Ar2H/WRMJa+4zs=; b=Arji5kZ2ypRUV8o4mBM7XcYsumOqbyp8d44mX4WV6gE1WsEYriyuklTV+E56IKKnq1 dVL7Ex95KOMl+ASsWsvBcBlGpw/jkVSodX0Bt6lIqNUszh5rfTkYqjJ/+w8eMft1Raln Pl56fRJJIZ+uIWm4vPxF6yX35gaBXdhpqzJ9HR/6+Xc7UI03o8K6crLUm3aOnCHBxT4m aqr7OLrjTjV2mLG0fiX+S1xijJOYOhYhZe9/bp7G73GwLtKLc55YcyqCS46KgATmUxUs HfnnJWrEBtuYD5GyQacO7agdeUOqsnZhuNHEVgugRa8Blnr17RTXMlrOnn6rCDPd3fYV +5Ug== X-Gm-Message-State: AOJu0Yy1iKMVFCKJ1VotLMLEXBuUp+aBuqwH0hxaLxJVEuaY4X6w7tvd KMi5ywZ6EmNnRQ+eOz81CdKls7ZyZ7tTL8+0eSm4hYcZgq0lVoidJyuFJKXgZinQKUu2poDa91h 6F9cta+DSq2Y6df4G1vyAmwGmg4Qxoz37DTRJuIU1+g== X-Received: by 2002:a2e:9c51:0:b0:2bd:1dc0:5ed5 with SMTP id t17-20020a2e9c51000000b002bd1dc05ed5mr9448756ljj.23.1695110649715; Tue, 19 Sep 2023 01:04:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEH8ZRUgvIPUOubQ9D2Bl5kPgW3QSnNMdeZWHMk1bxcAdJ9dd7XbV6EXiJ1ZyF7pO6nzdlFX2DEGIt8OdzjXgg= X-Received: by 2002:a2e:9c51:0:b0:2bd:1dc0:5ed5 with SMTP id t17-20020a2e9c51000000b002bd1dc05ed5mr9448740ljj.23.1695110649402; Tue, 19 Sep 2023 01:04:09 -0700 (PDT) MIME-Version: 1.0 References: <9e60d796-b675-1190-a795-349bd308933a@gmail.com> In-Reply-To: <9e60d796-b675-1190-a795-349bd308933a@gmail.com> From: Jonathan Wakely Date: Tue, 19 Sep 2023 09:03:58 +0100 Message-ID: Subject: Re: std::experimental and versioned namespace To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 19 Sept 2023 at 06:10, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > I'm running 'make check-c++' in gnu-versioned_namespace mode and among > all the failures are those: > > compiler exited with status 1 > FAIL: g++.dg/contracts/contracts-access1.C (test for excess errors) > Excess errors: > contracts-access1.C:(.text._ZN4Base1bEv.pre[_ZN4Base1bEv]+0x64): > undefined reference to > `handle_contract_violation(std::experimental::contract_violation const&)' The header uses the versioned namespace macros for the contract_violation type: namespace std _GLIBCXX_VISIBILITY(default) { _GLIBCXX_BEGIN_NAMESPACE_VERSION namespace experimental { But the compiler expects it to be in the std::experimental namespace. > I still need to find out what's going wrong but I also wonder if we need > to use the versioned namespace for things in std::experimental namespace > ? Those are already abi unstable, no ? Yes, we can just remove the VERSION macros from the header.