From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Rewrite std::variant comparisons without macros
Date: Wed, 15 May 2024 10:21:01 +0100 [thread overview]
Message-ID: <CACb0b4=E4fDARf_NHaCt-4W3o9yp1hb9y9EHWiLROyrYFLjPpw@mail.gmail.com> (raw)
In-Reply-To: <CAFk2RUbfFWvZ9Str=RiJT2_fquP-XmZjSxmzv1Jpo4knw6iArg@mail.gmail.com>
On Tue, 7 May 2024 at 14:51, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
>
> On Tue, 7 May 2024 at 16:47, Jonathan Wakely <jwakely@redhat.com> wrote:
> >
> > I don't think using a macro for these really saves us much, we can do
> > this to avoid duplication instead. And now it's not a big, multi-line
> > macro that's a pain to edit.
> >
> > Any objections?
>
> No, that's beautiful, ship it.
Pushed to trunk.
prev parent reply other threads:[~2024-05-15 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 13:46 Jonathan Wakely
2024-05-07 13:51 ` Ville Voutilainen
2024-05-15 9:21 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=E4fDARf_NHaCt-4W3o9yp1hb9y9EHWiLROyrYFLjPpw@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).