From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 06FA53858D20 for ; Wed, 15 May 2024 09:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06FA53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06FA53858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715764886; cv=none; b=C0hCy7kOuyUBEDxhdSL+VsRY2AppmGqNJ+Vz14cvFhvjFKBa1MRuD9KOAf+qYsONzK00NT1ri3zeVtpQOTsFa3aPx5EntFsxSw7H4ZqKX+UvVlfUrO1keCKpC/70izsyNXcE26Ttd9O+JccXXZ2vgql1bRQIRgOKxp/1LXNsj/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715764886; c=relaxed/simple; bh=nsPyjOdDmrsQaIQNxkLCddUbMjLAWPbQ5UOwhcEscRQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=IHv1urg+pWTUisuZMFc3/R7ums3814BB2ItCZzXCvsxJIzTAA1jBVMxfpNoY2f+rubcOBTtV+pHtKrkYuH+/ocXHiW2b0qtcsR824paw0+WYbKqCJhVTurj4etHXCsQl6NWUYMKDiaX2Lf8/nUtGAnpE7mgqKGua47Xjo3/tk5s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715764884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nsPyjOdDmrsQaIQNxkLCddUbMjLAWPbQ5UOwhcEscRQ=; b=J79WAU7iQzgThwfW7p3s5y708KJx2eGSW16ho8A4f/5UHB359DXD9qQ+84wLSzpUsp8FOy KuscmGSFBUzNaVRuV8Jl1WH189tukbuMXw5bzaznFpJ7gYkh46uxU+N3lLB2LR6Lx+aXER YkSLDIkXt5hV6fgi38vBQxD4Xo1/RUQ= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-lPsArM7ZPeOs1kMh5pfcDQ-1; Wed, 15 May 2024 05:21:18 -0400 X-MC-Unique: lPsArM7ZPeOs1kMh5pfcDQ-1 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-de8b66d59f7so8983523276.0 for ; Wed, 15 May 2024 02:21:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715764878; x=1716369678; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nsPyjOdDmrsQaIQNxkLCddUbMjLAWPbQ5UOwhcEscRQ=; b=Y0MgbeDwnr3lPMiyPueGDRChUgF+eKU8AtFU4/Mv6ZHhKaLwSFmpfjj/9XpzECsSNm /6FNL87nnNCMSw/InFhVYH24W6tkcc1FOBlQNDLV7y5L93v/7idjiKt0Rtes5KGoDdPI vMLPAA808WIO1jvdJfSF50ummCl+WnOGf7LPoTlbjZUaqRGXoMuWpxBr0HLHdQcfqRoH +Lg8+otgDsayiOl/ZVbUaloYkuaPCUL1R8D8XEBPYGJlWFnSRxssJfAeI22Tu8U7PTJ6 aaVSgorxsn5rBL4vrsfvJ6qGAhVDMqhQwk7AJRtw8yDTDc4NORlS4cEqD7ert/PuiPPl EMvg== X-Gm-Message-State: AOJu0YyH2Q8AHQEK5YV60NzEHU2R1ydKEsgmSLpvRIH29XCjlEzr6bnx e6cBHyqtBvER5GKE3nyqMskqA2AcSCkgfv2pOhR7puByBpT0sZWW9wSHaZ5Wcauwl0f4gnQ4Ued tRUb0OsLB5X0KYAs0P0fa75Gtbi3/Gb6Fk1B+2b9TLwlGGbUvDr4yJyEQvuNuarNsKHPnDPU1U3 6Gk+pQtJemWNdaSG3VELmbZWYvx6k= X-Received: by 2002:a25:9307:0:b0:de5:4eee:2240 with SMTP id 3f1490d57ef6-debcfb7a168mr12972144276.13.1715764878065; Wed, 15 May 2024 02:21:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFc1wpOdIsD8TKn7bTPbik39nsyNGIcPCbeDvBrwt1BBgkiwP46QwaRlEUU0/7UnjNc/m8215uS1cg2UeARQc= X-Received: by 2002:a25:9307:0:b0:de5:4eee:2240 with SMTP id 3f1490d57ef6-debcfb7a168mr12972139276.13.1715764877815; Wed, 15 May 2024 02:21:17 -0700 (PDT) MIME-Version: 1.0 References: <20240507134705.3819956-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 15 May 2024 10:21:01 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Rewrite std::variant comparisons without macros To: Ville Voutilainen Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 7 May 2024 at 14:51, Ville Voutilainen wrote: > > On Tue, 7 May 2024 at 16:47, Jonathan Wakely wrote: > > > > I don't think using a macro for these really saves us much, we can do > > this to avoid duplication instead. And now it's not a big, multi-line > > macro that's a pain to edit. > > > > Any objections? > > No, that's beautiful, ship it. Pushed to trunk.