From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id E3A91385840B
 for <libstdc++@gcc.gnu.org>; Tue, 30 Nov 2021 10:41:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3A91385840B
Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com
 [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-118-L5cs3laJMLO6q05vHAkgaA-1; Tue, 30 Nov 2021 05:41:17 -0500
X-MC-Unique: L5cs3laJMLO6q05vHAkgaA-1
Received: by mail-yb1-f198.google.com with SMTP id
 s189-20020a252cc6000000b005c1f206d91eso28438954ybs.14
 for <libstdc++@gcc.gnu.org>; Tue, 30 Nov 2021 02:41:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=a1KLXTwzJX/hBxqOGUrbg6hpABiH/zEG9D8PgjauuoY=;
 b=7BwMmOoNDEm6PpeB4Zh+uJGNPSFEXaZ+U0INESJ5J7yqXgBBbc1JTEZmkQ55Tvs1RH
 TjEyGmFcL/buDoKZQm4ue9rX66Uue1KIN4fz3g4mBQ0qbCqnE72gW8yN69go6qGtjuf+
 i5yDC0V/IRchCgKHPG6IwSYxTfkzSgqsaz3HAPfEpovFY6oIcKS7XAPSYETAHY2DqlIw
 xe+rNDGQw6SIvneZoxnFV+2NYABkScTob8Hk6l0m8c4DV4IpyHpm6TTGx1ZRiC+uHfzz
 6q2NolbcK2aWek8PDWPDGi5l0LTADdHYZoDNedMUxky7zQou7wn6iPgS9eOxSGmp05z0
 49Yw==
X-Gm-Message-State: AOAM531SvNRlN4k9t5vMNXaYVNTnEOXwtwnCRCkgL2Em0dZR75kfdphz
 WXVZMR6Z2pDqr5k1gBvr1ZIw8F6HP4EYLOaERkgoxYkRiAErwO001in47ufoKCsZ0QSn3q/RhF6
 Uhq8aMQSTQY/rSUNijiP8s6NvxA8jQ1U=
X-Received: by 2002:a25:b68c:: with SMTP id s12mr41918638ybj.316.1638268876847; 
 Tue, 30 Nov 2021 02:41:16 -0800 (PST)
X-Google-Smtp-Source: ABdhPJy7QarZ95tjD1/PJJWIyWQZi16JrxHl9OmTAZDuvIjSIf/qIwIiDiiCH2CW/JJLUg3h1YU8Vb8nGrd7r9qPkQo=
X-Received: by 2002:a25:b68c:: with SMTP id s12mr41918620ybj.316.1638268876662; 
 Tue, 30 Nov 2021 02:41:16 -0800 (PST)
MIME-Version: 1.0
References: <20211130085652.GK2646553@tucnak>
In-Reply-To: <20211130085652.GK2646553@tucnak>
From: Jonathan Wakely <jwakely@redhat.com>
Date: Tue, 30 Nov 2021 10:41:05 +0000
Message-ID: <CACb0b4=LtBqTe+K=hpw5ntMLXxS0G2RCyjVrpCzYY1H4p2A8-g@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: Add [[nodiscard]] to std::byteswap
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>, "libstdc++" <libstdc++@gcc.gnu.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2021 10:41:20 -0000

On Tue, 30 Nov 2021 at 08:58, Jakub Jelinek via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Hi!
>
> This patch adds [[nodiscard]] to std::byteswap, because the function
> template doesn't do anything useful if the result isn't used.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

Yes, thanks.