From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B376C38346A3 for ; Wed, 22 Jun 2022 09:46:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B376C38346A3 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-14-JDgljUWOMUmNqHXDeCWQ-g-1; Wed, 22 Jun 2022 05:46:32 -0400 X-MC-Unique: JDgljUWOMUmNqHXDeCWQ-g-1 Received: by mail-ed1-f70.google.com with SMTP id h16-20020a05640250d000b00435bab1a7b4so367011edb.10 for ; Wed, 22 Jun 2022 02:46:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HXWdNO5CerXZzM6ar5i6YqHE/d4TbnXdbUQo21LCbTk=; b=oL62e04R3YE8mOxLgELHZF2OZ5yLhApRLnnTrxzI35M7oX9eQvfV70Fj+rPbCAX5bs RdAXDH4tVt6zB9ILYPBlxg2vDLoKUOcV5r511HhIeOxqTt9H+i8VWs7dz8vFXhSHigrt yGCPmSJlFjcLRYoCWzEFnwPPb5S8LfQ8VHmwLXvM543sNoK1VwKO6vsyaJIFzLqKeing sSKDABz6WveQpQxI7Mc2JHNMhoZvUYBaB/EIrh2Fkhl5/JXHMSRVVqOybqpAE+99rtb9 w33aJj1/2//eSWxCZHJv8WjI9fgyRtmumTjOBsd+rLRgfQPrlAykiVhBz9hvlqknD9Ix pAiA== X-Gm-Message-State: AJIora+R1gU7QRGOQ8rPXv1agkl3MtBmYalnHSCCguJY1BGeqFBpxtjB HPGNGtOeziKM4x08ekVPgv0TUXWBPMmSQY/U8bspiquA9va4MCvsVAn/QKd5pH5xynbUSQ48ED7 Z30QkWBigyK4sVz+WWkPomNRdQgWyLTU= X-Received: by 2002:a05:6402:354c:b0:431:51e2:eef9 with SMTP id f12-20020a056402354c00b0043151e2eef9mr3145813edd.344.1655891191140; Wed, 22 Jun 2022 02:46:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vPJVALjv4duO3ag7rGI+X0/nXHx3bjvlLSE524a4M7qG82CHilXNA1vu3KiFMu3ny8yvgUWj0D+x1EUPHr6so= X-Received: by 2002:a05:6402:354c:b0:431:51e2:eef9 with SMTP id f12-20020a056402354c00b0043151e2eef9mr3145783edd.344.1655891190845; Wed, 22 Jun 2022 02:46:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 22 Jun 2022 10:46:20 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: testsuite: skip fs space tests if not available To: Alexandre Oliva Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 09:46:34 -0000 On Wed, 22 Jun 2022 at 07:28, Alexandre Oliva via Libstdc++ wrote: > > > The do_space function is defined in ways that are useful, or that fail > immediately, depending on various macros. When it fails immediately, > the filesystem space.cc tests fail noisily, but the fail is entirely > expected. > > Define HAVE_SPACE in the space.cc tests, according to the macros that > select implementations of do_space, and use it to skip tests that are > expected to fail. > > Regstrapped on x86_64-linux-gnu, also tested with a cross to > aarch64-rtems6. Ok to install? OK. This could be done once in testsuite_fs.h as well.