From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C228D3856DC2 for ; Wed, 31 May 2023 20:06:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C228D3856DC2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685563595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9yXGK0A7LaRCnIoYr9qu7vbKIAwOQS2zRmP3GUEzqeg=; b=GLqIz6YkF5PJ61KaT/edkhjl6m38nuPJXMGvi94iLU0oQ1bIbVsJZeOgVIaw3Spl2UhFBQ oSLmLsqoiuVr9c6us5xe/8s25Oa+87gLv198wOjcbF7RBaNxOiqxmcqUWkIdnOtm6eLBGQ QimLIpYldsV2DDwBNJy/a4zDHbE4WQI= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-JBFmQnduNduCqwEn6wXZFQ-1; Wed, 31 May 2023 16:06:34 -0400 X-MC-Unique: JBFmQnduNduCqwEn6wXZFQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2af1589c75aso356271fa.2 for ; Wed, 31 May 2023 13:06:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685563592; x=1688155592; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9yXGK0A7LaRCnIoYr9qu7vbKIAwOQS2zRmP3GUEzqeg=; b=UXyPmcpVUnDeP9M19IcP1c/ucK7GUe7ilvskhvycAFKF4IVwaUzGsitwE+lwZ8StHn zZiIk+1FzoSgaotFLmBrIMGLBpA2avKB8suz1M6ePcrZrJs7dYMPylunDfK3Hw2Uxqbm mp6ZOf2W4OKO/DODwGJSSI1mfh3rEP59LM7xAWFRNgZR8Argr3VZlWecroZs2TnKlwa/ h3CrLFjg/JppPqt5HoKzSpxgln8VHPuE9rjHKpfRFGuwgg82K+g1OPv977yXCJJg2s2q P+hl15mEXBdKYma1Zme4fnql2ZArNiK3r6jj1ym8MAu3X4NEenpCP0o2QWX0qnz60Qer /0VA== X-Gm-Message-State: AC+VfDyPqBolLZim9bj+P6HEJcZ+6vr4L8Rr1l+E0EUvIxDQOv03dUVy jxm8BkAa9YEXP75pEF39B2QlRuPQkeE/QWL+Kyg1C2yqnuoB2ExIxYZwV+cMNL2QJGmQ26B4q5j QRdVOwgFwe4Ns7M2SkM/3kSqdBOjzAcA= X-Received: by 2002:a2e:8283:0:b0:2a8:ea1e:bde9 with SMTP id y3-20020a2e8283000000b002a8ea1ebde9mr3605198ljg.45.1685563592626; Wed, 31 May 2023 13:06:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kY1RJJ2fmbqB0BIHu0YNqqGr6W/jr6w4nklCcU9gbaGzDC3tay+hc0vFkMtXA5zRLPejEhD4yEcnO4Uhoqjg= X-Received: by 2002:a2e:8283:0:b0:2a8:ea1e:bde9 with SMTP id y3-20020a2e8283000000b002a8ea1ebde9mr3605067ljg.45.1685563587384; Wed, 31 May 2023 13:06:27 -0700 (PDT) MIME-Version: 1.0 References: <20230531152805.9D4732043D@pchp3.se.axis.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 31 May 2023 21:06:16 +0100 Message-ID: Subject: Re: Build-break in libstdc++-v3 at r14-1442-ge1240bda3e0bb1 for non-float128 targets To: Hans-Peter Nilsson Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000df6e1405fd02daa7" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000df6e1405fd02daa7 Content-Type: text/plain; charset="UTF-8" On Wed, 31 May 2023 at 16:32, Jonathan Wakely wrote: > > > On Wed, 31 May 2023 at 16:29, Hans-Peter Nilsson via Libstdc++ < > libstdc++@gcc.gnu.org> wrote: > >> Since I don't see a quick fix at r14-1444-g3f4853a5f00fab, I >> thought I'd better notify the author (I have written authors >> if there was more than one ;-) of suspect commits in the >> range r14-1425-g80ee7d02e8db48..e1240bda3e0b for the >> build-break at r14-1442-ge1240bda3e0bb1 for cris-elf, where >> I get: >> >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc:1330:47: error: >> '_Float128' is not supported on this target >> 1330 | from_chars(const char* first, const char* last, _Float128& value, >> | ^ >> > > Sorry, I'll fix or revert it today. > It should be fixed at r14-1451-ga239a35075ffd8 > > >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc:1330:49: error: >> expected identifier before '_Float128' >> 1330 | from_chars(const char* first, const char* last, _Float128& value, >> | ^~~~~~~~~ >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc:1330:49: error: >> '_Float128' is not supported on this target >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc:1330:49: error: >> expected ',' or '...' before '_Float128' >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc: In function >> 'std::from_chars_result std::from_chars(const char*, const char*, int)': >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc:1340:53: error: >> 'fmt' was not declared in this scope; did you mean 'fma'? >> 1340 | auto res = std::from_chars(first, last, ldbl_val, fmt); >> | ^~~ >> | fma >> /x/gcc/libstdc++-v3/src/c++17/floating_from_chars.cc:1342:5: error: >> 'value' was not declared in this scope >> 1342 | value = ldbl_val; >> | ^~~~~ >> make[5]: *** [Makefile:587: floating_from_chars.lo] Error 1 >> >> brgds, H-P >> >> --000000000000df6e1405fd02daa7--