From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F146838582B1 for ; Thu, 23 Jun 2022 12:38:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F146838582B1 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-63-nAr2f8hxPoW7hTnHT8wFYQ-1; Thu, 23 Jun 2022 08:38:08 -0400 X-MC-Unique: nAr2f8hxPoW7hTnHT8wFYQ-1 Received: by mail-ed1-f69.google.com with SMTP id z4-20020a05640240c400b004358a7d5a1dso8277314edb.2 for ; Thu, 23 Jun 2022 05:38:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wo44EtgoMfp9RQ+kkYnIJ1NVgc3oXWFAsTse2fCgZjw=; b=0P6D58mhJ/QHK3rAExuDkdBIaTFpc5h8PBWUO6ZF9pBWNcGYOeYoUfAQvPM734YZHD KwuxCW63dItjxy73S0OGJ1m8I3CK/7qNOKuzwi+/J2aBi1VPOmRzwJ5Yh56tnPiz4vg1 FNFD/04W/60MWcQf1QA1sd3zrk+6itINkeS2Bk5ULxpG/BvsgHJHElWBp6Aov+S3YyzE y/+6KYx0KMC1RjmByIEboc/A1+mdTaBc6NNGsKSyFPj2B90fJUAXlXVPKqzspdY0e3Ck eB84FO8zuNAvqVZDfCO98hp1uanme1bOK26OsF3fqz7V5vO4BhpDdl3aDKM+qNkxQHi1 9wuQ== X-Gm-Message-State: AJIora/rQT6TjiiuOcoye7+gM9rWciWaTqCkqVgpmMlrzQhwW+/1ggaS CelyxPusk7ipuwVKlvIpHOmLRwTXoImZcHQFg0GZsCEg3nnCtnvTZokH3YUZyAIsiRK85kptiGw t/giudDG12BRbPSATnxCbGntt7iL6k5I= X-Received: by 2002:a17:907:1ca8:b0:70c:68ce:dade with SMTP id nb40-20020a1709071ca800b0070c68cedademr8174529ejc.723.1655987887402; Thu, 23 Jun 2022 05:38:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sNXu/ZSQgRWAhWfKvsWF2g0NsnO22qVCUSJuJkU9QgEvHV1qPNXATu4q4hDozTvqfKzJdsnK0AQ+TChL/Hauk= X-Received: by 2002:a17:907:1ca8:b0:70c:68ce:dade with SMTP id nb40-20020a1709071ca800b0070c68cedademr8174516ejc.723.1655987887210; Thu, 23 Jun 2022 05:38:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Thu, 23 Jun 2022 13:37:56 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: testsuite: test symlnks ifdef _GLIBCXX_HAVE_SYMLINK To: Alexandre Oliva Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 12:38:11 -0000 On Thu, 23 Jun 2022 at 13:36, Alexandre Oliva wrote: > > On Jun 23, 2022, Jonathan Wakely wrote: > > > Could this new arg be given a default value, so every caller doesn't > > have to pass "" to it? > > > proc v3_check_preprocessor_condition { name cond {inc ""} } { > > Oh, nice, I didn't know about this convenient notation for default args > in tcl, and the one I knew about I found too cumbersome. Thanks for the > tip, I put it in the patch below. > > > #ifndef _GLIBCXX_HAVE_SYMLINK > > And this too. > > > And if the definition of NO_SYMLINKS gets more complicated in future > > (e.g. we add something like && !defined __foo__) then using > > NO_SYMLINKS in the dg proc will keep them in sync. > > 'zactly my thinking. > > > Here's what I'm testing (same way). Ok to install if it passes? Yes please, thanks for iterating to get this here.