From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A3C8D3858C60 for ; Fri, 27 Aug 2021 21:17:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3C8D3858C60 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-JkQ63LOqOeitltdCrv0vWA-1; Fri, 27 Aug 2021 17:17:35 -0400 X-MC-Unique: JkQ63LOqOeitltdCrv0vWA-1 Received: by mail-wm1-f69.google.com with SMTP id z186-20020a1c7ec30000b02902e6a27a9962so6407989wmc.3 for ; Fri, 27 Aug 2021 14:17:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mD3W8+gHcabWx8TLCSyFfFiWr6R6GWhwyGSMlgGB+qM=; b=skIpPu2yJOiYKhmRlNHTOwZm8LWOv5LUV0QUf8LwWUFoLIQ8zRSyDCcyOvain1P/3W AdmwSUkf+bdORSNaLtI7aMAxAl0ryLqrHnwjaqyf4gIWd1yGWEQOP64j8myLxBEJZZ1S PT5RDRnzQSNHuVOD2BFFVigSzNS3AHyeXhxa34yup/XPJiOT3t+47zLJs7vI/3dDXZ/G 1fWYxbwJcmcycFaFehzQFTr90i8QVZtnXAyTv2YSh+eiGUXbjVnfKq0I0OGPX6mokvcb xzao3Oz5JIhAVinCP0696GFtCbeTFB4uH+i7q5w9AfhWMPq9k26EbyLdrdvu7k78iCbz kW7Q== X-Gm-Message-State: AOAM532No80gB3VCyOJw8Kk/EBuoLPjyWVa0tXzmSIJA2e07SFNgUP1X 9kf7Eshb2ZmHBv10nMnKRYwZ5dFKUarFCXSocx5COTlVCOZzPKcwPPzHgoyISHg1xhaNUtkFn+l Cm4OI4hkbAus4vRlgjl95/FMU/56zFZE= X-Received: by 2002:a7b:c442:: with SMTP id l2mr21682115wmi.131.1630099054403; Fri, 27 Aug 2021 14:17:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuw8D4kiDuAS53kS9JXy9f17vcceqq8Yz7RiQQa0aiYynupLRjhzSSx+UPRyZ0HEo4JC/QpeG/KHJl3W1X4ww= X-Received: by 2002:a7b:c442:: with SMTP id l2mr21682107wmi.131.1630099054223; Fri, 27 Aug 2021 14:17:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Fri, 27 Aug 2021 22:17:23 +0100 Message-ID: Subject: Re: [PATCH] Fix inline versioned namespace bootstrap To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 21:17:38 -0000 On Fri, 27 Aug 2021 at 21:58, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > Since std::allocator is not specialized anymore in > _GLIBCXX_INLINE_VERSION mode _ExtPtr_allocator specialization do > not compile > > because std::allocator is incomplete. That doesn't look right ... it should be complete. This suggests there is a deeper problem, which I'll look into. > > So I think primary _ExtPtr_allocator template should also be prefered in > _GLIBCXX_INLINE_VERSION mode. I think it should always be preferred. The _ExtPtr_allocator specialization is useless, it is missing the converting constructor that would be needed to convert to/from that type to any other _ExtPtr_allocator specialization.