From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1DC663858C62 for ; Wed, 12 Jul 2023 10:03:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DC663858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689156214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dGHNsLAb767HQiYx3xsdTX3vWnEofvU90glIGjdU6UM=; b=PBFG6s4+/BSiS/98UPPyVGd/l7ZvQqi8fBmlKzQj71D31kQVMP0nrZ3IgMyrIw3jmZWGki huMIBuxe5T/qoUifdMHind1yqXRs5uIqIUtOSO77ABLzlsWMda/3otggxI8klg3eSVhILf aw4QLJ6rNbtVMuWq/KNYV8/KeRNbwGg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-ZIfvi_8HMkuAvFOAh9fStw-1; Wed, 12 Jul 2023 06:03:33 -0400 X-MC-Unique: ZIfvi_8HMkuAvFOAh9fStw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b70c44b5fdso56559901fa.1 for ; Wed, 12 Jul 2023 03:03:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689156212; x=1691748212; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dGHNsLAb767HQiYx3xsdTX3vWnEofvU90glIGjdU6UM=; b=RIOepxyjo6wncYu+eEfLk4J0XO73dGsPJlMrarYxcQOp5s1zIl4FvIZTSB+R2tjG6C nNE2xTTGzEttXOnd/Olbk9au/PZqisCA03FjzqlawBeQfhEj5pSbVEVgI/8L8e2rxbp7 ToJ+2Mr9CIN9UnaKtPKmPY3LEnoi26wCbilGIymkaL76cW9ZAS/zwKhRqIDp7Izf2f/q 43AqOWQ3gYL8MN3IoYr/emrf8dNF7v02j/di3Tq6ShLr8HrRBjI9XlWxKD02fUJMKDSI /AJ/qZ26MW8tkmUZbp2r5lTwJf8HiljvGwV3s0M92PYxYZcRwBXdIL4G53IXdTGQq0jX Q/MQ== X-Gm-Message-State: ABy/qLagEJlX4w4NX8zrwuJq0fCwV/hAPVXCsuNKzrT+cszKaS+MDnL/ nLaSM0Jo7/UXRVNl8+SJdD87w3gO7MuY45A+pfX5Crh0YstOyfafL/Dh+GVbbzlVkwWU/cdiLQh P4WO46Yok7Yk0+pX0fIrnuF7YCZPZkDE= X-Received: by 2002:a05:651c:120c:b0:2b4:7c31:ab8a with SMTP id i12-20020a05651c120c00b002b47c31ab8amr14854352lja.23.1689156212005; Wed, 12 Jul 2023 03:03:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlHNgqjRhFHYy9I+ZJ69DfFbk9ywf2FdAc8wQAri4IdIQOKT/8qobgjJ4Xg0mtF3P4Tu6AJqUlGfDZGJ3+Srgr0= X-Received: by 2002:a05:651c:120c:b0:2b4:7c31:ab8a with SMTP id i12-20020a05651c120c00b002b47c31ab8amr14854333lja.23.1689156211647; Wed, 12 Jul 2023 03:03:31 -0700 (PDT) MIME-Version: 1.0 References: <20230709084717.20744-1-kmatsui@gcc.gnu.org> <20230709084717.20744-2-kmatsui@gcc.gnu.org> In-Reply-To: <20230709084717.20744-2-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Wed, 12 Jul 2023 11:03:20 +0100 Message-ID: Subject: Re: [PATCH 2/2] libstdc++: use new built-in trait __is_signed To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 9 Jul 2023 at 09:50, Ken Matsui via Libstdc++ wrote: > > This patch lets libstdc++ use new built-in trait __is_signed. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_signed): Use __is_signed built-in trait. > (is_signed_v): Likewise. > > Signed-off-by: Ken Matsui OK for trunk after the front-end implementation of __is_signed is committed. > --- > libstdc++-v3/include/std/type_traits | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 0e7a9c9c7f3..23ab5a4b1e5 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -865,6 +865,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > : public __bool_constant<__is_abstract(_Tp)> > { }; > > + /// is_signed > +#if __has_builtin(__is_signed) > + template > + struct is_signed > + : public __bool_constant<__is_signed(_Tp)> > + { }; > +#else > /// @cond undocumented > template bool = is_arithmetic<_Tp>::value> > @@ -877,11 +884,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { }; > /// @endcond > > - /// is_signed > template > struct is_signed > : public __is_signed_helper<_Tp>::type > { }; > +#endif > > /// is_unsigned > template > @@ -3240,8 +3247,14 @@ template > template > inline constexpr bool is_final_v = __is_final(_Tp); > > +#if __has_builtin(__is_signed) > +template > + inline constexpr bool is_signed_v = __is_signed(_Tp); > +#else > template > inline constexpr bool is_signed_v = is_signed<_Tp>::value; > +#endif > + > template > inline constexpr bool is_unsigned_v = is_unsigned<_Tp>::value; > > -- > 2.41.0 >