From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7CF23384C916 for ; Tue, 6 Dec 2022 21:44:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7CF23384C916 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670363062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oqjHQP9kh7h5SWQ1nk/VmBedpledhwUB7W7MjmBLni4=; b=N+PyNYCMzHHrztOUBG8McrTdUltz3at1WrX6mU0FbfRm+RKj6IXkS4i1RkZi16xeLKgkM8 yGC4WsqyPI9rT9QrPDKtMrrZ8+JUA7TxEIgcZ78/UmIm0FX+Rw27qE1SFFyGmD45qAtiHF Kw/0UIY+yx+dc3oCNQb/HYyIhX65dhQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-533-WxpJ4O_hO4KYEEeAgC6KSw-1; Tue, 06 Dec 2022 16:44:20 -0500 X-MC-Unique: WxpJ4O_hO4KYEEeAgC6KSw-1 Received: by mail-ed1-f71.google.com with SMTP id s13-20020a056402520d00b0046c78433b54so5530459edd.16 for ; Tue, 06 Dec 2022 13:44:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oqjHQP9kh7h5SWQ1nk/VmBedpledhwUB7W7MjmBLni4=; b=wd2mV+2nE20eMF8zoh26B8GocXVfhUDH/QHVbF5qOJl04bbjTFHi0iBqK++53kDUKk oF/7MAHTwVxQjrhP853O8tPjDdYHRmvpfYgAdlNjMQj9WxMmHTneue1rQxwLo3+GPWGU oZ+GYGbbE4hYub8eXU9p5tLdRYqX3MQFBSuWVDCguU/U2ZOi5Bb6egKMmyptvx4WmbHz 8swtNgDp9ZgrFs4r8IiQ6OBCid98wZiJmfMMQBKsUXsTsP6PhbPhhgfIxl2SEOq6+fWz YKsDLGre3r0HAMejjsFO44GJ+EB+xDF4JMgQZB5yZhgy9ncm1IuEsaQFzGUULOVsia7A CNPg== X-Gm-Message-State: ANoB5pkajFWRB+QLGP7CqFjz6Md9uPB/SZk8xvLDoFljpPwpRHSdFQR1 CXdRR8vxM44gKW+RPvV/mDel0dYLPrg8DcwxqO+zvRBBdBf7Rdaf6LwmeKvJ0Ve+xKcc8KwonSR 5yemBIOb1FDGJ3of8t0iVw+g73ZzOHrk= X-Received: by 2002:a17:906:960f:b0:7c1:133a:37bd with SMTP id s15-20020a170906960f00b007c1133a37bdmr2600616ejx.470.1670363059520; Tue, 06 Dec 2022 13:44:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Mym0sH957Thm/kkRv0ddVUiLX+KiNkwYVjH2rqMcO3ALEwd+SK0ONcnKVSCnsEBTiy2Gw7lYWdgc4ccD4oSc= X-Received: by 2002:a17:906:960f:b0:7c1:133a:37bd with SMTP id s15-20020a170906960f00b007c1133a37bdmr2600606ejx.470.1670363059342; Tue, 06 Dec 2022 13:44:19 -0800 (PST) MIME-Version: 1.0 References: <20221129214107.25572-1-gcc@hazardy.de> <830aca53-fd19-2556-28b0-30ebff17df8c@gmail.com> In-Reply-To: <830aca53-fd19-2556-28b0-30ebff17df8c@gmail.com> From: Jonathan Wakely Date: Tue, 6 Dec 2022 21:44:08 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Add error handler for To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: =?UTF-8?B?QmrDtnJuIFNjaMOkcGVycw==?= , libstdc++@gcc.gnu.org, gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000cc856805ef2fb43a" X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000cc856805ef2fb43a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2022 at 18:00, Fran=C3=A7ois Dumont w= rote: > > On 30/11/22 14:07, Jonathan Wakely wrote: > > On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wrot= e: > >> > >> > >> On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely wro= te: > >>> > >>> > >>> On Wed, 30 Nov 2022 at 06:04, Fran=C3=A7ois Dumont via Libstdc++ wrote: > >>>> Good catch, then we also need this patch. > >>> > >>> Is it worth printing an error? If we can't show the backtrace because= of an error, we can just print nothing there. > > No strong opinion on that but if we do not print anything the output > will be: > > Backtrace: > > Error: ... > > I just considered that it did not cost much to report the issue to the > user that defined _GLIBCXX_DEBUG_BACKTRACE and so is expecting a backtrac= e. > > Maybe printing "Backtrace:\n" could be done in the normal callback > leaving the user with the feeling that _GLIBCXX_DEBUG_BACKTRACE does not > work. OK, how's this? Tested x86_64-linux. --000000000000cc856805ef2fb43a Content-Type: text/plain; charset="UTF-8"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbcr11ha0 Y29tbWl0IGFhZGY4MzI4M2YwZDNlMWQ0NzNhYzE3NTk1YmE3M2QwMjEwYmI5YmEKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBXZWQgTm92IDMwIDEy OjMyOjUzIDIwMjIKCiAgICBsaWJzdGRjKys6IFBhc3MgZXJyb3IgaGFuZGxlciB0byBsaWJiYWNr dHJhY2UgZnVuY3Rpb25zCiAgICAKICAgIEFsc28gcGFzcyB0aHJlYWRlZD0xIHRvIF9fZ2xpYmN4 eF9iYWNrdHJhY2VfY3JlYXRlX3N0YXRlIGFuZCByZW1vdmUgc29tZQogICAgb2YgdGhlIG5hbWVz cGFjZSBzY29wZSBkZWNsYXJhdGlvbnMgaW4gdGhlIGhlYWRlci4KICAgIAogICAgQ28tYXV0aG9y ZWQtYnk6IEZyYW7Dp29pcyBEdW1vbnQgPGZycy5kdW1vbnRAZ21haWwuY29tPgogICAgCiAgICBs aWJzdGRjKystdjMvQ2hhbmdlTG9nOgogICAgCiAgICAgICAgICAgICogaW5jbHVkZS9kZWJ1Zy9m b3JtYXR0ZXIuaCBbX0dMSUJDWFhfREVCVUdfQkFDS1RSQUNFXQogICAgICAgICAgICAoX0Vycm9y X2Zvcm1hdHRlcjo6X0Vycm9yX2Zvcm1hdHRlcik6IFBhc3MgZXJyb3IgaGFuZGxlciB0bwogICAg ICAgICAgICBfX2dsaWJjeHhfYmFja3RyYWNlX2NyZWF0ZV9zdGF0ZS4gUGFzcyAxIGZvciB0aHJl YWRlZCBhcmd1bWVudC4KICAgICAgICAgICAgKF9FcnJvcl9mb3JtYXR0ZXI6Ol9TX2Vycik6IERl ZmluZSBlbXB0eSBmdW5jdGlvbi4KICAgICAgICAgICAgKiBzcmMvYysrMTEvZGVidWcuY2MgKF9F cnJvcl9mb3JtYXR0ZXI6Ol9NX2Vycm9yKTogUGFzcyBlcnJvcgogICAgICAgICAgICBoYW5kbGVy IHRvIF9fZ2xpYmN4eF9iYWNrdHJhY2VfZnVsbC4KCmRpZmYgLS1naXQgYS9saWJzdGRjKystdjMv aW5jbHVkZS9kZWJ1Zy9mb3JtYXR0ZXIuaCBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL2RlYnVnL2Zv cm1hdHRlci5oCmluZGV4IGYxMjAxNjNjNmQ0Li5lOGE4M2EyMWJkZSAxMDA2NDQKLS0tIGEvbGli c3RkYysrLXYzL2luY2x1ZGUvZGVidWcvZm9ybWF0dGVyLmgKKysrIGIvbGlic3RkYysrLXYzL2lu Y2x1ZGUvZGVidWcvZm9ybWF0dGVyLmgKQEAgLTMyLDMyICszMiwxNyBAQAogI2luY2x1ZGUgPGJp dHMvYysrY29uZmlnLmg+CiAKICNpZiBfR0xJQkNYWF9IQVZFX1NUQUNLVFJBQ0UKLXN0cnVjdCBf X2dsaWJjeHhfYmFja3RyYWNlX3N0YXRlOwotCiBleHRlcm4gIkMiCiB7Ci0gIF9fZ2xpYmN4eF9i YWNrdHJhY2Vfc3RhdGUqCisgIHN0cnVjdCBfX2dsaWJjeHhfYmFja3RyYWNlX3N0YXRlKgogICBf X2dsaWJjeHhfYmFja3RyYWNlX2NyZWF0ZV9zdGF0ZShjb25zdCBjaGFyKiwgaW50LAogCQkJCSAg IHZvaWQoKikodm9pZCosIGNvbnN0IGNoYXIqLCBpbnQpLAogCQkJCSAgIHZvaWQqKTsKLQotICB0 eXBlZGVmIGludCAoKl9fZ2xpYmN4eF9iYWNrdHJhY2VfZnVsbF9jYWxsYmFjaykgKAotICAgIHZv aWQqLCBfX1VJTlRQVFJfVFlQRV9fLCBjb25zdCBjaGFyICosIGludCwgY29uc3QgY2hhciopOwot Ci0gIHR5cGVkZWYgdm9pZCAoKl9fZ2xpYmN4eF9iYWNrdHJhY2VfZXJyb3JfY2FsbGJhY2spICgK LSAgICB2b2lkKiwgY29uc3QgY2hhciosIGludCk7Ci0KLSAgdHlwZWRlZiBpbnQgKCpfX2dsaWJj eHhfYmFja3RyYWNlX2Z1bGxfZnVuYykgKAotICAgIF9fZ2xpYmN4eF9iYWNrdHJhY2Vfc3RhdGUq LCBpbnQsCi0gICAgX19nbGliY3h4X2JhY2t0cmFjZV9mdWxsX2NhbGxiYWNrLAotICAgIF9fZ2xp YmN4eF9iYWNrdHJhY2VfZXJyb3JfY2FsbGJhY2ssCi0gICAgdm9pZCopOwotCiAgIGludAogICBf X2dsaWJjeHhfYmFja3RyYWNlX2Z1bGwoCi0gICAgX19nbGliY3h4X2JhY2t0cmFjZV9zdGF0ZSos IGludCwKLSAgICBfX2dsaWJjeHhfYmFja3RyYWNlX2Z1bGxfY2FsbGJhY2ssCi0gICAgX19nbGli Y3h4X2JhY2t0cmFjZV9lcnJvcl9jYWxsYmFjaywKKyAgICBzdHJ1Y3QgX19nbGliY3h4X2JhY2t0 cmFjZV9zdGF0ZSosIGludCwKKyAgICBpbnQgKCopKHZvaWQqLCBfX1VJTlRQVFJfVFlQRV9fLCBj b25zdCBjaGFyICosIGludCwgY29uc3QgY2hhciopLAorICAgIHZvaWQgKCopKHZvaWQqLCBjb25z dCBjaGFyKiwgaW50KSwKICAgICB2b2lkKik7CiB9CiAjZW5kaWYKQEAgLTYwOSwxMCArNTk0LDEw IEBAIG5hbWVzcGFjZSBfX2dudV9kZWJ1ZwogICAgICwgX01fZnVuY3Rpb24oX19mdW5jdGlvbikK ICNpZiBfR0xJQkNYWF9IQVZFX1NUQUNLVFJBQ0UKICMgaWZkZWYgX0dMSUJDWFhfREVCVUdfQkFD S1RSQUNFCi0gICAgLCBfTV9iYWNrdHJhY2Vfc3RhdGUoX19nbGliY3h4X2JhY2t0cmFjZV9jcmVh dGVfc3RhdGUoMCwgMCwgMCwgMCkpCisgICAgLCBfTV9iYWNrdHJhY2Vfc3RhdGUoX19nbGliY3h4 X2JhY2t0cmFjZV9jcmVhdGVfc3RhdGUoMCwgMSwgX1NfZXJyLCAwKSkKICAgICAsIF9NX2JhY2t0 cmFjZV9mdWxsKCZfX2dsaWJjeHhfYmFja3RyYWNlX2Z1bGwpCiAjIGVsc2UKLSAgICAsIF9NX2Jh Y2t0cmFjZV9zdGF0ZSgpCisgICAgLCBfTV9iYWNrdHJhY2Vfc3RhdGUoMCkKICMgZW5kaWYKICNl bmRpZgogICAgIHsgfQpAQCAtNjMxLDggKzYxNiwxMiBAQCBuYW1lc3BhY2UgX19nbnVfZGVidWcK ICAgICBjb25zdCBjaGFyKgkJX01fdGV4dDsKICAgICBjb25zdCBjaGFyKgkJX01fZnVuY3Rpb247 CiAjaWYgX0dMSUJDWFhfSEFWRV9TVEFDS1RSQUNFCi0gICAgX19nbGliY3h4X2JhY2t0cmFjZV9z dGF0ZSoJCV9NX2JhY2t0cmFjZV9zdGF0ZTsKLSAgICBfX2dsaWJjeHhfYmFja3RyYWNlX2Z1bGxf ZnVuYwlfTV9iYWNrdHJhY2VfZnVsbDsKKyAgICBzdHJ1Y3QgX19nbGliY3h4X2JhY2t0cmFjZV9z dGF0ZSoJCV9NX2JhY2t0cmFjZV9zdGF0ZTsKKyAgICAvLyBUT0RPOiBSZW1vdmUgX01fYmFja3Ry YWNlX2Z1bGwgYWZ0ZXIgX19nbGliY3h4X2JhY2t0cmFjZV9mdWxsIGlzIG1vdmVkCisgICAgLy8g ZnJvbSBsaWJzdGRjKytfbGliYmFja3RyYWNlLmEgdG8gbGlic3RkYysrLnNvOgorICAgIF9fZGVj bHR5cGUoJl9fZ2xpYmN4eF9iYWNrdHJhY2VfZnVsbCkJX01fYmFja3RyYWNlX2Z1bGw7CisKKyAg ICBzdGF0aWMgdm9pZCBfU19lcnIodm9pZCosIGNvbnN0IGNoYXIqLCBpbnQpIHsgfQogI2VuZGlm CiAKICAgcHVibGljOgpkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL3NyYy9jKysxMS9kZWJ1Zy5j YyBiL2xpYnN0ZGMrKy12My9zcmMvYysrMTEvZGVidWcuY2MKaW5kZXggOWVkYTM4MDIzZjcuLjgz OTk2ZmZlNjIyIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMvc3JjL2MrKzExL2RlYnVnLmNjCisr KyBiL2xpYnN0ZGMrKy12My9zcmMvYysrMTEvZGVidWcuY2MKQEAgLTExNDEsNiArMTE0MSwyMyBA QCBuYW1lc3BhY2UKIAogICAgIHJldHVybiByZXQ7CiAgIH0KKworICB2b2lkCisgIHByaW50X2Jh Y2t0cmFjZV9lcnJvcih2b2lkKiBkYXRhLCBjb25zdCBjaGFyKiBtc2csIGludCBlcnJudW0pCisg IHsKKyAgICBQcmludENvbnRleHQmIGN0eCA9ICpzdGF0aWNfY2FzdDxQcmludENvbnRleHQqPihk YXRhKTsKKworICAgIHByaW50X2xpdGVyYWwoY3R4LCAiQmFja3RyYWNlIHVuYXZhaWxhYmxlOiAi KTsKKyAgICBwcmludF93b3JkKGN0eCwgbXNnID8gbXNnIDogIjx1bmtub3duIGVycm9yPiIpOwor ICAgIGlmIChlcnJudW0gPiAwKQorICAgICAgeworCWNoYXIgYnVmWzY0XTsKKwlpbnQgd3JpdHRl biA9IF9fYnVpbHRpbl9zcHJpbnRmKGJ1ZiwgIiAoZXJybm89JWQpXG4iLCBlcnJudW0pOworCXBy aW50X3dvcmQoY3R4LCBidWYsIHdyaXR0ZW4pOworICAgICAgfQorICAgIGVsc2UKKyAgICAgIHBy aW50X2xpdGVyYWwoY3R4LCAiXG4iKTsKKyAgfQogI2VuZGlmCiB9CiAKQEAgLTExOTMsNyArMTIx MCw3IEBAIG5hbWVzcGFjZSBfX2dudV9kZWJ1ZwogICAgICAgewogCXByaW50X2xpdGVyYWwoY3R4 LCAiQmFja3RyYWNlOlxuIik7CiAJX01fYmFja3RyYWNlX2Z1bGwoCi0JICBfTV9iYWNrdHJhY2Vf c3RhdGUsIDEsIHByaW50X2JhY2t0cmFjZSwgbnVsbHB0ciwgJmN0eCk7CisJICBfTV9iYWNrdHJh Y2Vfc3RhdGUsIDEsIHByaW50X2JhY2t0cmFjZSwgcHJpbnRfYmFja3RyYWNlX2Vycm9yLCAmY3R4 KTsKIAljdHguX01fZmlyc3RfbGluZSA9IHRydWU7CiAJcHJpbnRfbGl0ZXJhbChjdHgsICJcbiIp OwogICAgICAgfQo= --000000000000cc856805ef2fb43a--