From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 2A1D83858C60
 for <libstdc++@gcc.gnu.org>; Thu, 25 Nov 2021 21:24:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A1D83858C60
Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com
 [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-588-kEGqNTeMPQqT2Xz5wqb9SA-1; Thu, 25 Nov 2021 16:24:12 -0500
X-MC-Unique: kEGqNTeMPQqT2Xz5wqb9SA-1
Received: by mail-yb1-f199.google.com with SMTP id
 y17-20020a2586d1000000b005f6596e8760so7719416ybm.17
 for <libstdc++@gcc.gnu.org>; Thu, 25 Nov 2021 13:24:12 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=2fN/TolAKEBuQFUSuvSrcUYfDK7A4LQW7CaAGK48PeQ=;
 b=RGpSLlfDmY4h2LP32kSk09thiVKTDXOiy/aIi6cQePx0wHSO0RFwKXiHqEoYMwggXb
 o1HlQkGE1H95uiF25kzJLpN7ndPWkYwlh+IMZGytlqeB5U1+0H7ybhTk228oGHJMXd8m
 PUqhZgk4RkmmMdcRzUU0vvmGXfl/sK2GtTi1GKAwJKWnSvfMdoQjY1FVnFGk0CvDqrcc
 PIw2z/2lne+VRUVUkxOOleIGKZF49ZRv89DlXU5mscG0c6ZMqHCochnNqC1zbsMY9HYl
 +N9CBzkjYPgWf/IrBD27nWL9dNfYSZAHF9Gb2WriQlCm+HYxOBvHcmoNODa0Ykn4ifbQ
 GlqA==
X-Gm-Message-State: AOAM5331qz2FObJ1BLt8S0a9prIYkZuK6gUvXq0uXH3V7cskN+NOhlTn
 zc9QV2Z0SzxW1fztGWjeK6G03HgSLm0q12PCjm4eL4xuNma34Pftrh0JFCMnmLkTI5ox0q+1Ug8
 VeEoznw4pM3QnLXbtKLYeQqpE/J9ECOc=
X-Received: by 2002:a25:1344:: with SMTP id 65mr10165728ybt.468.1637875452442; 
 Thu, 25 Nov 2021 13:24:12 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwr+b3VQOOLaLj481p2OXZm20E0gUkKmtksAiIVf3KjXmJnYsfntNLUs8qcMcHJdAcXnMWTcwygl7PKpugEDJA=
X-Received: by 2002:a25:1344:: with SMTP id 65mr10165710ybt.468.1637875452247; 
 Thu, 25 Nov 2021 13:24:12 -0800 (PST)
MIME-Version: 1.0
References: <CAMmuTO9Z4rMGN0rhG=PHisSwPzonaggj68te1odk5O5TPEL4+A@mail.gmail.com>
 <CACb0b4mjDPxzJ8Ea=MC+4Wi17aPDJo=WjTaZr_X2o_zi4_E=3Q@mail.gmail.com>
 <CAH6eHdQLj2OzhbjTaCspzCjTnOJ8rPpsE4TEvcKYCyZ7oTcGKw@mail.gmail.com>
 <CAMmuTO_PHsMuLjumav8S3rJnhMSELx+F2OxDwZPapOM6_-P12Q@mail.gmail.com>
 <CACb0b4kzTxuAu9T_L=wRYqCj0K82zP4xu9MfnOi1MN6caHEd_Q@mail.gmail.com>
 <CAMmuTO9p6nABnSVw4-aEOXjLg=m__ekEiaAWe2deJOMh9gruFg@mail.gmail.com>
In-Reply-To: <CAMmuTO9p6nABnSVw4-aEOXjLg=m__ekEiaAWe2deJOMh9gruFg@mail.gmail.com>
From: Jonathan Wakely <jwakely@redhat.com>
Date: Thu, 25 Nov 2021 21:24:00 +0000
Message-ID: <CACb0b4=cP8rfsqDqR9iahCv8EqB34mH2yt4STaoCsY0wYk8nnQ@mail.gmail.com>
Subject: Re: libstdc++: Make atomic<T*>::wait() const [PR102994]
To: Thomas Rodgers <trodgers@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc Patches <gcc-patches@gcc.gnu.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Nov 2021 21:24:15 -0000

On Wed, 24 Nov 2021 at 01:27, Thomas Rodgers wrote:
>
> const qualification was also missing in the free functions for wait/wait_explicit/notify_one/notify_all. Revised patch attached.

Please tweak the whitespace in the new test:

> +test1(const std::atomic<char*> &a, char*p)

The '&' should be on the type not the variable, and there should be a
space before 'p':

> +test1(const std::atomic<char*>& a, char* p)

OK for trunk and gcc-11 with that tweak, thanks!