From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 329163858D35 for ; Mon, 6 Nov 2023 23:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 329163858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 329163858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699312446; cv=none; b=j/ApnZxTEr3Cljj3vGFo/7lg0QnvX5+SN1Q4YGTjFZyIO7RJuSE5/0q/6lbfWoTNz10n3k2VepfvBzU0cx0tYvPGQ9Mp4iXgxbfLyjx/hmOdnYYDodWyIPkXK8ccNzdr6iTwGEq6ybQkkq5NUN9821psqlrdiXQn0tGwgf+lEjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699312446; c=relaxed/simple; bh=qZ7aZ+jQkWq+g/z1SQYGwmFI/efnqwdgXqKHX3WQP8A=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=aHxHm45ieeNzp3yV6+D4AVBuPCbzu2PgMCwExTeaUfTsmdkvgAkkaxA2di4ZERTP1pe3TJQDEgtpotesMLjw5gdSOsgLorUg8/+IiUErrI2fWAf2lOraBvTzPul9NbLXLaFJ1wWvrg1hHWalPNES0HC+WLaiQ5Du1t/LN0psFj4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699312443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tzrpq8i2XS+KRYTFkOauU30D0dfoLOhFM+jHuA5/73c=; b=bStxznG+VxSF02KSKHw8RSxiyZFBmoQZCQogVdJPz63HES+ZvCmC6txnsre0W6zfGk/IdW csxpAyz/apgq4xuF0D0cpOM23hrd6p90AcC7J8OfZiAOVYVMpPcuB81WCiSJEdfHXjVSpD eWE2vwpfHj3FlABBfGhg6Gd3kQS06wU= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-P1oyk6jAMVmjEKEYqAShJA-1; Mon, 06 Nov 2023 18:14:01 -0500 X-MC-Unique: P1oyk6jAMVmjEKEYqAShJA-1 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-da2b8af7e89so6153953276.1 for ; Mon, 06 Nov 2023 15:14:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699312440; x=1699917240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzrpq8i2XS+KRYTFkOauU30D0dfoLOhFM+jHuA5/73c=; b=VZMSEtsm4eef+lQ26sGykQFdnIYrAHE0q4WUO07bZDYH5vFVquk3eeTPeuyOHw4yjv TvMZpY7grtHUSbGSHDcBUmzl0xdWOlNMPJXNUAbf3pfR3qetTHKNJQ6LH6Nv/xGDuEvN ow0BMjGQdXiuAJv+G1hL7uULRmShfU0gKpfqGblCbhIYoCLrEBm6Vs2CWkhgC8OGAMkl UAEL1QIoF7wADDfG5oQEobtOWwWZ+HA7l8wMhDHI/cgoQYCNevGqlnnbPPVTc/+M8inY Y8oMDHMMB3a3MNGwlh6Y4BZrOuEFk8OVagtpZbVwPKRB2lEwlYIfJKR8QugKo13SWUw9 ATag== X-Gm-Message-State: AOJu0Ywobri9sEJ6sJBv7mpQHgOuaDprPXyUG18OsH7pIUQEz2yUHnhm OGOUIiYN/ttIKcNcRK+qFFkP8G8vMYujYIQ6JuLZYIJ1KjY31Y63aIj9U6hGaj80AZ4TmIReTNe TK81ylankszHaucqOvoBjPH07dwInhEI= X-Received: by 2002:a25:838b:0:b0:da0:b396:a44d with SMTP id t11-20020a25838b000000b00da0b396a44dmr27092048ybk.54.1699312440621; Mon, 06 Nov 2023 15:14:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHw9c1FOEFeiP/zD6TWC7w8NkekQwuxW2GjqaxAfhlnp1BnB0JFWvhoSlUuMYc7xu3lUMcp3K7GN4lbWCVYCC8= X-Received: by 2002:a25:838b:0:b0:da0:b396:a44d with SMTP id t11-20020a25838b000000b00da0b396a44dmr27092035ybk.54.1699312440248; Mon, 06 Nov 2023 15:14:00 -0800 (PST) MIME-Version: 1.0 References: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> In-Reply-To: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> From: Jonathan Wakely Date: Mon, 6 Nov 2023 23:13:49 +0000 Message-ID: Subject: Re: [PATCH][_Hashtable] Add missing destructor call To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 6 Nov 2023 at 21:39, Fran=C3=A7ois Dumont wr= ote: > > Noticed looking for other occasion to replace __try/__catch with RAII > helper. > > libstdc++: [_Hashtable] Add missing node destructor call > > libstdc++-v3/ChangeLog: > > * include/bits/hashtable_policy.h > (_Hashtable_alloc<>::_M_allocate_node): Add missing call to > node destructor > on construct exception. > > Tested under Linux x64, ok to commit ? > > I hope gmail appli will appreciate .diff instead of .patch. No, it doesn't. > .txt are not > in .gitignore so annoying to use for patches. You don't have to create the file inside the Git repo, e.g. I dump patches to /tmp/patch.txt