From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B77FD3858C78 for ; Wed, 6 Sep 2023 23:10:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B77FD3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694041840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1cIRdwmOKWtx8FhQuQOVJOmgXQbW3MU54ioNUFQFMU=; b=GOnggzC0fBgGcJc+Lhef/n4/rxW4zY7FlmOGcttEsdvjAcYeSMQjny3PdmWJ05LOBUc6Cn 3pMhs5oz6Tc3TnHkl6sBf41bif+qUkNtis2zkIUtNTsDfhu4kLxGGcHosSAygT92XC3A/z dMT2fAYJNUIKUpZn88u5Rszb3tXTOJ0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-r_oOxRPhOdCqFgEQaLxG2Q-1; Wed, 06 Sep 2023 19:10:38 -0400 X-MC-Unique: r_oOxRPhOdCqFgEQaLxG2Q-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2be51691dd5so3739551fa.3 for ; Wed, 06 Sep 2023 16:10:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694041837; x=1694646637; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f1cIRdwmOKWtx8FhQuQOVJOmgXQbW3MU54ioNUFQFMU=; b=kPVdks06X2Q+F8ty8ORKCa/VQc4s+bRiz1JxhNNI1EqPz6BIUG8guawsu2NGDHkNZw VldwQ5/UaxmDszBEOhCfWMiYuvxdFOSThwl8nJHC1Xn2SFOWk+/DF8swJB1uHpY0DlIm x/YC7eyryTvSEilSXNjeZE5zUVF0w/xihxjgikwuDj+jsEXykDN0k1tCcaf2NtedxDWf RLwXHHcoh7NgVw5MbJ1izIY+lnN8lC1uM+7fOQ6XvQaUezf8Ivye+XHi0OfZqgnDVyo2 7yrUBO/AgcGrHTcmFssv2q+6TP5lw0qfRgwzOXyPi9wzQ6jiju9tQY8LnBgAuWT1El+T T9Jg== X-Gm-Message-State: AOJu0YwnWIQxDjWHyZJHNZabFvQeMgEZlnY8aOhFxjSfA/bYCKaOSt46 heeCt48PvXqLL22DNEjDdaj3WSCIdISaGA2m1k1Z5v3JqcwDjuDeUdB+gi920N+IeAZt1VoM/94 Z4UoTINCRHlaQ24KpeN49GQ9cOdH0qqw= X-Received: by 2002:a2e:b60f:0:b0:2bd:a85:899e with SMTP id r15-20020a2eb60f000000b002bd0a85899emr3390954ljn.3.1694041837444; Wed, 06 Sep 2023 16:10:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPV8VUpO+jG26x3eKpyhZgDyuC0jCEnKcs2wb1TkipQV3BWjwvUSYnYHPGN3m/KhdIrs7eSDaHog8nBRWZntk= X-Received: by 2002:a2e:b60f:0:b0:2bd:a85:899e with SMTP id r15-20020a2eb60f000000b002bd0a85899emr3390947ljn.3.1694041837149; Wed, 06 Sep 2023 16:10:37 -0700 (PDT) MIME-Version: 1.0 References: <20230823160322.237140-1-jwakely@redhat.com> <20230904164617.F1DFA20427@pchp3.se.axis.com> <20230906230915.9A9EF2042A@pchp3.se.axis.com> In-Reply-To: <20230906230915.9A9EF2042A@pchp3.se.axis.com> From: Jonathan Wakely Date: Thu, 7 Sep 2023 00:10:26 +0100 Message-ID: Subject: Re: [RFC] libstdc++: Make --enable-libstdcxx-backtrace=auto default to yes To: Hans-Peter Nilsson Cc: jwakely.gcc@gmail.com, libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Sept 2023 at 00:09, Hans-Peter Nilsson wrote: > > > From: Jonathan Wakely > > Date: Wed, 6 Sep 2023 23:30:08 +0100 > > > On Mon, 4 Sept 2023 at 17:49, Jonathan Wakely wrote: > > > > > > On Mon, 4 Sept 2023 at 17:47, Hans-Peter Nilsson via Libstdc++ > > > wrote: > > > > > > > > > Date: Fri, 1 Sep 2023 12:16:40 +0100 > > > > > Reply-To: Jonathan Wakely > > > > > > > > > > On Wed, 23 Aug 2023 at 17:03, Jonathan Wakely via Libstdc++ > > > > > wrote: > > > > > > > > > > > > Any objections to this? It's a C++23 feture, so should be enabled by > > > > > > default. > > > > > > > > > > I've pushed this to trunk, so let's see what breaks! > > > > > > > > > > > > > > > > > > > > > > -- >8 -- > > > > > > > > > > > > This causes libstdc++_libbacktrace.a to be built by default. This might > > > > > > fail on some targets, in which case we can make the 'auto' choice expand > > > > > > to either 'yes' or 'no' depending on the target. > > > > > > > > > > > > libstdc++-v3/ChangeLog: > > > > > > > > > > > > * acinclude.m4 (GLIBCXX_ENABLE_BACKTRACE): Default to yes. > > > > > > * configure: Regenerate. > > > > > > > > Incidentally, should check_effective_target_stacktrace in > > > > libstdc++.exp also be adjusted to match; removing the > > > > _GLIBCXX_HOSTED condition? > > > > > > No, it should still depend on is_hosted. The acinclude.m4 macro should > > > check that. > > > > Done in r14-3761-g6de5f5a4fe85bd > > Aha, that's what you meant. I thought you meant that just > check_effective_target_stacktrace should be gated on > $is_hosted. > > Yeah, it makes sense not to have backtrace enabled by > default for ! $is_hosted. On the other hand, bare-iron > targets like cris-elf apparently *are* hosted, according to > "#if __STDC_HOSTED__". I guess I'll have to dig into what > the definition of "hosted" is, because I don't agree by the > layman obvious definition. Maybe there's a bug to fix. I don't think there's a bug. $is_hosted is true for --enable-hosted-libstdcxx which is on by default. > There sure are many yaks to shave these days. > > brgds, H-P >