From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 7313B3857C52 for ; Wed, 20 Oct 2021 19:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7313B3857C52 Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-juikGdfEOeeCNreoFm1-1Q-1; Wed, 20 Oct 2021 15:22:50 -0400 X-MC-Unique: juikGdfEOeeCNreoFm1-1Q-1 Received: by mail-ua1-f70.google.com with SMTP id a7-20020ab04947000000b002cb2d0928c0so2233734uad.22 for ; Wed, 20 Oct 2021 12:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gZ8hO+R45N1D4Flu0UTEdvSrbqU65tAkNw6g3EUCN9Q=; b=Jw8THOjYd1ZU7jljmJU7rTINDf08okOMo9rd7+kFyMLG8N+8leyDob4G7wGjwiVF31 kuZWTUiVae2jmDkYNSKjFDr2SWUvCy7TyZRGTsiqA0Kp/OsNgxtuwkwTZURXDBtwmReo nMb534C6ekDtYNgURC/dLEDNXhVOUViEBbqtKbwAYrLr04bUzZqvkRNvVmOY42BXtgV9 1LCGKGsf0+W0bWcZNW+K3DTF6BvammKcGXPdqOGa16OcooVlOW96Ofeqf11KBgbXgp73 RqpYmXeTZ5zepxgy5npe2OeGb6bccW0wYKKF4VcIzKwmMt38mw9t1skSK5bclNfi3emn 3VCg== X-Gm-Message-State: AOAM530AOvmy+1lJBtek6bYir+ubejhJjAGQyHCapRy2LfeckYw+P5YJ 7Zf3k/HDwkKNHEMP3RMXd62ly90ZZTF/iuDc6J/ZODsLUAY8cJK5TnhixAMeimKOBrNuEJJB+pi VWQ4XrNX8SsKwyoa0d27zf0zSdcVeFFo= X-Received: by 2002:a67:e0c2:: with SMTP id m2mr1420070vsl.2.1634757770170; Wed, 20 Oct 2021 12:22:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMSx1V++ZQK61mg20hAmHdI29kbc+unxOL6xGlz2RydI/DsUI3nZ88K019AalRya4aa6hoKqOlCdzTxZZF820= X-Received: by 2002:a67:e0c2:: with SMTP id m2mr1420037vsl.2.1634757769926; Wed, 20 Oct 2021 12:22:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 20 Oct 2021 20:22:39 +0100 Message-ID: Subject: [committed] libstdc++: Add missing test for std::optional::transform(F&&) To: Tim Song Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="0000000000002bc69d05cecdb4c5" X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2021 19:22:54 -0000 --0000000000002bc69d05cecdb4c5 Content-Type: text/plain; charset="UTF-8" On Wed, 20 Oct 2021 at 09:42, Jonathan Wakely wrote: > > On Wed, 20 Oct 2021 at 06:48, Tim Song wrote: > > > > On Tue, Oct 19, 2021 at 9:05 AM Jonathan Wakely via Gcc-patches > > wrote: > > > > > > +constexpr bool > > > +test_copy_elision() > > > +{ > > > + return true; > > > +} > > > + > > > +static_assert( test_copy_elision() ); > > > + > > > > This isn't much of a test :) > > The ultimate copy elision. The copies even get removed from the source code. > > Thanks for spotting it. I meant to check we're constructing directly > into the union member without materializing the temporary early. I'll > add that today. Fixed by the attached patch. Tested x86_64-linux, pushed to trunk. Thanks again! --0000000000002bc69d05cecdb4c5 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kuzwjnx90 Y29tbWl0IDRiYTRiMDUzMTUxYTIwMjYyZDRiNjFlYjQ1MDFhYTFjNDgzMzdhYmIKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBXZWQgT2N0IDIwIDIw OjEyOjI4IDIwMjEKCiAgICBsaWJzdGRjKys6IEFkZCBtaXNzaW5nIHRlc3QgZm9yIHN0ZDo6b3B0 aW9uYWw6OnRyYW5zZm9ybShGJiYpCiAgICAKICAgIFRoZSB0ZXN0X2NvcHlfZWxpc2lvbigpIGZ1 bmN0aW9uIHdhcyBzdXBwb3NlZCB0byBlbnN1cmUgdGhhdCB0aGUgcmVzdWx0CiAgICBpcyBjb25z dHJ1Y3RlZCBkaXJlY3RseSBpbiB0aGUgc3RkOjpvcHRpb25hbCwgd2l0aG91dCBlYXJseSB0ZW1w b3JhcnkKICAgIG1hdGVyaWFsaXphdGlvbi4gQnV0IEkgZm9yZ290IHRvIHdyaXRlIHRoZSB0ZXN0 LgogICAgCiAgICBsaWJzdGRjKystdjMvQ2hhbmdlTG9nOgogICAgCiAgICAgICAgICAgICogdGVz dHN1aXRlLzIwX3V0aWwvb3B0aW9uYWwvbW9uYWRpYy90cmFuc2Zvcm0uY2M6IENoZWNrIHRoYXQK ICAgICAgICAgICAgYW4gcnZhbHVlIHJlc3VsdCBpcyBub3QgbWF0ZXJpYWxpemVkIHRvbyBzb29u LgoKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRpb25hbC9t b25hZGljL3RyYW5zZm9ybS5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRp b25hbC9tb25hZGljL3RyYW5zZm9ybS5jYwppbmRleCBkMDFjY2IyZTBmMi4uMTM5NzdiOGJhOGQg MTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRpb25hbC9tb25h ZGljL3RyYW5zZm9ybS5jYworKysgYi9saWJzdGRjKystdjMvdGVzdHN1aXRlLzIwX3V0aWwvb3B0 aW9uYWwvbW9uYWRpYy90cmFuc2Zvcm0uY2MKQEAgLTExMCw2ICsxMTAsMjMgQEAgc3RhdGljX2Fz c2VydCggdGVzdF9mb3J3YXJkaW5nKCkgKTsKIGNvbnN0ZXhwciBib29sCiB0ZXN0X2NvcHlfZWxp c2lvbigpCiB7CisgIHN0cnVjdCBpbW1vdmFibGUKKyAgeworICAgIGNvbnN0ZXhwciBpbW1vdmFi bGUoaW50IHApIDogcG93ZXJfbGV2ZWwocCkgeyB9CisgICAgaW1tb3ZhYmxlKGltbW92YWJsZSYm KSA9IGRlbGV0ZTsKKworICAgIGludCBwb3dlcl9sZXZlbDsKKyAgfTsKKworICBzdHJ1Y3QgRm9y Y2UKKyAgeworICAgIGNvbnN0ZXhwciBpbW1vdmFibGUgb3BlcmF0b3IoKShpbnQgaSkgY29uc3Qg eyByZXR1cm4ge2krMX07IH0KKyAgfTsKKworICBzdGQ6Om9wdGlvbmFsPGludD4gaXJyZXNpc3Rp YmxlKDkwMDApOworICBzdGQ6Om9wdGlvbmFsPGltbW92YWJsZT4gb2JqZWN0ID0gaXJyZXNpc3Rp YmxlLnRyYW5zZm9ybShGb3JjZXt9KTsKKyAgVkVSSUZZKCBvYmplY3QtPnBvd2VyX2xldmVsID4g OTAwMCApOworCiAgIHJldHVybiB0cnVlOwogfQogCg== --0000000000002bc69d05cecdb4c5--