From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A4D333834E5F for ; Wed, 22 Jun 2022 09:25:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4D333834E5F Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-636-zB57gNzuP1WReUfCvZay6Q-1; Wed, 22 Jun 2022 05:25:52 -0400 X-MC-Unique: zB57gNzuP1WReUfCvZay6Q-1 Received: by mail-ed1-f71.google.com with SMTP id g7-20020a056402424700b00435ac9c7a8bso1021038edb.14 for ; Wed, 22 Jun 2022 02:25:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M0sQFBfOBCjl9ZiZV3g9dBR7tT64ty2JI6NDjn1yLP8=; b=zj43zuyNh6x+oXf1zZ90YDNc2A+2rVahRtCg8eypOPfK9IyiM+ElHInL4KS1Yak9e7 +NUQxEzN+bLXvN7uzWDQr7KxLozzlCODSS715jCvDQfOMt+2SOxme0XVHiNdzDYtBMZg x8+lyWHif8dLz+SUQ6kYJr2bsxJXrtNpI44CWiyBcooSNJkoVEwuEoOirvGlKFMW/G+t MZLshzF6XbWy4P95cLb8dpVaZLIA3WaC7YfamwtAkN6ZBG9Kykh4sRRctSDhsA7VRBuM zpBjrLs2vLqogtNU9iu7ptqBOOvvX/WrUW9c8TwtQA9w31USYtH8J3VhOADECPT9YkdF Lqaw== X-Gm-Message-State: AJIora9/Aved+NCOkE36GpLP/IgU/TqSlotGmb1a+r60YfbIg33FL384 vvbdAZgz6hrSk5pZJyfsgshlemRmgrj4tusT1n0WQ0YBwyhfzvDh6OOgEc5s2pDroBQlr1wKwRk FlERCJAOwlcr3x5jcDSXtRjSC9gEc/wM= X-Received: by 2002:a17:907:1ca8:b0:70c:68ce:dade with SMTP id nb40-20020a1709071ca800b0070c68cedademr2227775ejc.723.1655889948216; Wed, 22 Jun 2022 02:25:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1srhvdWswgD4MeXBx792cya9lNaI4tnQtQPWiKli6bAkdAF6AQ93NgltfYZFbjqMn2HCr/vo2zFfKoRbcVhiHU= X-Received: by 2002:a17:907:1ca8:b0:70c:68ce:dade with SMTP id nb40-20020a1709071ca800b0070c68cedademr2227762ejc.723.1655889948046; Wed, 22 Jun 2022 02:25:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 22 Jun 2022 10:25:37 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: testsuite: test symlnks ifdef _GLIBCXX_HAVE_SYMLINK To: Alexandre Oliva Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 09:25:57 -0000 On Wed, 22 Jun 2022 at 07:14, Alexandre Oliva via Libstdc++ wrote: > > > Several filesystem tests expect to be able to create symlinks even > when !defined (_GLIBCXX_HAVE_SYMLINK), and fail predictably, reducing > the amount of testing of other filesystem features. > > They are already skipped for mingw targets. I've extended the > skipping to other targets in which _GLIBCXX_HAVE_SYMLINK is > undefined. > > Regstrapped on x86_64-linux-gnu, also tested with a cross to > aarch64-rtems6. Ok to install? OK. I'd like to clean this up so the tests don't rely on the "internal" HAVE_SYMLINK macro. We could add something like this to testsuite/util/testsuite_fs.h #if defined(__MINGW32__) || defined(__MINGW64__) \ || !defined (_GLIBCXX_HAVE_SYMLINK) # define NO_SYMLINKS #endif and then use that in the tests. That way the private macro is only checked in one place. We can do that later though. > > PS: Testing with trunk was somewhat impaired by various changes in the > filesystem implementation and tests that cause new failures on rtems6 The only significant changes are for PR104161 but the directory iterators did change fairly significantly. Which tests are failing? I might be able to point you to the cause much faster than you can debug it yourself.