From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8A6DD384011A for ; Tue, 13 Dec 2022 09:51:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A6DD384011A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670925093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cclKvFHzYZ3Nlr00gQncFAE0BEUEz/o0htw0MXOnbto=; b=RDPF7bl4NJK7wB5yJhCC4MKaweOth+aOgCid1fzUCFILZ/M1Y7tqn5kcXIXSFPsir9wK/5 RQSTLYoJ9fecDGYt9RCFAl+dF/rokH5qulQdksUPy2LrBg+bYAQqk8uroXXjdxCVXMIQRN cazu5xL6Fg4El3IgrQuGzHRo/wkfvKw= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-145-zdi7z-NAOaeEcHyOxZ-W4A-1; Tue, 13 Dec 2022 04:51:31 -0500 X-MC-Unique: zdi7z-NAOaeEcHyOxZ-W4A-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-1446f190493so3565309fac.9 for ; Tue, 13 Dec 2022 01:51:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cclKvFHzYZ3Nlr00gQncFAE0BEUEz/o0htw0MXOnbto=; b=ix9xdsuwofWQYZMRk5nDG+ZNCRMXnyDtDZ6OrPSJp2tDwogcFVbsu8tqx/e89Q26M7 lyPMSoEMlePQwWcZAlxnfRHUPuGobp6j6bfdnaEqLfRXVqahfE7v8Aks69y/YMyyERlD NNM1Sbfr87vbiSUqI76ygqzFiD000jJFzQUtowWW2RGe4b8vc5F5wCFhXNqrLchWSSMe ascntLwbz7usuaZ6JI8EIZDki+ykA++j9fT6gGcFvWip3PoOctfl6jfr1on3HHlgoKuK sx0JXMTdmKnrs6T+Husvqss3ewndgXJP6+F3moXfESNmgVIMv8NZsBUD571ZdHckKTKi gJfQ== X-Gm-Message-State: ANoB5pnCOiPAFSOxqBXPzFmtjUSL0ryA0+F1SYas1Axvpns8/1qOjCap mcR028B/1jLuSnLmXabJW2PIV7MHJ2i/+EbeOzURbALqBMcf3v3nYbgeFQY7pFKvxYY0AwnjPcM vnjlTHLwTfyy5s1ggwnJa9vpXsH3H1Eo= X-Received: by 2002:a05:6871:4096:b0:144:ee4d:b6a8 with SMTP id kz22-20020a056871409600b00144ee4db6a8mr171918oab.15.1670925091130; Tue, 13 Dec 2022 01:51:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/YAorcOa/XLMVjuWrGyRVntWVYc6sLMueFcqpm/9Bj2zofZVDmcUjsfQ55wx60D2h8NYBBJhkaCMrD1MWIoI= X-Received: by 2002:a05:6871:4096:b0:144:ee4d:b6a8 with SMTP id kz22-20020a056871409600b00144ee4db6a8mr171914oab.15.1670925090888; Tue, 13 Dec 2022 01:51:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 13 Dec 2022 09:51:20 +0000 Message-ID: Subject: Re: [PATCH] c++, libstdc++: Add typeinfo for _Float{16,32,64,128,32x,64x} and __bf16 types [PR108075] To: Jakub Jelinek Cc: Jason Merrill , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 13 Dec 2022 at 09:40, Jakub Jelinek wrote: > > Hi! > > The following patch adds typeinfos for the extended floating point > types and _Float{32,64}x. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? The libstdc++ parts look good, thanks. > 2022-12-13 Jakub Jelinek > > PR libstdc++/108075 > gcc/cp/ > * rtti.cc (emit_support_tinfos): Add pointers to > {bfloat16,float{16,32,64,128,32x,64x,128x}}_type_node to fundamentals > array. > gcc/testsuite/ > * g++.dg/cpp23/ext-floating13.C: New test. > libstdc++-v3/ > * config/abi/pre/gnu.ver (CXXABI_1.3.14): Export > _ZTIDF[0-9]*[_bx], _ZTIPDF[0-9]*[_bx] and _ZTIPKDF[0-9]*[_bx]. > * testsuite/util/testsuite_abi.cc (check_version): Handle > CXXABI_1.3.14. > > --- gcc/cp/rtti.cc.jj 2022-10-17 12:29:33.519016406 +0200 > +++ gcc/cp/rtti.cc 2022-12-12 15:23:48.244190755 +0100 > @@ -1603,7 +1603,9 @@ emit_support_tinfos (void) > &long_long_integer_type_node, &long_long_unsigned_type_node, > &float_type_node, &double_type_node, &long_double_type_node, > &dfloat32_type_node, &dfloat64_type_node, &dfloat128_type_node, > - &nullptr_type_node, > + &bfloat16_type_node, &float16_type_node, &float32_type_node, > + &float64_type_node, &float128_type_node, &float32x_type_node, > + &float64x_type_node, &float128x_type_node, &nullptr_type_node, > 0 > }; > int ix; > --- gcc/testsuite/g++.dg/cpp23/ext-floating13.C.jj 2022-12-12 15:38:51.357009408 +0100 > +++ gcc/testsuite/g++.dg/cpp23/ext-floating13.C 2022-12-12 15:39:04.568816597 +0100 > @@ -0,0 +1,35 @@ > +// P1467R9 - Extended floating-point types and standard names. > +// { dg-do link { target c++23 } } > +// { dg-options "" } > + > +#include > + > +#ifdef __STDCPP_FLOAT16_T__ > +const std::type_info &a = typeid(decltype(0.0f16)); > +#endif > +#ifdef __STDCPP_BFLOAT16_T__ > +const std::type_info &b = typeid(decltype(0.0bf16)); > +#endif > +#ifdef __STDCPP_FLOAT32_T__ > +const std::type_info &c = typeid(decltype(0.0f32)); > +#endif > +#ifdef __STDCPP_FLOAT64_T__ > +const std::type_info &d = typeid(decltype(0.0f64)); > +#endif > +#ifdef __STDCPP_FLOAT128_T__ > +const std::type_info &e = typeid(decltype(0.0f128)); > +#endif > +#ifdef __FLT32X_MAX__ > +const std::type_info &f = typeid(decltype(0.0f32x)); > +#endif > +#ifdef __FLT64X_MAX__ > +const std::type_info &g = typeid(decltype(0.0f64x)); > +#endif > +#ifdef __FLT128X_MAX__ > +const std::type_info &h = typeid(decltype(0.0f128x)); > +#endif > + > +int > +main () > +{ > +} > --- libstdc++-v3/config/abi/pre/gnu.ver.jj 2022-11-11 08:15:45.646183974 +0100 > +++ libstdc++-v3/config/abi/pre/gnu.ver 2022-12-12 15:34:08.178142084 +0100 > @@ -2794,6 +2794,16 @@ CXXABI_1.3.13 { > > } CXXABI_1.3.12; > > +CXXABI_1.3.14 { > + > + # typeinfo for _Float{16,32,64,128,32x,64x,128x} and > + # __bf16 > + _ZTIDF[0-9]*[_bx]; > + _ZTIPDF[0-9]*[_bx]; > + _ZTIPKDF[0-9]*[_bx]; > + > +} CXXABI_1.3.13; > + > # Symbols in the support library (libsupc++) supporting transactional memory. > CXXABI_TM_1 { > > --- libstdc++-v3/testsuite/util/testsuite_abi.cc.jj 2022-09-12 11:30:14.224870022 +0200 > +++ libstdc++-v3/testsuite/util/testsuite_abi.cc 2022-12-12 15:46:41.036156477 +0100 > @@ -230,6 +230,7 @@ check_version(symbol& test, bool added) > known_versions.push_back("CXXABI_1.3.11"); > known_versions.push_back("CXXABI_1.3.12"); > known_versions.push_back("CXXABI_1.3.13"); > + known_versions.push_back("CXXABI_1.3.14"); > known_versions.push_back("CXXABI_IEEE128_1.3.13"); > known_versions.push_back("CXXABI_TM_1"); > known_versions.push_back("CXXABI_FLOAT128"); > @@ -251,7 +252,7 @@ check_version(symbol& test, bool added) > bool latestp = (test.version_name == "GLIBCXX_3.4.31" > // XXX remove next line when baselines have been regenerated. > || test.version_name == "GLIBCXX_IEEE128_3.4.30" > - || test.version_name == "CXXABI_1.3.13" > + || test.version_name == "CXXABI_1.3.14" > || test.version_name == "CXXABI_FLOAT128" > || test.version_name == "CXXABI_TM_1"); > if (added && !latestp) > > Jakub >