From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 054773858D32 for ; Mon, 11 Sep 2023 11:51:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 054773858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694433094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O7eBdEkV5PtZYWEH2Krp0aZ6xE/YHHYN1ZvmPpGb45Q=; b=ZhFWBcQ0WEETOzQa++C7EP+c0IW3ZBRtLpo4EHIfojQfuud7ykkyhWO2PdLBiFPyw6YgDm ftWU8TpGPP7iWgSaEDgKvj4fcbXFnXemhpnAiGtELpzQlncK4us1k8b691fpYslDkeqvgy 4VU5HOp/TbiCNmXUxzX4QvuHUE83h6M= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-7GWPIghyPM2rStSINBkDOQ-1; Mon, 11 Sep 2023 07:51:31 -0400 X-MC-Unique: 7GWPIghyPM2rStSINBkDOQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b8405aace3so46688711fa.3 for ; Mon, 11 Sep 2023 04:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694433090; x=1695037890; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O7eBdEkV5PtZYWEH2Krp0aZ6xE/YHHYN1ZvmPpGb45Q=; b=l4y+e7xi8PjqwOt6GQe2Bt5FgIXz8U/Edt2B8KU0da0QAZnS9yOCwNdp5Fq3ZN5Z3K j3hRaX88YEt7+fyKgN5nFUW3t2E5zRMep8xo6xVeCobTyregK/yAnMtc6f1/6QXRmhRC APSUvC0fDWXxVq4UuTYVUFxilgX7jOEiQK7qLrgD8N/2RxMrXCxKsypYRU2bXao5zZ6g RwGrDg8gRnUwKll8Ogt+7HsbXkZ47n7uZmDLVGmn6TnNWRXBjajS/Qn1RYvtNcE67bpU 5vSxI3x7qQKmXPAMK9Hb/1BMkxIQLGWdvadifC2tITfCDVu17+o5XBy08C1JqZ0lPKUy nulQ== X-Gm-Message-State: AOJu0YzHty90ilYAGvlIx/xFgU+nW3/VZvfFXYSO+LaHIJ7oProZvX/K NGo/IrtlkRUffz1QH/o2ae/nf/BQ5nFfaROZH2eZzlIaKOh+4D9UYDnDxdecO66YDvV+oioy46N 1CM785zcZWddasPEvtvAO0ozwb7rBoOk= X-Received: by 2002:a2e:730f:0:b0:2b6:bc30:7254 with SMTP id o15-20020a2e730f000000b002b6bc307254mr7503658ljc.13.1694433090021; Mon, 11 Sep 2023 04:51:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEI/sO4VKqJ1FbMwgoA4FVgwJ34DbHGFynuskxCpkkDlP0qHeP09WYcBoN6ECwi2+50Jq/4fBFGRPrm0vTxLik= X-Received: by 2002:a2e:730f:0:b0:2b6:bc30:7254 with SMTP id o15-20020a2e730f000000b002b6bc307254mr7503638ljc.13.1694433089723; Mon, 11 Sep 2023 04:51:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 11 Sep 2023 12:51:18 +0100 Message-ID: Subject: Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" , gcc-patches , rs2740@gmail.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 10 Sept 2023 at 14:57, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > Following confirmation of the fix by TC here is the patch where I'm > simply adding a 'constexpr' on _M_next(). > > Please let me know this ChangeLog entry is correct. I would prefer this > patch to be assigned to 'TC' with me as co-author but I don't know how > to do such a thing. Unless I need to change my user git identity to do so= ? Sam already explained that, but please check with Tim how he wants to be credited, if at all. He doesn't have a copyright assignment, and hasn't added a DCO sign-off to the patch, but it's small enough to not need it as this is the first contribution credited to him. > > libstdc++: Add constexpr qualification to _Hash_node::_M_next() What has this constexpr addition got to do with the ABI change and the always_inline attributes? It certainly doesn't seem like it should be the summary line of the git commit message. > > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3D1b6f0476837205932613d= db2b3429a55c26c409d > changed _Hash_node_value_base to no longer derive from > _Hash_node_base, which means > that its member functions expect _M_storage to be at a different > offset. So explosions > result if an out-of-line definition is emitted for any of the > member functions (say, > in a non-optimized build) and the resulting object file is then > linked with code built > using older version of GCC/libstdc++. > > libstdc++-v3/ChangeLog: > > * include/bits/hashtable_policy.h > (_Hash_node_value_base<>::_M_valptr(), > _Hash_node_value_base<>::_M_v()) > Add [[__gnu__::__always_inline__]]. > (_Hash_node<>::_M_next()): Add constexpr. > > Co-authored-by: TC > > Ok to commit and backport to GCC 11, 12, 13 branches ? > > Fran=C3=A7ois >