From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 95468384B0C4 for ; Fri, 24 Jun 2022 11:18:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 95468384B0C4 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-460-CkDPfKtTOJulM36J4VDWyw-1; Fri, 24 Jun 2022 07:18:27 -0400 X-MC-Unique: CkDPfKtTOJulM36J4VDWyw-1 Received: by mail-ed1-f72.google.com with SMTP id x21-20020a05640226d500b00435bd7f9367so1664464edd.8 for ; Fri, 24 Jun 2022 04:18:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vKgfTR59RgYwBhHMAfmIiVedkXNVh41je3At4ADwbl8=; b=7ntWEIJDG6JuGXhmiKDHih51WI4qFDvk960wVkYjLPDdYbCrwKeDWjuXlXExQiD51S 4PeBrD3xfEW//jiuJIrXCwhPnn7biY8hu8eNbmus7j/IboU4/HW/l7Iul7oKEIHIGZ48 OKSVZhzgnbe7v2n6MGl0o3QoOjLaq+dxc1BAGjsUUmA+RqqGthUV4YN5x/5Pv95WdyUr RnIUIDf9gpddQDOz/t1mTSiXImMVu5jDxE5kCI+0WvNv8lshBH0q8QEfbambASlBWjA4 0szmscN8eHYhRG/tR9yHD2zmpQqJ3IURWIwvfnq/b3QPyWmMKdFcVCM/YGqHl4mpWKMi IxuA== X-Gm-Message-State: AJIora8tOwItDdiGc5CaqkgPUFXgpLROqFqOVEw8dgWO071qalokXs0R DboYrKHHXwRVTcebU1nrDP/LqQTrDRcjAA4EPXCVCCA8QuDRqt2GuKW/fyEo8WCsSDBGJYKgPcV 4Xst7JQJUlUrzKX1h3lmFhevVeO6mKAI= X-Received: by 2002:a05:6402:354b:b0:437:60fd:4891 with SMTP id f11-20020a056402354b00b0043760fd4891mr1979449edd.344.1656069505949; Fri, 24 Jun 2022 04:18:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tEUM7UdmCf2l9KejLh/6WLMQHxwFSQ9ZfFJUqhT2ERgxUgaQiS8jjMwsXFarTXxJknCgdiD5PbfiPFL0f6Mc4= X-Received: by 2002:a05:6402:354b:b0:437:60fd:4891 with SMTP id f11-20020a056402354b00b0043760fd4891mr1979438edd.344.1656069505827; Fri, 24 Jun 2022 04:18:25 -0700 (PDT) MIME-Version: 1.0 References: <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site> In-Reply-To: From: Jonathan Wakely Date: Fri, 24 Jun 2022 12:18:14 +0100 Message-ID: Subject: Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts To: Xi Ruoyao Cc: Jonathan Wakely , "libstdc++" , gcc-patches , Rainer Orth X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 11:18:29 -0000 On Fri, 24 Jun 2022 at 12:08, Xi Ruoyao via Libstdc++ wrote: > > On Fri, 2022-06-24 at 11:00 +0100, Jonathan Wakely wrote: > > On Fri, 24 Jun 2022 at 08:03, Xi Ruoyao via Libstdc++ > > wrote: > > > > > > egrep has been deprecated in favor of grep -E for a long time, and > > > the > > > next grep release (3.8 or 4.0) will print a warning of egrep is > > > used. > > > Stop using egrep so we won't see the warning. > > > > > > libstdc++-v3/ChangeLog: > > > > > > * scripts/extract_symvers.in: Use grep -E instead of egrep. > > > * libstdc++-v3/scripts/run_doxygen: Likewise. > > > > This should be just scripts/run_doxygen here. You can use the git > > gcc-verify alias to check your changelog format. > > > > > > With that fixed it's OK for trunk and gcc-12 and gcc-11 branches, > > thanks! > > I'll need some rework as Rainer told me "grep -E" may not work on some > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in > is exactly for Solaris... I checked that, and it's not :-) The egrep uses in extract_symvers.in are for everything *except* SunOS. For Solaris we use the scripts/extract_symvers.pl script instead. Your change might break generation of Doxygen API docs on Solaris, but maybe we can live with that.