From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BFFDF38560BF for ; Thu, 23 Jun 2022 11:39:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFFDF38560BF Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-tcAj7hsFNQCgxUInbmwbcw-1; Thu, 23 Jun 2022 07:39:03 -0400 X-MC-Unique: tcAj7hsFNQCgxUInbmwbcw-1 Received: by mail-ej1-f72.google.com with SMTP id go10-20020a1709070d8a00b00722e8ee15b4so3013611ejc.22 for ; Thu, 23 Jun 2022 04:39:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F68o+zHiJav+IIIjUf/El9l0G7isyJGUng9unBvMfPE=; b=h98RJznn+7iTX9y1KYZKHOa4wgIG8VAykI1wPatkPZkFVBeiy2ljSmg5c6sbE4XWTW 2pNb5YveLvtaRmZb/PzEZNQbxKNhz2ObSiy7V3qhQcaszwe/yQca5n3s/QoPPXWRYq3h bFAnW/Top6iybaALDQ7PnSNNO4D+7LTphvQS4ShMc/N37cmPtKI0lVg9HwKQ3tDKCteL 1c4nSFrQPSulbPqyAJUBu9GMB2iXZLrKIiTb+AIqrkhLlXaT6KzWJJNytWAiKyZ+Reym YT/z8PW8cUUwV0PNeVu1E/ul7lJWfhMbJoPPCh/5liQlRiGMyRKpN6glAyQD3BQH9C1Z QQgQ== X-Gm-Message-State: AJIora+GhZwRufbFw3JRX9DdGE3uFk/+/ZrPfHCWBJYNg/gUgws5LmT+ qPZYF8ijMv70WrFJ7il8MhpKMuyHwNKl4Ct83tDcc5qKjjo3wmw7g0EMFTuZczy7+sKuGRkhGSA CEYxBTFrqipPTmtJATRuRtprN1SZRT6U= X-Received: by 2002:a17:906:779c:b0:722:e65f:cdfd with SMTP id s28-20020a170906779c00b00722e65fcdfdmr8104179ejm.109.1655984342390; Thu, 23 Jun 2022 04:39:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tt1HeAc1N5xPVUOQ28eWWMQD23enE3IGSynSphEKTBwoWOZChpkyrHCqZFpmgPvUOTEWNiCbMW64dNBoMfx1A= X-Received: by 2002:a17:906:779c:b0:722:e65f:cdfd with SMTP id s28-20020a170906779c00b00722e65fcdfdmr8104157ejm.109.1655984342140; Thu, 23 Jun 2022 04:39:02 -0700 (PDT) MIME-Version: 1.0 References: <4fe20709-e617-7644-175c-bd49b52dc6c2@embedded-brains.de> In-Reply-To: From: Jonathan Wakely Date: Thu, 23 Jun 2022 12:38:51 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: testsuite: fs rename to self may fail To: Alexandre Oliva Cc: Sebastian Huber , "libstdc++" , gcc Patches , RTEMS X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 11:39:06 -0000 On Thu, 23 Jun 2022 at 12:21, Alexandre Oliva wrote: > > On Jun 23, 2022, Jonathan Wakely wrote: > > > On Thu, 23 Jun 2022 at 07:26, Alexandre Oliva wrote: > >> Would a patch to add: > >> > >> // { dg-xfail-if "::rename is not POSIX-compliant" { target *-*-rtems* } } > >> > >> to rename.cc tests be acceptable? > > > Yes, I think that's definitely the way to go. > > The "target" above shouldn't have been there, and the :: appears to get > tcl/expect/dejagnu confused. Here's the patch. > > Regstrapped on x86_64-linux-gnu, also tested with a cross to > aarch64-rtems6. Ok to install? OK, thanks. > > > libstdc++: xfail rename tests on rtems > > ::rename on RTEMS does not meet several POSIX requirements, despite > compliance with C and C++ standards. ::std::filesystem::rename, in > turn, has requirements borrowed from POSIX, so it would have to be a > lot more than a simple wrapper around ::rename on RTEMS, and even then > fall short. > > Until RTEMS reimplements ::rename for POSIX compliance, expect > filesystem rename tests to fail on it. > > > for libstdc++-v3/ChangeLog > > * testsuite/27_io/filesystem/operations/rename.cc: xfail on > rtems. > * testsuite/experimental/filesystem/operations/rename.cc: > Likewise. > --- > .../27_io/filesystem/operations/rename.cc | 1 + > .../experimental/filesystem/operations/rename.cc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/libstdc++-v3/testsuite/27_io/filesystem/operations/rename.cc b/libstdc++-v3/testsuite/27_io/filesystem/operations/rename.cc > index b74e1133a7618..62543158e5241 100644 > --- a/libstdc++-v3/testsuite/27_io/filesystem/operations/rename.cc > +++ b/libstdc++-v3/testsuite/27_io/filesystem/operations/rename.cc > @@ -17,6 +17,7 @@ > > // { dg-do run { target c++17 } } > // { dg-require-filesystem-ts "" } > +// { dg-xfail-if "rename is not POSIX-compliant" { *-*-rtems* } } > > #include > #include > diff --git a/libstdc++-v3/testsuite/experimental/filesystem/operations/rename.cc b/libstdc++-v3/testsuite/experimental/filesystem/operations/rename.cc > index 37e743b770fdf..3c501757bff17 100644 > --- a/libstdc++-v3/testsuite/experimental/filesystem/operations/rename.cc > +++ b/libstdc++-v3/testsuite/experimental/filesystem/operations/rename.cc > @@ -18,6 +18,7 @@ > // { dg-options "-DUSE_FILESYSTEM_TS -lstdc++fs" } > // { dg-do run { target c++11 } } > // { dg-require-filesystem-ts "" } > +// { dg-xfail-if "rename is not POSIX-compliant" { *-*-rtems* } } > > #include > #include > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about >