From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4E9F4385DC11 for ; Thu, 17 Aug 2023 18:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E9F4385DC11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692298780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T9LqSLSCB7tCLaXuu0d4cwT9rDdGbNxWAxAXs0YpHao=; b=SSe6G1fwJBiU4H+10kR0Ce0GUKYowZvKlKs4p6QfauX/ANxkLTnKul+4gPSgD6dh0DfKEr 7LrxKDq9iqLkHWUUrKhQjZsWAKXn/ma96I3FQJa9Fe376/d4WGTUKAs/DKhYZNXfSd2UdG fwuetNOZGfh0hdPufqxVmQ0jQ7Mxb60= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-GibFsA4IOi6yG5t07z1sww-1; Thu, 17 Aug 2023 14:59:39 -0400 X-MC-Unique: GibFsA4IOi6yG5t07z1sww-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2bb8d47a022so934521fa.3 for ; Thu, 17 Aug 2023 11:59:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692298778; x=1692903578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T9LqSLSCB7tCLaXuu0d4cwT9rDdGbNxWAxAXs0YpHao=; b=cwk+OuYlUwt6q3tvAo52IpQVCmXBOUeJN43M1vK48E/H5KqRn46N3FjiBcSOVR9ozY 4kKnpQUpTJ81DXxc2fNKV6fpwN2CoMoMWOD8skgJvO8zbShATk3lUqNtO1/gnZwg3viZ ZU/ZvIhxYCUND9IevXSSLchRxyne85Oz2l+FCpGQsRcLuABDUHHaJ1I3QsvU2Zid6B/A 7AJfW4m1SXvfUjp7kuXf7IdnXrX61ji+W3IwbRQzd++KW02cqR6rWQ9Rbo2phfPvr8Xr BB77A14qTsnzBJf4DIyc3nbDNkXBYxvfhPAwhc54UwFrSV8oqzM3kKF9GDKVQDbuWgnk qJdA== X-Gm-Message-State: AOJu0YzFzQzWhYewwkX0ASLU/PBOt93xLjB1YZppq+5ykqCEN84KgtqK 0DO2fLyhv1JpatYPvqOwynoQMzuYYPKx4iHD92ybqxc6bbfdnrUMYuAOVsKHl4xAsHEvMhD+bmu AZ6+jlyhOhBoGcmE3jG+/gt2D/z3GgHw= X-Received: by 2002:a05:651c:1207:b0:2b9:e304:5f81 with SMTP id i7-20020a05651c120700b002b9e3045f81mr171882lja.23.1692298777966; Thu, 17 Aug 2023 11:59:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF48GX+5VBh++EEf+YxsrXMh0wAMe/ZCt/RjiYAnIx/iyUFKOvA3fouPWi8uCU3dL36hnDITaZOTonevnkPdII= X-Received: by 2002:a05:651c:1207:b0:2b9:e304:5f81 with SMTP id i7-20020a05651c120700b002b9e3045f81mr171872lja.23.1692298777603; Thu, 17 Aug 2023 11:59:37 -0700 (PDT) MIME-Version: 1.0 References: <1dc681f4-41b7-d171-02ac-b0194617bdee@gmail.com> <91dc6383-6bff-ce6c-b24d-81cd2ab2dce8@gmail.com> <698fb340-2457-585f-f375-709491faf43e@gmail.com> In-Reply-To: <698fb340-2457-585f-f375-709491faf43e@gmail.com> From: Jonathan Wakely Date: Thu, 17 Aug 2023 19:59:27 +0100 Message-ID: Subject: Re: [PATCH] sso-string@gnu-versioned-namespace [PR83077] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 17 Aug 2023 at 18:40, Fran=C3=A7ois Dumont w= rote: > > > On 17/08/2023 19:22, Jonathan Wakely wrote: > > On Sun, 13 Aug 2023 at 14:27, Fran=C3=A7ois Dumont via Libstdc++ > > wrote: > >> Here is the fixed patch tested in all 3 modes: > >> > >> - _GLIBCXX_USE_DUAL_ABI > >> > >> - !_GLIBCXX_USE_DUAL_ABI && !_GLIBCXX_USE_CXX11_ABI > >> > >> - !_GLIBCXX_USE_DUAL_ABI && _GLIBCXX_USE_CXX11_ABI > >> > >> I don't know what you have in mind for the change below but I wanted t= o > >> let you know that I tried to put COW std::basic_string into a nested > >> __cow namespace when _GLIBCXX_USE_CXX11_ABI. But it had more impact on > >> string-inst.cc so I preferred the macro substitution approach. > > I was thinking of implementing the necessary special members functions > > of __cow_string directly, so they are ABI compatible with the COW > > std::basic_string but don't actually reuse the code. That would mean > > we don't need to compile and instantiate the whole COW string just to > > use a few members from it. But that can be done later, the macro > > approach seems OK for now. > > You'll see that when cow_string.h is included while > _GLIBCXX_USE_CXX11_ABI =3D=3D 1 then I am hiding a big part of the > basic_string definition. Initially it was to avoid to have to include > basic_string.tcc but it is also a lot of useless code indeed. > > > > > >> There are some test failing when !_GLIBCXX_USE_CXX11_ABI that are > >> unrelated with my changes. I'll propose fixes in coming days. > > Which tests? I run the entire testsuite with > > -D_GLIBCXX_USE_CXX11_ABI=3D0 several times per day and I'm not seeing > > failures. > > > > I'll review the patch ASAP, thanks for working on it. > > > So far the only issue I found are in the mode !_GLIBCXX_USE_DUAL_ABI && > !_GLIBCXX_USE_CXX11_ABI. They are: > > 23_containers/unordered_map/96088.cc > 23_containers/unordered_multimap/96088.cc > 23_containers/unordered_multiset/96088.cc > 23_containers/unordered_set/96088.cc > ext/debug_allocator/check_new.cc > ext/malloc_allocator/check_new.cc > ext/malloc_allocator/deallocate_local.cc > ext/new_allocator/deallocate_local.cc > ext/pool_allocator/allocate_chunk.cc > ext/throw_allocator/deallocate_local.cc Ah yes, they fail for !USE_DUAL_ABI builds, I wonder why. /home/test/src/gcc/libstdc++-v3/testsuite/23_containers/unordered_map/96088= . cc:44: void test01(): Assertion '__gnu_test::counter::count() =3D=3D 3' fai= led. FAIL: 23_containers/unordered_map/96088.cc execution test > but not sure I'll try to fix those in this context. Right, those seem like something separate. > > Fran=C3=A7ois >