From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 6883D385800E
 for <libstdc++@gcc.gnu.org>; Wed,  2 Feb 2022 21:35:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6883D385800E
Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com
 [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-596-Ck7VUMj1MHK9l2jaBg6WBw-1; Wed, 02 Feb 2022 16:35:41 -0500
X-MC-Unique: Ck7VUMj1MHK9l2jaBg6WBw-1
Received: by mail-yb1-f198.google.com with SMTP id
 i203-20020a253bd4000000b006195f020a0cso1811176yba.14
 for <libstdc++@gcc.gnu.org>; Wed, 02 Feb 2022 13:35:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=1nNjjdfvBKCufmlBxeWXtRTTQCbkwWJsGny++iG/2lg=;
 b=gOCBsNMQT9S5oLJ/Aa9xQ43kvyoaWPgHEy+UOdG4/Wri49jtBqkhaXqyfSKXYAb0Go
 wYDdNCIswlWRuVdErwdniiqbAbuz35CameZjGfLzWe0a6AkVy/PUHgROCWwl9uIBgBik
 kztpdV5sekyA2XsvJgEZusfi1V8h5j5YVsg9wqwHLSKxUY13fAHjd5wj4SV9M/5p7dx/
 9NH7OQqKF9I9dImACYCcU/j3htSqYxoL0Znb+4ca9Bu3uKMZ0f4bm/C2lp+vHrBuiJ6J
 LjOllIKzFVZTSLZ1ArvJhTaSPmsESJS9zAe/IEjGiX1UbrsrsAfg3BG1VE50x6U1mjwm
 OzKA==
X-Gm-Message-State: AOAM532H9jKAEY2di0G9gks0Y43vhrx3I/N+27c/+7PyycHLtaTWZ/bC
 GWqvQt2CzbHO7GHjLiuISzKNVUBO8E/lmelIfCwERimCqf9+AtNgUqC8W3SEb5pvkqjLaU5h8Nb
 nvm75l2uiD8vrHjhsWITl0y8m6DnsxQg=
X-Received: by 2002:a25:d90a:: with SMTP id q10mr44820568ybg.253.1643837740613; 
 Wed, 02 Feb 2022 13:35:40 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwIZOsHmN/a9ung0TX/Xm8wthP62xWM1HE6h1IDkClv82EcU5WJIa4Ri/2ZWdgb/vetvGoFC8A3UbbKDT9it58=
X-Received: by 2002:a25:d90a:: with SMTP id q10mr44820558ybg.253.1643837740397; 
 Wed, 02 Feb 2022 13:35:40 -0800 (PST)
MIME-Version: 1.0
References: <CAMmuTO-PCj=F4QR8c3zoa9zW+CqLVYXG=JxT_ssYbaL+rzj+RQ@mail.gmail.com>
In-Reply-To: <CAMmuTO-PCj=F4QR8c3zoa9zW+CqLVYXG=JxT_ssYbaL+rzj+RQ@mail.gmail.com>
From: Jonathan Wakely <jwakely@redhat.com>
Date: Wed, 2 Feb 2022 21:35:29 +0000
Message-ID: <CACb0b4=yv-v=bt3JB=JL+NTNnprN6uXZqn2XHutiL-Wx5kPkKA@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: Add missing free functions for atomic_flag
 [PR103934]
To: Thomas Rodgers <trodgers@redhat.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc Patches <gcc-patches@gcc.gnu.org>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Feb 2022 21:35:48 -0000

>+  inline void
>+  atomic_flag_wait_explicit(const atomic_flag* __a, bool __old,
>+               std::memory_order __m) noexcept

No need for the std:: qualification, and check the indentation.


> libstdc++-v3/ChangeLog:
>
>    PR103934

This needs to include the component: PR libstdc++/103934

>    * include/std/atomic: Add missing free functions.

Please name the new functions in the changelog, in the usual format.
Just the names is fine, no need for the full signatures with
parameters.

OK for trunk with those changes.