From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 550343858C78 for ; Mon, 18 Mar 2024 07:46:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 550343858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 550343858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710747961; cv=none; b=TpEtxUXm7s6RV+YBTSNex2EZAClBIR0gm3UEjMurU/ijhJJ8713zIzdwhCUrrd8EzIuDBglgMjwg2IcwGdURFkny6sxn9z7FQX+AoN+oPTXv+tbg4YWIclC1ELEwSGbn28/nJVcSv/Eg7OM/Mad5L+O1sMOQH081+hQ4JZguDKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710747961; c=relaxed/simple; bh=KaREqQbChQEcnTGrhvVb3tq4lD2D88t0wS7s1+nJrKk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=JOmNm3VGI40LT77xOaKN//iLk5SqaDODIGJlkaZTerOJwdYUSQG98Nx1V8GO8xAG7BTDqjs9EObI5jV/GvlxFtriESHLftYRCeo5GCh4NeRQM49jifHORzZXPsuegqePVqDk3lgANkIKEWHIpbJMetuz1snnJORSS8OyQlzJM4U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710747959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xoxm8tNFOt5/HmgEUTNMhV3918pP0p9WeIG8OlfPwtY=; b=UmBik+kXl8jB7Q8XLRWeDJIeEbqj6o7liMdoJQJFddetZ6A54SCqypEGvYOObdOo5eC3+e CnnqxYZ6iQ9dSUeCEInGu19PKgY4eQA3aqRXQxmqSUK8JFmYQEklBA7jTMNlNVhaEUY61R z0Q1Todv1GxqOi56kWHk9/KxRZPbc7s= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-etxkujNhPeeBQc-iHI6bvQ-1; Mon, 18 Mar 2024 03:45:57 -0400 X-MC-Unique: etxkujNhPeeBQc-iHI6bvQ-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-609fe93b5cfso69551177b3.0 for ; Mon, 18 Mar 2024 00:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710747957; x=1711352757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoxm8tNFOt5/HmgEUTNMhV3918pP0p9WeIG8OlfPwtY=; b=CZRXx8fuwCtLHyvQ6Tynn5jOHB/xjtUlJgEOQjwgixTFV1qP+Lb5PRbhJw6P5lE5jk IILgSSDai2etTER7AtBRLrKv5fE3HUkDQM2n8DUOXYYJIK4uaOFy9emOT3ApnVx8LI5d sOFARThUeev4gbd0IXPXKtZSgsA0jG5Y7vWWMYYhWJRsjoTjX/Dn/lhu9f2NWaKdAb+3 3vKJWOTfJKBGdX6o4G6vqs9DTcQox+iIvt4K6EzSifK0RIPPy2OoAOS4Va4yLa6Y4kvj m29K3O12EGuMW5MsMDt0lomh2O1F5D1bkTfg3DiirS5gZAQvIMIgxnXcNB9XzbS7+cmB 3sog== X-Forwarded-Encrypted: i=1; AJvYcCULbskkNBKE+GUPQR9EcOW/tH4wWy3hUe/dBSdqN7PBkEOMN6l4wkX+r0lyPNXc74CIAt7UzfKJU5IPmKHebBdNB8LDtFw= X-Gm-Message-State: AOJu0YxkKtngODon0hU5UW98gllkGUudzGl5I0LNJ78hrLeBFGKRmyKu aHE3rTjisIcL91a+6ZuhCznq2t+GXWDeRLQ3E335/b+c1UoMi+RZQ3y0i8AT31ngqMWx2iuPdV/ ZXawW7NCOP6/CbnJVBRCW/QNs2ew/KHep7fU1Da88JRLgmsKTHgjoSIvquKYEzF7HT6cgCJyz9x wwZnxSLitcN8VWFWCCicBlscszkcs= X-Received: by 2002:a0d:fd87:0:b0:609:e4b4:c2fb with SMTP id n129-20020a0dfd87000000b00609e4b4c2fbmr10085653ywf.27.1710747956988; Mon, 18 Mar 2024 00:45:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2B3KQl2wKddNNAIhPEwd7gK1t/FNYix1KYjWQ7x0+obu6rFdNWLcHnQkFSzT+I5g1OHiF7fdZ5hOECdKPik4= X-Received: by 2002:a0d:fd87:0:b0:609:e4b4:c2fb with SMTP id n129-20020a0dfd87000000b00609e4b4c2fbmr10085649ywf.27.1710747956793; Mon, 18 Mar 2024 00:45:56 -0700 (PDT) MIME-Version: 1.0 References: <73AC0523-2237-46FD-9885-7AE3F8663DF2@gmail.com> <28CE4FD1-FFB0-4300-81CA-C3CB07E436A6@gmail.com> <19f5939a-9341-4237-90d9-4f1279f03a88@gmail.com> <2f29d2f2-a21b-42bb-997f-3918935d0dba@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Mon, 18 Mar 2024 07:45:40 +0000 Message-ID: Subject: Re: _LIBCXX_DEBUG value initialized singular iterators assert failures in std algorithms [PR104316] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 17 Mar 2024 at 16:52, Fran=C3=A7ois Dumont w= rote: > > > > > > OK for trunk, thanks! > > > > I think this is OK to backport to 13 too. > > > > Maybe after this we can define the __cpp_lib_null_itetators macro for > > debug mode? > > > After this fix of local_iterator I think we can indeed. > > In fact the added 11316.cc was already passing for > unordered_set<>::local_iterator but simply because we were missing the > singular check. Both issues solved with this patch. > > I found the version.def file to cleanup but no idea how to regenerate > version.h from it so I'll let you do it, ok ? Sure, I can do that. To regenerate it run 'make update-version' in the libstdc++-v3/include build directory. > > libstdc++: Fix _Safe_local_iterator<>::_M_valid_range > > Unordered container local_iterator range shall not contain any singu= lar > iterator unless both iterators are value-initialized. > > libstdc++-v3/ChangeLog: > > * include/debug/safe_local_iterator.tcc > (_Safe_local_iterator::_M_valid_range): Add > _M_value_initialized and > _M_singular checks. > * testsuite/23_containers/unordered_set/debug/114316.cc: > New test case. > > > Ok to commit ? OK.