public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
	Stephan Bergmann <sberg.fun@gmail.com>,
	 "libstdc++" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_GLIBCXX_DEBUG] Fix std::__niter_base behavior
Date: Tue, 20 Feb 2024 19:27:04 +0000	[thread overview]
Message-ID: <CACb0b4k3cY=At+KLP1m19yFbq2s7f0yy-1LZW3vDWkyXh9hfdQ@mail.gmail.com> (raw)
In-Reply-To: <a3b4b862-87f4-462a-b5bb-6c90f39ea562@gmail.com>

On Tue, 20 Feb 2024 at 18:43, François Dumont wrote:
>
>    libstdc++: [_GLIBCXX_DEBUG] Fix std::__niter_wrap behavior
>
>     In _GLIBCXX_DEBUG mode the std::__niter_base can remove 2 layers, the
>     __gnu_debug::_Safe_iterator<> and the __gnu_cxx::__normal_iterator<>.
>     When std::__niter_wrap is called to build a __gnu_debug::_Safe_iterator<>
>     from a __gnu_cxx::__normal_iterator<> we then have a consistency issue
>     as the difference between the 2 iterators will done on a __normal_iterator
>     on one side and a C pointer on the other. To avoid this problem call
>     std::__niter_base on both input iterators.
>
>     libstdc++-v3/ChangeLog:
>
>             * include/bits/stl_algobase.h (std::__niter_wrap): Add a call to
>             std::__niter_base on res iterator.
>
> Tested under Linux x86_64 normal and _GLIBCXX_DEBUG modes in c++98, c++11, c++17.
>
> Ok to commit ?
>

OK, thanks.


  reply	other threads:[~2024-02-20 19:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 18:39 François Dumont
2024-02-14 19:44 ` Jonathan Wakely
2024-02-14 21:48   ` François Dumont
2024-02-15 13:17     ` Jonathan Wakely
2024-02-15 18:38       ` François Dumont
2024-02-15 18:40         ` Jonathan Wakely
2024-02-17 14:14           ` François Dumont
2024-02-19  7:07             ` Stephan Bergmann
2024-02-19  8:12               ` Jonathan Wakely
2024-02-19  8:21                 ` Jonathan Wakely
2024-02-19 18:39                   ` François Dumont
2024-02-20 18:42                   ` François Dumont
2024-02-20 19:27                     ` Jonathan Wakely [this message]
2024-02-19 17:59               ` François Dumont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4k3cY=At+KLP1m19yFbq2s7f0yy-1LZW3vDWkyXh9hfdQ@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely.gcc@gmail.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=sberg.fun@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).