Re: [PING 2] [PATCH] libstdc++: basic_filebuf: don't flush more often than necessary.

[Jonathan Wakely <jwakely@redhat.com>]

On Thu, 6 Oct 2022 at 17:33, Charles-François Natali
<cf.natali@gmail.com> wrote:
>
> On Thu, Oct 6, 2022, 14:29 Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> Sorry for the lack of review. I've been trying to remember (and find)
>> some previous discussions related to this topic, but haven't managed
>> to find it yet.
>
>
> No worries!
>
>
>>
>> The patch does look sensible (and is the same as the one attached to
>> PR 63746) so I'll make sure to review it in time for the GCC 13
>> cut-off.
>>
>> I noticed that you contributed your test case with a FSF copyright
>> assignment header. Do you actually have a copyright assignment for GCC
>> contributions? If not, you would either need to complete that
>> paperwork with the FSF, or alternatively just contribute under the DCO
>> terms instead: https://gcc.gnu.org/dco.html
>
>
>
> I actually just copy-pasted the header from another test, would it be simpler if i just removed it?


Yes, that's probably the simplest solution, and then add a
Signed-off-by: tag in your patch email, to state you're contributing
it under the DCO terms (assuming of course that you are willing and
able to certify those terms).