public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "Charles-François Natali" <cf.natali@gmail.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PING 2] [PATCH] libstdc++: basic_filebuf: don't flush more often than necessary.
Date: Thu, 6 Oct 2022 17:55:53 +0100	[thread overview]
Message-ID: <CACb0b4k6btq4isvxsHBTC0ZUMkAxSf2WkNJKQGygSbW9Cw9G-w@mail.gmail.com> (raw)
In-Reply-To: <CAH_1eM0i8-Ls7reNvOGOHU5cxYVsaRx7JP7gKF5EeyMLAE3C0w@mail.gmail.com>

On Thu, 6 Oct 2022 at 17:33, Charles-François Natali
<cf.natali@gmail.com> wrote:
>
> On Thu, Oct 6, 2022, 14:29 Jonathan Wakely <jwakely@redhat.com> wrote:
>>
>> Sorry for the lack of review. I've been trying to remember (and find)
>> some previous discussions related to this topic, but haven't managed
>> to find it yet.
>
>
> No worries!
>
>
>>
>> The patch does look sensible (and is the same as the one attached to
>> PR 63746) so I'll make sure to review it in time for the GCC 13
>> cut-off.
>>
>> I noticed that you contributed your test case with a FSF copyright
>> assignment header. Do you actually have a copyright assignment for GCC
>> contributions? If not, you would either need to complete that
>> paperwork with the FSF, or alternatively just contribute under the DCO
>> terms instead: https://gcc.gnu.org/dco.html
>
>
>
> I actually just copy-pasted the header from another test, would it be simpler if i just removed it?


Yes, that's probably the simplest solution, and then add a
Signed-off-by: tag in your patch email, to state you're contributing
it under the DCO terms (assuming of course that you are willing and
able to certify those terms).


      parent reply	other threads:[~2022-10-06 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05 22:50 Charles-Francois Natali
     [not found] ` <CAH_1eM0MZDs8CP5oFFJm5X=O8GO=RJX7M=0G1x5iGcnvO3tteA@mail.gmail.com>
     [not found]   ` <CAH_1eM2xzo3rnXrxDpWCysP_qJYhZoxLwO0riAU7WdDPkp9yXA@mail.gmail.com>
2022-10-06 13:29     ` [PING 2] " Jonathan Wakely
     [not found]       ` <CAH_1eM0i8-Ls7reNvOGOHU5cxYVsaRx7JP7gKF5EeyMLAE3C0w@mail.gmail.com>
2022-10-06 16:55         ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACb0b4k6btq4isvxsHBTC0ZUMkAxSf2WkNJKQGygSbW9Cw9G-w@mail.gmail.com \
    --to=jwakely@redhat.com \
    --cc=cf.natali@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).