From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A017238650D0 for ; Thu, 6 Oct 2022 16:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A017238650D0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665075368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pu92HWYE+NIL0hV+Gty/sfEf9hLIkW6Gwnqq/tvQOyw=; b=F9jHSvEAqChq8AAaMo74wRxKNrqHKaiJF01rEbvJnvZ+7U1qGpx1H7CTNt0+YroJMAunkq Q/TsZsdzDIkhZG1mkrHEVdmlzjyvVeYNC4phXX3YJ1Bp18vvYE+S9SEqTrdXSzGs5usBEV ppTS0nvjGXlzuqBrMHGlY/hnOew8E7M= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-14-K_mtCPSxPe2361mIaC0tRQ-1; Thu, 06 Oct 2022 12:56:05 -0400 X-MC-Unique: K_mtCPSxPe2361mIaC0tRQ-1 Received: by mail-qv1-f70.google.com with SMTP id y14-20020a0cf14e000000b004afb3c6984bso1467809qvl.21 for ; Thu, 06 Oct 2022 09:56:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pu92HWYE+NIL0hV+Gty/sfEf9hLIkW6Gwnqq/tvQOyw=; b=G0g29mq8cq2C1YwjtxhB/h3QRkMcaZGAiS0xSvwQnwp0avjWf5d1n270xkiw0KbVbv ip4Zn4NW2z0bYV2YjbvipkQFp3AdYZbbB5iHNXXRN0Fs+FtfTs7uwGwEyg+qUIX5lunx 1C2x/3Yega4EJzdj5SgOBSE3rbkzPvn22ExACIvQIM8lFY5MVbtMceg5S3q8jzF9jVpF xIAtcycyx7o2u+sC8J/wqT0Xot3Dc4jZluKY9TmWH+v3QauQos+82QAmoLGDDz5d1qsv h02M5scKHzq3cH+M0k/nqLm5BNZ9sqZ5y1Wxp4VwLa2A88wMEa1hk6mm4dHffmrSEnql tyXg== X-Gm-Message-State: ACrzQf1hMrYafWRsTXqG2yZzL8S1ox9QtRBDyFxO40KnKb//MqKzL+Pq Q7T6U7SnT1mb7bdeiIJfVVZx9mQiEYI8GH/4oS6G2o07ic1U+mkJQxV8ho8Jg+5F4dC2GBdNlS+ P0LmkKGSX5B76zdG91k6AQRhx1MmLlnM= X-Received: by 2002:a0c:9a0d:0:b0:4b1:982e:96d4 with SMTP id p13-20020a0c9a0d000000b004b1982e96d4mr585718qvd.114.1665075364589; Thu, 06 Oct 2022 09:56:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5QB6c3ELxjzk+iscCGnlmCSPEgfQBHA5ubgt6Q8lKz3ba/zhcqbBGA/11FFnz1mDUW+Pq0zvdred26OZTO7dQ= X-Received: by 2002:a0c:9a0d:0:b0:4b1:982e:96d4 with SMTP id p13-20020a0c9a0d000000b004b1982e96d4mr585699qvd.114.1665075364359; Thu, 06 Oct 2022 09:56:04 -0700 (PDT) MIME-Version: 1.0 References: <20220905225046.193799-1-cf.natali@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 6 Oct 2022 17:55:53 +0100 Message-ID: Subject: Re: [PING 2] [PATCH] libstdc++: basic_filebuf: don't flush more often than necessary. To: =?UTF-8?Q?Charles=2DFran=C3=A7ois_Natali?= Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 6 Oct 2022 at 17:33, Charles-Fran=C3=A7ois Natali wrote: > > On Thu, Oct 6, 2022, 14:29 Jonathan Wakely wrote: >> >> Sorry for the lack of review. I've been trying to remember (and find) >> some previous discussions related to this topic, but haven't managed >> to find it yet. > > > No worries! > > >> >> The patch does look sensible (and is the same as the one attached to >> PR 63746) so I'll make sure to review it in time for the GCC 13 >> cut-off. >> >> I noticed that you contributed your test case with a FSF copyright >> assignment header. Do you actually have a copyright assignment for GCC >> contributions? If not, you would either need to complete that >> paperwork with the FSF, or alternatively just contribute under the DCO >> terms instead: https://gcc.gnu.org/dco.html > > > > I actually just copy-pasted the header from another test, would it be sim= pler if i just removed it? Yes, that's probably the simplest solution, and then add a Signed-off-by: tag in your patch email, to state you're contributing it under the DCO terms (assuming of course that you are willing and able to certify those terms).