From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9AE6F3857C5D for ; Wed, 20 Oct 2021 18:58:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9AE6F3857C5D Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-PZXgVq1vMD6SEiQuDV_ZIw-1; Wed, 20 Oct 2021 14:58:53 -0400 X-MC-Unique: PZXgVq1vMD6SEiQuDV_ZIw-1 Received: by mail-vk1-f200.google.com with SMTP id s126-20020a1ff484000000b002a5127da9a8so3714413vkh.9 for ; Wed, 20 Oct 2021 11:58:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E6aAtN3Mp4hbYEAXes3hKu+XpNjgYW/DIOpxHfzAXJw=; b=rjNPvxZG8DwGtRmOo3EpXUcdby2EQXlopQ7sSYobKhuPYmSwwznenIwbNDpo55jRys g94iCQXvMf2uR7um49PeMaTNxHgzNGR1Yd3bEzER4h+p0aoxuiyOm8B8nWv4UNzJxRgr +GnNxYElhr9nURMmnl9VdYNENTVwhVmdFMl1MjTnRJPMBeN2ZkYmuhQFAmH4DM+5Sk8n 2+Gna9srEN6NigDnzFbHi5FB5fO+GJCHsJOl5DwyS4ltxViPmYvOU9uDVoYYp/7r+XHX DhIeZA2EW7osFbHHTkwhnCO8pInWLsr0Y+WG+rBstBEDvm55n3rwbGxfZH6zRcG3mrcK 4uoQ== X-Gm-Message-State: AOAM532Ua5MYV6uc99cbzAMDV/cM4cm9Ii26SEWjSeP/ihfTk7DsTHec iTEfLCf7b9Uq3AUym1zQUibhzTgMNQRLNh4U94H5iehQQb4SIpm6MCNuVMkvKb6ReYo5rXIHtk3 SPQVuY/CfSFElObkPCTEbPIpz0++qgS0= X-Received: by 2002:a67:1c04:: with SMTP id c4mr954374vsc.11.1634756332781; Wed, 20 Oct 2021 11:58:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwj5gwBdz1M2bQ1/F57Q/uH2h6YUaOcQLbSMJzk2BRoJBJyxdSKJ3XpX0DKDeYFxLImN2QLUEDp9e+qOweQdh0= X-Received: by 2002:a67:1c04:: with SMTP id c4mr954345vsc.11.1634756332541; Wed, 20 Oct 2021 11:58:52 -0700 (PDT) MIME-Version: 1.0 References: <20211020170026.1827253-1-ppalka@redhat.com> In-Reply-To: <20211020170026.1827253-1-ppalka@redhat.com> From: Jonathan Wakely Date: Wed, 20 Oct 2021 19:58:41 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Implement LWG 3595 changes to common_iterator To: Patrick Palka Cc: gcc Patches , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2021 18:58:55 -0000 On Wed, 20 Oct 2021 at 18:04, Patrick Palka via Libstdc++ wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk and branches? I thought I'd already done this one, maybe I have it in a local Git stash. OK for all branches, thanks. > > libstdc++-v3/ChangeLog: > > * include/bits/stl_iterator.h (common_iterator::__arrow_proxy): > Make fully constexpr. > (common_iterator::__postfix_proxy): Likewise. > --- > libstdc++-v3/include/bits/stl_iterator.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libstdc++-v3/include/bits/stl_iterator.h b/libstdc++-v3/include/bits/stl_iterator.h > index 8afd6756613..da3c8d5bd97 100644 > --- a/libstdc++-v3/include/bits/stl_iterator.h > +++ b/libstdc++-v3/include/bits/stl_iterator.h > @@ -1821,13 +1821,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { > iter_value_t<_It> _M_keep; > > - __arrow_proxy(iter_reference_t<_It>&& __x) > + constexpr __arrow_proxy(iter_reference_t<_It>&& __x) > : _M_keep(std::move(__x)) { } > > friend class common_iterator; > > public: > - const iter_value_t<_It>* > + constexpr const iter_value_t<_It>* > operator->() const noexcept > { return std::__addressof(_M_keep); } > }; > @@ -1836,13 +1836,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { > iter_value_t<_It> _M_keep; > > - __postfix_proxy(iter_reference_t<_It>&& __x) > + constexpr __postfix_proxy(iter_reference_t<_It>&& __x) > : _M_keep(std::forward>(__x)) { } > > friend class common_iterator; > > public: > - const iter_value_t<_It>& > + constexpr const iter_value_t<_It>& > operator*() const noexcept > { return _M_keep; } > }; > -- > 2.33.1.711.g9d530dc002 >