From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 783E33857C47 for ; Wed, 10 Nov 2021 11:55:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 783E33857C47 Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-151-Vqzpy_fLO0amL2DrYaG4nQ-1; Wed, 10 Nov 2021 06:55:39 -0500 X-MC-Unique: Vqzpy_fLO0amL2DrYaG4nQ-1 Received: by mail-yb1-f199.google.com with SMTP id m78-20020a252651000000b005c1f44d3c7bso3491650ybm.22 for ; Wed, 10 Nov 2021 03:55:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jhf21YR/mPyC3TPFk3uQdQ/0zhv1kib0BjKnlX7+r94=; b=kAwwp8eucLQmM2Ysb3sEcHVKuk0Vlz7wjVv0gT5bE2pQbAbsa69jKcRJgbhnMAEFlp Ue2VmjUgHoiUDdXGo7fFOfM1pWseppS4NbWeqBgoqhuEcheOu87PmCWPecZkmbluQfev m/mRlBQ5mXhRaeMpO0q3zpHP4pTw3QKDB6pwaoNq5747mK2AU0YrIH56fjfSj9rOsG0O GVnwf103ctm3KRvHWdKyXb1Oa6+23ooiQ+syBDq1BDi/BYH9oTMcTKnQRtulvzGxlWUy wGSY/msNCznUA0X30/ou6PSf/tZgBa+tQPJ0BB2RCR3AjFH2ZuqHO12CRqnd5xMA9EGu odxA== X-Gm-Message-State: AOAM531njNrXVhiY1b+ylOsKzb8z4oC0uNTf4AS3l1EIA2nH58Wcyu42 IPjFrkgxDM4T1MILdemtDbhSEiAFbXw98ipp0ZhyRPpy151xHIgFhbvV2NALug72pvr86hL75Hv T6HDm2cvicKp44SdpdjM66cl5hxB4PSQ= X-Received: by 2002:a25:acdd:: with SMTP id x29mr16669115ybd.96.1636545338658; Wed, 10 Nov 2021 03:55:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsnJBzouFMRTYJ+Jl1Uc1byqs1+Ls5hFiLMRWYEfnev2+7NX7H7lIUnkgRtB7DhSqzrk3NBtwbZdPlljwMUT8= X-Received: by 2002:a25:acdd:: with SMTP id x29mr16669096ybd.96.1636545338478; Wed, 10 Nov 2021 03:55:38 -0800 (PST) MIME-Version: 1.0 References: <4eec3fb9-851e-3e4e-f9f4-1110db3af747@gmail.com> <6c349652-8b6f-2027-08c3-6ce58a765aeb@gmail.com> <22bf1b42-8cf4-7a6e-d5dc-c322ccbb2b46@gmail.com> <68641ea0-2a14-e3a5-8315-a7b3a9c1fdb4@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 10 Nov 2021 11:55:27 +0000 Message-ID: Subject: Re: [PATH][_GLIBCXX_DEBUG] Fix unordered container merge To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 11:55:43 -0000 On Tue, 9 Nov 2021 at 16:25, Jonathan Wakely wrote: > > > On Mon, 8 Nov 2021 at 21:36, Fran=C3=A7ois Dumont = wrote: > >> Yet another version this time with only 1 guard implementation. The >> predicate to invalidate the safe iterators has been externalized. >> >> Ok to commit ? >> > > I like this version a lot - thanks for persisting with it. > > I'm seeing new failures with this: make check RUNTESTFLAGS=3D"conformance.exp=3D23_containers/*/invalidation/* --target_board=3Dunix/-D_GLIBCXX_DEBUG/-std=3Dgnu++98" FAIL: 23_containers/deque/debug/invalidation/1.cc (test for excess errors) FAIL: 23_containers/list/debug/invalidation/1.cc (test for excess errors) FAIL: 23_containers/map/debug/invalidation/1.cc (test for excess errors) FAIL: 23_containers/multimap/debug/invalidation/1.cc (test for excess errors) FAIL: 23_containers/multiset/debug/invalidation/1.cc (test for excess errors) FAIL: 23_containers/set/debug/invalidation/1.cc (test for excess errors) FAIL: 23_containers/vector/debug/invalidation/1.cc (test for excess errors)