From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 654C63858419 for ; Tue, 12 Sep 2023 16:09:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 654C63858419 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694534982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6MI8ROdEejAqX7wogz8fn6qn1T0irxUcKFvflZlKxfY=; b=S6jVhlbtR2Ip7TyywJ03f3XoWPl8nu8C4uq7o6kEzqHj5vnBViJuNthMIUJHx55Mm+vl89 +EPCR4my1V3+BBmdHRjgf8I/HTeFBjERLBKHr1hniWVNdmO4bmT17YjwfQGpifALGOcKCB GQpMJSYJW1X7uvGfIhOdjI81hOxm4go= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-J_fzL3AIPqKy8orRUL--Tw-1; Tue, 12 Sep 2023 12:09:40 -0400 X-MC-Unique: J_fzL3AIPqKy8orRUL--Tw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bce272ebdfso64347991fa.1 for ; Tue, 12 Sep 2023 09:09:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694534979; x=1695139779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6MI8ROdEejAqX7wogz8fn6qn1T0irxUcKFvflZlKxfY=; b=XYLHghKwDbPevHBuFS5/xj+CcBDCX8UswumyjmcTLXs4AqX8soz2rVdoN5iGOyQoNE ISBVsRyjNh/oc9tThpPM7QzzjfAdk6QapV9FmgGCoZyb/ZtvIxYp7qtYvXlc2MO3iGKx 0+n3ZpJijuyJ0MgUHYyl8CmAGirFAVwYjYE05XqTFMZupKna/v22VRPJhfDTImNJq0M5 gmY49+JlXD4iPigRdnfCKL5nSPBAyJnGQRD7c3F6Q1JmhTqx0pS2yaXFTDEmlKG9ApXM L5TMAgI9P4QCEiBkjJ7GkiXBIkhqrGNrMDFwAvlYCubiRwDsTOzt5hMM4BR960CbUG8h C95Q== X-Gm-Message-State: AOJu0Yyb/ofVxXQ3K3So5uQ1Cr99bhCNb0QqWV968XZfd5VNSnPM8q2c AGeSVpzGO5wdQjiH5Tn8dhghlFJDVSQvSQ5AbQ27KZWtteTiBvums53RHLZ3cKsqhJ2njLqP3X+ etKMMsZU+MHEoqfOwWLyeFGij4nt2XGU= X-Received: by 2002:a2e:83d7:0:b0:2bc:b88c:64ed with SMTP id s23-20020a2e83d7000000b002bcb88c64edmr192928ljh.12.1694534979169; Tue, 12 Sep 2023 09:09:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8ySNiqmZ8PR2xLsmpJ6ML2Xpo2RbtGwpPLpCXlD4F6GHZXLOJOLz5mH4HDjqvuFm2XHsH2hlG47E9G1V5O38= X-Received: by 2002:a2e:83d7:0:b0:2bc:b88c:64ed with SMTP id s23-20020a2e83d7000000b002bcb88c64edmr192908ljh.12.1694534978817; Tue, 12 Sep 2023 09:09:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 12 Sep 2023 17:09:27 +0100 Message-ID: Subject: Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: rs2740@gmail.com, "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 11 Sept 2023 at 18:19, Fran=C3=A7ois Dumont = wrote: > > > On 11/09/2023 13:51, Jonathan Wakely wrote: > > On Sun, 10 Sept 2023 at 14:57, Fran=C3=A7ois Dumont via Libstdc++ > > wrote: > >> Following confirmation of the fix by TC here is the patch where I'm > >> simply adding a 'constexpr' on _M_next(). > >> > >> Please let me know this ChangeLog entry is correct. I would prefer thi= s > >> patch to be assigned to 'TC' with me as co-author but I don't know how > >> to do such a thing. Unless I need to change my user git identity to do= so ? > > Sam already explained that, but please check with Tim how he wants to > > be credited, if at all. He doesn't have a copyright assignment, and > > hasn't added a DCO sign-off to the patch, but it's small enough to not > > need it as this is the first contribution credited to him. > > > > > >> libstdc++: Add constexpr qualification to _Hash_node::_M_next() > > What has this constexpr addition got to do with the ABI change and the > > always_inline attributes? > > > > It certainly doesn't seem like it should be the summary line of the > > git commit message. > > Oops, sorry, that's what I had started to do before Tim submitted anythin= g. > > Here is latest version: No patch attached, and the ChangeLog below still mentions the constexpr. I've pinged Tim via another channel to ask him about the author attribution= . > > Author: TC > Date: Wed Sep 6 19:31:55 2023 +0200 > > libstdc++: Force inline on _Hash_node_value_base methods to fix abi > (PR111050) > > https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3D1b6f0476837205932613d= db2b3429a55c26c409d > changed _Hash_node_value_base to no longer derive from > _Hash_node_base, which means > that its member functions expect _M_storage to be at a different > offset. So explosions > result if an out-of-line definition is emitted for any of the > member functions (say, > in a non-optimized build) and the resulting object file is then > linked with code built > using older version of GCC/libstdc++. > > libstdc++-v3/ChangeLog: > > PR libstdc++/111050 > * include/bits/hashtable_policy.h > (_Hash_node_value_base<>::_M_valptr(), > _Hash_node_value_base<>::_M_v()) > Add [[__gnu__::__always_inline__]]. > (_Hash_node<>::_M_next()): Add constexpr. > > Co-authored-by: Fran=C3=A7ois Dumont > > Ok for you TC (Tim ?) ? > >