From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 41914388451F for ; Fri, 18 Mar 2022 12:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41914388451F Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-Yi6nJSX0OlS7EnVaZEZHhQ-1; Fri, 18 Mar 2022 08:21:23 -0400 X-MC-Unique: Yi6nJSX0OlS7EnVaZEZHhQ-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-2d726bd83a2so69525967b3.20 for ; Fri, 18 Mar 2022 05:21:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ov90wIozI3ThZPyLOCSH5YDw1Cq/Y2o/Mz1RvwVJIks=; b=vZsbehnGTfdmqG3hCUrW9t8FWoJ6WXQ9QXk905CE0yLVgE9lZS2pC1TQnJax0gHdcN mgMtFuiuMTltLEl6hVab3D9wx9/d/Mr+hMcQ5VhRZ8u9wLZy1vHQ3XI3T0VyjNdkv2bi yxC/zPMIYGx1WDPgyHQg7taRuDCNsEXWZIC7xbSjmTYuxLjJAY+r1/O4lOWKudS2pAvt fndh2XRTfhESsB2WXisottoONv3eu2gPnN4Kf8xbi5y+Re6V+dE1+3cWZkf7w/SATwYk UIBPB6tI99Z8HYWunI+TfWTy/dB6AyrTbwB6unnPfydfBa7LKT2NP8NOerZvuD/oLGth nBrw== X-Gm-Message-State: AOAM532rlahfNEPBl1B141nqntBvZS+mMa8NvqIeZLXSJgnOUAlqQEY0 v2XoTLm4KAzac8bw7b3urT+83kQ52Y2qEphceFKq1bvLPFb6sOCePKRRRb87RBa90x2Js4bxTNf EGyvx6B53CNMqpru2zChDIZvg9bEPfK8= X-Received: by 2002:a0d:f883:0:b0:2d0:ee66:5f97 with SMTP id i125-20020a0df883000000b002d0ee665f97mr10465592ywf.313.1647606083104; Fri, 18 Mar 2022 05:21:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdtL/2cf6p6yEJiT1FLsy8JxY52EoSeZ4s1bJsm7kmf69cQ4NaZdSwrHpI2OKWqge9iDc2zXlsRhve0sDeaqw= X-Received: by 2002:a0d:f883:0:b0:2d0:ee66:5f97 with SMTP id i125-20020a0df883000000b002d0ee665f97mr10465563ywf.313.1647606082840; Fri, 18 Mar 2022 05:21:22 -0700 (PDT) MIME-Version: 1.0 References: <20220316212453.243636-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 18 Mar 2022 12:21:11 +0000 Message-ID: Subject: Re: [committed] libstdc++: Fix symbol versioning for Solaris 11.3 [PR103407] To: Rainer Orth Cc: "libstdc++" , gcc Patches , Rainer Orth X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 12:21:26 -0000 On Fri, 18 Mar 2022 at 11:49, Rainer Orth wrote: > > Hi Jonathan, > > > Tested x86_64-linux and sparc-sun-solaris2.11 (but 11.3 only). > > > > Pushed to trunk. > > > > Rainer, this should allow you to continue omitting the > > _ZSt10from_charsPKcS0_R[def]St12chars_format symbols from the baseline, > > without the current FAIL. Please check on your other Solaris targets. > > I've run bootstraps on i386-pc-solaris2.11 (Solaris 11.3 and 11.4) and > sparc-sun-solaris2.11 (Solaris 11.4) last night: the abi_check failures > are gone everywhere. Hooray! I did some very brief testing and it seemed like a program linked to the Solaris 11.3 libstdc++.so.6.0.30 (with from_chars@GLIBCXX_3.4.30) can still run against libstdc++.so.6.0.30 with from_chars@GLIBCXX_3.4.29 (which should match what you get on Solaris 11.4 if I correctly fiddled with the versioning). So I don't understand how the Solaris runtime linker handles symbol versions, but it seems like there's no backwards compatibility problem for the Solaris 11.4 build of libstdc++.so.6.0.30.